Commit 617fffee authored by Peter Geoghegan's avatar Peter Geoghegan

Rename removable xid function for consistency.

GlobalVisIsRemovableFullXid() is now GlobalVisCheckRemovableFullXid().
This is consistent with the general convention for FullTransactionId
equivalents of functions that deal with TransactionId values.  It now
matches the nearby GlobalVisCheckRemovableXid() function, which performs
the same check for callers that use TransactionId values.

Oversight in commit dc7420c2.

Discussion: https://postgr.es/m/CAH2-Wzmes12jFNDcVgpU89Vp=r6uLFrE-MT0fjSWGsE70UiNaA@mail.gmail.com
parent d1d29798
...@@ -914,7 +914,7 @@ gistPageRecyclable(Page page) ...@@ -914,7 +914,7 @@ gistPageRecyclable(Page page)
*/ */
FullTransactionId deletexid_full = GistPageGetDeleteXid(page); FullTransactionId deletexid_full = GistPageGetDeleteXid(page);
return GlobalVisIsRemovableFullXid(NULL, deletexid_full); return GlobalVisCheckRemovableFullXid(NULL, deletexid_full);
} }
return false; return false;
} }
......
...@@ -388,7 +388,7 @@ gistRedoPageReuse(XLogReaderState *record) ...@@ -388,7 +388,7 @@ gistRedoPageReuse(XLogReaderState *record)
* pages in the index via the FSM. That's all they do though. * pages in the index via the FSM. That's all they do though.
* *
* latestRemovedXid was the page's deleteXid. The * latestRemovedXid was the page's deleteXid. The
* GlobalVisIsRemovableFullXid(deleteXid) test in gistPageRecyclable() * GlobalVisCheckRemovableFullXid(deleteXid) test in gistPageRecyclable()
* conceptually mirrors the PGPROC->xmin > limitXmin test in * conceptually mirrors the PGPROC->xmin > limitXmin test in
* GetConflictingVirtualXIDs(). Consequently, one XID value achieves the * GetConflictingVirtualXIDs(). Consequently, one XID value achieves the
* same exclusion effect on primary and standby. * same exclusion effect on primary and standby.
......
...@@ -4146,7 +4146,7 @@ GlobalVisTestNonRemovableHorizon(GlobalVisState *state) ...@@ -4146,7 +4146,7 @@ GlobalVisTestNonRemovableHorizon(GlobalVisState *state)
* GlobalVisTestIsRemovableFullXid(), see their comments. * GlobalVisTestIsRemovableFullXid(), see their comments.
*/ */
bool bool
GlobalVisIsRemovableFullXid(Relation rel, FullTransactionId fxid) GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid)
{ {
GlobalVisState *state; GlobalVisState *state;
......
...@@ -155,7 +155,7 @@ extern bool GlobalVisTestIsRemovableFullXid(GlobalVisState *state, FullTransacti ...@@ -155,7 +155,7 @@ extern bool GlobalVisTestIsRemovableFullXid(GlobalVisState *state, FullTransacti
extern FullTransactionId GlobalVisTestNonRemovableFullHorizon(GlobalVisState *state); extern FullTransactionId GlobalVisTestNonRemovableFullHorizon(GlobalVisState *state);
extern TransactionId GlobalVisTestNonRemovableHorizon(GlobalVisState *state); extern TransactionId GlobalVisTestNonRemovableHorizon(GlobalVisState *state);
extern bool GlobalVisCheckRemovableXid(Relation rel, TransactionId xid); extern bool GlobalVisCheckRemovableXid(Relation rel, TransactionId xid);
extern bool GlobalVisIsRemovableFullXid(Relation rel, FullTransactionId fxid); extern bool GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid);
/* /*
* Utility functions for implementing visibility routines in table AMs. * Utility functions for implementing visibility routines in table AMs.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment