Skip to content

P
Postgres FD Implementation
Commit 5dd1c713 authored by Tom Lane's avatar Tom Lane
Browse files
Options

Oops, forgot we had a macro to encapsulate test for type toastability.

parent 3faf224a
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 4 deletions
src/backend/commands/tablecmds.c
View file @ 5dd1c713
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.6 2002/04/22 21:46:11 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.7 2002/04/22 21:56:06 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -888,10 +888,9 @@ AlterTableAlterColumnFlags(Oid myrelid, ...@@ -888,10 +888,9 @@ AlterTableAlterColumnFlags(Oid myrelid,
{ {
/* /*
* safety check: do not allow toasted storage modes unless column * safety check: do not allow toasted storage modes unless column
* datatype is TOAST-aware. We assume the datatype's typstorage * datatype is TOAST-aware.
* will be 'p' if and only if it ain't TOAST-aware.
*/ */
if (newstorage == 'p' || get_typstorage(attrtuple->atttypid) != 'p') if (newstorage == 'p' || TypeIsToastable(attrtuple->atttypid))
attrtuple->attstorage = newstorage; attrtuple->attstorage = newstorage;
else else
elog(ERROR, "ALTER TABLE: Column datatype %s can only have storage \"plain\"", elog(ERROR, "ALTER TABLE: Column datatype %s can only have storage \"plain\"",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment