Commit 50ed78b8 authored by Tom Lane's avatar Tom Lane

Allow 60 in seconds fields of timestamp, time, interval input values.

Per recent discussion on pgsql-general, this is appropriate for spec
compliance, and has the nice side-effect of easing porting from old
pg_dump files that exhibit the 59.999=>60.000 roundoff problem.
parent d1b4327d
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/adt/datetime.c,v 1.103 2003/04/04 04:50:44 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/adt/datetime.c,v 1.104 2003/05/04 04:30:15 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -2080,15 +2080,16 @@ DecodeTimeOnly(char **field, int *ftype, int nf, ...@@ -2080,15 +2080,16 @@ DecodeTimeOnly(char **field, int *ftype, int nf,
tm->tm_hour += 12; tm->tm_hour += 12;
#ifdef HAVE_INT64_TIMESTAMP #ifdef HAVE_INT64_TIMESTAMP
if (((tm->tm_hour < 0) || (tm->tm_hour > 23)) if ((tm->tm_hour < 0) || (tm->tm_hour > 23)
|| ((tm->tm_min < 0) || (tm->tm_min > 59)) || (tm->tm_min < 0) || (tm->tm_min > 59)
|| ((tm->tm_sec < 0) || (tm->tm_sec > 60)) || (tm->tm_sec < 0) || (tm->tm_sec > 60)
|| (*fsec < INT64CONST(0)) || (*fsec >= INT64CONST(1000000))) || (*fsec < INT64CONST(0)) || (*fsec >= INT64CONST(1000000)))
return -1; return -1;
#else #else
if (((tm->tm_hour < 0) || (tm->tm_hour > 23)) if ((tm->tm_hour < 0) || (tm->tm_hour > 23)
|| ((tm->tm_min < 0) || (tm->tm_min > 59)) || (tm->tm_min < 0) || (tm->tm_min > 59)
|| ((tm->tm_sec < 0) || ((tm->tm_sec + *fsec) >= 60))) || (tm->tm_sec < 0) || (tm->tm_sec > 60)
|| (*fsec < 0) || (*fsec >= 1))
return -1; return -1;
#endif #endif
...@@ -2313,14 +2314,14 @@ DecodeTime(char *str, int fmask, int *tmask, struct tm * tm, fsec_t *fsec) ...@@ -2313,14 +2314,14 @@ DecodeTime(char *str, int fmask, int *tmask, struct tm * tm, fsec_t *fsec)
#ifdef HAVE_INT64_TIMESTAMP #ifdef HAVE_INT64_TIMESTAMP
if ((tm->tm_hour < 0) if ((tm->tm_hour < 0)
|| (tm->tm_min < 0) || (tm->tm_min > 59) || (tm->tm_min < 0) || (tm->tm_min > 59)
|| (tm->tm_sec < 0) || (tm->tm_sec > 59) || (tm->tm_sec < 0) || (tm->tm_sec > 60)
|| (*fsec >= INT64CONST(1000000))) || (*fsec < INT64CONST(0)) || (*fsec >= INT64CONST(1000000)))
return -1; return -1;
#else #else
if ((tm->tm_hour < 0) if ((tm->tm_hour < 0)
|| (tm->tm_min < 0) || (tm->tm_min > 59) || (tm->tm_min < 0) || (tm->tm_min > 59)
|| (tm->tm_sec < 0) || (tm->tm_sec > 59) || (tm->tm_sec < 0) || (tm->tm_sec > 60)
|| (*fsec >= 1)) || (*fsec < 0) || (*fsec >= 1))
return -1; return -1;
#endif #endif
......
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/adt/nabstime.c,v 1.106 2003/04/04 04:50:44 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/adt/nabstime.c,v 1.107 2003/05/04 04:30:15 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -320,9 +320,9 @@ tm2abstime(struct tm * tm, int tz) ...@@ -320,9 +320,9 @@ tm2abstime(struct tm * tm, int tz)
if (tm->tm_year < 1901 || tm->tm_year > 2038 if (tm->tm_year < 1901 || tm->tm_year > 2038
|| tm->tm_mon < 1 || tm->tm_mon > 12 || tm->tm_mon < 1 || tm->tm_mon > 12
|| tm->tm_mday < 1 || tm->tm_mday > 31 || tm->tm_mday < 1 || tm->tm_mday > 31
|| tm->tm_hour < 0 || tm->tm_hour >= 24 || tm->tm_hour < 0 || tm->tm_hour > 23
|| tm->tm_min < 0 || tm->tm_min > 59 || tm->tm_min < 0 || tm->tm_min > 59
|| tm->tm_sec < 0 || tm->tm_sec > 59) || tm->tm_sec < 0 || tm->tm_sec > 60)
return INVALID_ABSTIME; return INVALID_ABSTIME;
day = date2j(tm->tm_year, tm->tm_mon, tm->tm_mday) - UNIX_EPOCH_JDATE; day = date2j(tm->tm_year, tm->tm_mon, tm->tm_mday) - UNIX_EPOCH_JDATE;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment