Skip to content

P
Postgres FD Implementation
Commit 43aa40e1 authored by Bruce Momjian's avatar Bruce Momjian
Browse files
Options

In pg_upgrade, add C comment about why we don't try to do shared file 

writes for logging.
parent a9f0dbc3
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
contrib/pg_upgrade/pg_upgrade.h
View file @ 43aa40e1
...@@ -207,6 +207,10 @@ typedef struct ...@@ -207,6 +207,10 @@ typedef struct
* because it is being used by another process." so we have to send all * because it is being used by another process." so we have to send all
* other output to 'nul'. Therefore, we set this to DEVNULL on Win32, and * other output to 'nul'. Therefore, we set this to DEVNULL on Win32, and
* it equals 'filename' on all other platforms. * it equals 'filename' on all other platforms.
*
* We could use the Windows pgwin32_open() flags to allow shared file
* writes but is unclear how all other tools would use those flags, so
* we just avoid it and log a little less on Windows.
*/ */
char *filename2; char *filename2;
FILE *fd; /* log FILE */ FILE *fd; /* log FILE */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment