Commit 42e61c77 authored by Tom Lane's avatar Tom Lane

Include contrib modules in the temp installation even without REGRESS.

Now that we have TAP tests, a contrib module may have something useful
to do in "make check" even if it has no pg_regress-style regression
scripts, and hence no REGRESS setting.  But the TAP tests will fail,
or else test the wrong installed files, unless we install the contrib
module into the temp installation.  So move the bit about adding to
EXTRA_INSTALL so that it applies regardless.

We might want this in back branches in future, but for the moment
I only risked adding it to v11.

Discussion: https://postgr.es/m/12438.1535488750@sss.pgh.pa.us
parent bf2d0462
...@@ -359,10 +359,12 @@ check: ...@@ -359,10 +359,12 @@ check:
else else
check: submake $(REGRESS_PREP) check: submake $(REGRESS_PREP)
$(pg_regress_check) $(REGRESS_OPTS) $(REGRESS) $(pg_regress_check) $(REGRESS_OPTS) $(REGRESS)
endif
endif # REGRESS
ifndef NO_TEMP_INSTALL
temp-install: EXTRA_INSTALL+=$(subdir) temp-install: EXTRA_INSTALL+=$(subdir)
endif endif
endif # REGRESS
# STANDARD RULES # STANDARD RULES
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment