Commit 39ac5591 authored by Noah Misch's avatar Noah Misch

Reconcile nodes/*funcs.c with PostgreSQL 10 work.

The _equalTableFunc() omission of coltypmods has semantic significance,
but I did not track down resulting user-visible bugs, if any.  The other
changes are cosmetic only, affecting order.  catversion bump due to
readfuncs.c field order change.
parent c254970a
...@@ -1222,8 +1222,8 @@ _copyTableFunc(const TableFunc *from) ...@@ -1222,8 +1222,8 @@ _copyTableFunc(const TableFunc *from)
{ {
TableFunc *newnode = makeNode(TableFunc); TableFunc *newnode = makeNode(TableFunc);
COPY_NODE_FIELD(ns_names);
COPY_NODE_FIELD(ns_uris); COPY_NODE_FIELD(ns_uris);
COPY_NODE_FIELD(ns_names);
COPY_NODE_FIELD(docexpr); COPY_NODE_FIELD(docexpr);
COPY_NODE_FIELD(rowexpr); COPY_NODE_FIELD(rowexpr);
COPY_NODE_FIELD(colnames); COPY_NODE_FIELD(colnames);
...@@ -4005,8 +4005,8 @@ _copyCreateForeignServerStmt(const CreateForeignServerStmt *from) ...@@ -4005,8 +4005,8 @@ _copyCreateForeignServerStmt(const CreateForeignServerStmt *from)
COPY_STRING_FIELD(servertype); COPY_STRING_FIELD(servertype);
COPY_STRING_FIELD(version); COPY_STRING_FIELD(version);
COPY_STRING_FIELD(fdwname); COPY_STRING_FIELD(fdwname);
COPY_NODE_FIELD(options);
COPY_SCALAR_FIELD(if_not_exists); COPY_SCALAR_FIELD(if_not_exists);
COPY_NODE_FIELD(options);
return newnode; return newnode;
} }
...@@ -4031,8 +4031,8 @@ _copyCreateUserMappingStmt(const CreateUserMappingStmt *from) ...@@ -4031,8 +4031,8 @@ _copyCreateUserMappingStmt(const CreateUserMappingStmt *from)
COPY_NODE_FIELD(user); COPY_NODE_FIELD(user);
COPY_STRING_FIELD(servername); COPY_STRING_FIELD(servername);
COPY_NODE_FIELD(options);
COPY_SCALAR_FIELD(if_not_exists); COPY_SCALAR_FIELD(if_not_exists);
COPY_NODE_FIELD(options);
return newnode; return newnode;
} }
......
...@@ -119,13 +119,13 @@ _equalRangeVar(const RangeVar *a, const RangeVar *b) ...@@ -119,13 +119,13 @@ _equalRangeVar(const RangeVar *a, const RangeVar *b)
static bool static bool
_equalTableFunc(const TableFunc *a, const TableFunc *b) _equalTableFunc(const TableFunc *a, const TableFunc *b)
{ {
COMPARE_NODE_FIELD(ns_names);
COMPARE_NODE_FIELD(ns_uris); COMPARE_NODE_FIELD(ns_uris);
COMPARE_NODE_FIELD(ns_names);
COMPARE_NODE_FIELD(docexpr); COMPARE_NODE_FIELD(docexpr);
COMPARE_NODE_FIELD(rowexpr); COMPARE_NODE_FIELD(rowexpr);
COMPARE_NODE_FIELD(colnames); COMPARE_NODE_FIELD(colnames);
COMPARE_NODE_FIELD(coltypes); COMPARE_NODE_FIELD(coltypes);
COMPARE_NODE_FIELD(coltypes); COMPARE_NODE_FIELD(coltypmods);
COMPARE_NODE_FIELD(colcollations); COMPARE_NODE_FIELD(colcollations);
COMPARE_NODE_FIELD(colexprs); COMPARE_NODE_FIELD(colexprs);
COMPARE_NODE_FIELD(coldefexprs); COMPARE_NODE_FIELD(coldefexprs);
...@@ -1231,8 +1231,8 @@ _equalCreateStmt(const CreateStmt *a, const CreateStmt *b) ...@@ -1231,8 +1231,8 @@ _equalCreateStmt(const CreateStmt *a, const CreateStmt *b)
COMPARE_NODE_FIELD(relation); COMPARE_NODE_FIELD(relation);
COMPARE_NODE_FIELD(tableElts); COMPARE_NODE_FIELD(tableElts);
COMPARE_NODE_FIELD(inhRelations); COMPARE_NODE_FIELD(inhRelations);
COMPARE_NODE_FIELD(partspec);
COMPARE_NODE_FIELD(partbound); COMPARE_NODE_FIELD(partbound);
COMPARE_NODE_FIELD(partspec);
COMPARE_NODE_FIELD(ofTypename); COMPARE_NODE_FIELD(ofTypename);
COMPARE_NODE_FIELD(constraints); COMPARE_NODE_FIELD(constraints);
COMPARE_NODE_FIELD(options); COMPARE_NODE_FIELD(options);
...@@ -1869,8 +1869,8 @@ _equalCreateForeignServerStmt(const CreateForeignServerStmt *a, const CreateFore ...@@ -1869,8 +1869,8 @@ _equalCreateForeignServerStmt(const CreateForeignServerStmt *a, const CreateFore
COMPARE_STRING_FIELD(servertype); COMPARE_STRING_FIELD(servertype);
COMPARE_STRING_FIELD(version); COMPARE_STRING_FIELD(version);
COMPARE_STRING_FIELD(fdwname); COMPARE_STRING_FIELD(fdwname);
COMPARE_NODE_FIELD(options);
COMPARE_SCALAR_FIELD(if_not_exists); COMPARE_SCALAR_FIELD(if_not_exists);
COMPARE_NODE_FIELD(options);
return true; return true;
} }
...@@ -1891,8 +1891,8 @@ _equalCreateUserMappingStmt(const CreateUserMappingStmt *a, const CreateUserMapp ...@@ -1891,8 +1891,8 @@ _equalCreateUserMappingStmt(const CreateUserMappingStmt *a, const CreateUserMapp
{ {
COMPARE_NODE_FIELD(user); COMPARE_NODE_FIELD(user);
COMPARE_STRING_FIELD(servername); COMPARE_STRING_FIELD(servername);
COMPARE_NODE_FIELD(options);
COMPARE_SCALAR_FIELD(if_not_exists); COMPARE_SCALAR_FIELD(if_not_exists);
COMPARE_NODE_FIELD(options);
return true; return true;
} }
...@@ -2507,7 +2507,6 @@ _equalRangeTableFuncCol(const RangeTableFuncCol *a, const RangeTableFuncCol *b) ...@@ -2507,7 +2507,6 @@ _equalRangeTableFuncCol(const RangeTableFuncCol *a, const RangeTableFuncCol *b)
COMPARE_STRING_FIELD(colname); COMPARE_STRING_FIELD(colname);
COMPARE_NODE_FIELD(typeName); COMPARE_NODE_FIELD(typeName);
COMPARE_SCALAR_FIELD(for_ordinality); COMPARE_SCALAR_FIELD(for_ordinality);
COMPARE_NODE_FIELD(typeName);
COMPARE_SCALAR_FIELD(is_not_null); COMPARE_SCALAR_FIELD(is_not_null);
COMPARE_NODE_FIELD(colexpr); COMPARE_NODE_FIELD(colexpr);
COMPARE_NODE_FIELD(coldefexpr); COMPARE_NODE_FIELD(coldefexpr);
...@@ -2605,7 +2604,6 @@ _equalLockingClause(const LockingClause *a, const LockingClause *b) ...@@ -2605,7 +2604,6 @@ _equalLockingClause(const LockingClause *a, const LockingClause *b)
COMPARE_NODE_FIELD(lockedRels); COMPARE_NODE_FIELD(lockedRels);
COMPARE_SCALAR_FIELD(strength); COMPARE_SCALAR_FIELD(strength);
COMPARE_SCALAR_FIELD(waitPolicy); COMPARE_SCALAR_FIELD(waitPolicy);
COMPARE_LOCATION_FIELD(location);
return true; return true;
} }
...@@ -2622,8 +2620,8 @@ _equalRangeTblEntry(const RangeTblEntry *a, const RangeTblEntry *b) ...@@ -2622,8 +2620,8 @@ _equalRangeTblEntry(const RangeTblEntry *a, const RangeTblEntry *b)
COMPARE_SCALAR_FIELD(jointype); COMPARE_SCALAR_FIELD(jointype);
COMPARE_NODE_FIELD(joinaliasvars); COMPARE_NODE_FIELD(joinaliasvars);
COMPARE_NODE_FIELD(functions); COMPARE_NODE_FIELD(functions);
COMPARE_NODE_FIELD(tablefunc);
COMPARE_SCALAR_FIELD(funcordinality); COMPARE_SCALAR_FIELD(funcordinality);
COMPARE_NODE_FIELD(tablefunc);
COMPARE_NODE_FIELD(values_lists); COMPARE_NODE_FIELD(values_lists);
COMPARE_STRING_FIELD(ctename); COMPARE_STRING_FIELD(ctename);
COMPARE_SCALAR_FIELD(ctelevelsup); COMPARE_SCALAR_FIELD(ctelevelsup);
......
...@@ -1018,8 +1018,8 @@ _outTableFunc(StringInfo str, const TableFunc *node) ...@@ -1018,8 +1018,8 @@ _outTableFunc(StringInfo str, const TableFunc *node)
{ {
WRITE_NODE_TYPE("TABLEFUNC"); WRITE_NODE_TYPE("TABLEFUNC");
WRITE_NODE_FIELD(ns_names);
WRITE_NODE_FIELD(ns_uris); WRITE_NODE_FIELD(ns_uris);
WRITE_NODE_FIELD(ns_names);
WRITE_NODE_FIELD(docexpr); WRITE_NODE_FIELD(docexpr);
WRITE_NODE_FIELD(rowexpr); WRITE_NODE_FIELD(rowexpr);
WRITE_NODE_FIELD(colnames); WRITE_NODE_FIELD(colnames);
......
...@@ -467,8 +467,8 @@ _readTableFunc(void) ...@@ -467,8 +467,8 @@ _readTableFunc(void)
{ {
READ_LOCALS(TableFunc); READ_LOCALS(TableFunc);
READ_NODE_FIELD(ns_names);
READ_NODE_FIELD(ns_uris); READ_NODE_FIELD(ns_uris);
READ_NODE_FIELD(ns_names);
READ_NODE_FIELD(docexpr); READ_NODE_FIELD(docexpr);
READ_NODE_FIELD(rowexpr); READ_NODE_FIELD(rowexpr);
READ_NODE_FIELD(colnames); READ_NODE_FIELD(colnames);
......
...@@ -53,6 +53,6 @@ ...@@ -53,6 +53,6 @@
*/ */
/* yyyymmddN */ /* yyyymmddN */
#define CATALOG_VERSION_NO 201706141 #define CATALOG_VERSION_NO 201706161
#endif #endif
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment