Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
31d250e0
Commit
31d250e0
authored
Jun 08, 2019
by
Noah Misch
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update stale comments, and fix comment typos.
parent
92c4abc7
Changes
13
Hide whitespace changes
Inline
Side-by-side
Showing
13 changed files
with
20 additions
and
33 deletions
+20
-33
src/backend/access/brin/brin_inclusion.c
src/backend/access/brin/brin_inclusion.c
+1
-1
src/backend/access/transam/multixact.c
src/backend/access/transam/multixact.c
+1
-1
src/backend/port/sysv_shmem.c
src/backend/port/sysv_shmem.c
+3
-3
src/backend/postmaster/postmaster.c
src/backend/postmaster/postmaster.c
+2
-2
src/backend/utils/adt/like.c
src/backend/utils/adt/like.c
+0
-1
src/bin/pg_basebackup/pg_basebackup.c
src/bin/pg_basebackup/pg_basebackup.c
+1
-6
src/bin/pg_rewind/t/RewindTest.pm
src/bin/pg_rewind/t/RewindTest.pm
+1
-5
src/bin/pg_upgrade/TESTING
src/bin/pg_upgrade/TESTING
+1
-1
src/bin/pg_upgrade/controldata.c
src/bin/pg_upgrade/controldata.c
+1
-1
src/fe_utils/string_utils.c
src/fe_utils/string_utils.c
+1
-2
src/include/storage/s_lock.h
src/include/storage/s_lock.h
+1
-2
src/interfaces/libpq/fe-secure-openssl.c
src/interfaces/libpq/fe-secure-openssl.c
+1
-1
src/test/recovery/t/013_crash_restart.pl
src/test/recovery/t/013_crash_restart.pl
+6
-7
No files found.
src/backend/access/brin/brin_inclusion.c
View file @
31d250e0
...
...
@@ -432,7 +432,7 @@ brin_inclusion_consistent(PG_FUNCTION_ARGS)
* It is straightforward to support the equality strategies with
* the contains operator. Generally, inequality strategies do not
* make much sense for the types which will be used with the
* inclusion BRIN family of opclasses, but is possible to
* inclusion BRIN family of opclasses, but i
t i
s possible to
* implement them with logical negation of the left-of and
* right-of operators.
*
...
...
src/backend/access/transam/multixact.c
View file @
31d250e0
...
...
@@ -2208,7 +2208,7 @@ SetMultiXactIdLimit(MultiXactId oldest_datminmxid, Oid oldest_datoid,
* space, but that's not really true, because multixacts wrap differently
* from transaction IDs. Note that, separately from any concern about
* multixact IDs wrapping, we must ensure that multixact members do not
* wrap. Limits for that are set in
DetermineSafeOldestOffse
t, not here.
* wrap. Limits for that are set in
SetOffsetVacuumLimi
t, not here.
*/
multiWrapLimit
=
oldest_datminmxid
+
(
MaxMultiXactId
>>
1
);
if
(
multiWrapLimit
<
FirstMultiXactId
)
...
...
src/backend/port/sysv_shmem.c
View file @
31d250e0
...
...
@@ -390,9 +390,9 @@ PGSharedMemoryAttach(IpcMemoryId shmId,
/*
* Try to attach to the segment and see if it matches our data directory.
* This avoids
shmid-conflict problems on machines that are running
*
several postmasters under the same userid and port number. (That would
*
not
ordinarily happen in production, but it can happen during parallel
* This avoids
key-conflict problems on machines that are running several
*
postmasters under the same userid and port number. (That would not
* ordinarily happen in production, but it can happen during parallel
* testing. Since our test setups don't open any TCP ports on Unix, such
* cases don't conflict otherwise.)
*/
...
...
src/backend/postmaster/postmaster.c
View file @
31d250e0
...
...
@@ -4743,8 +4743,8 @@ retry:
}
/*
* Queue a waiter
for to signal when this child dies. The wait will be
*
handled
automatically by an operating system thread pool.
* Queue a waiter
to signal when this child dies. The wait will be handled
* automatically by an operating system thread pool.
*
* Note: use malloc instead of palloc, since it needs to be thread-safe.
* Struct will be free():d from the callback function that runs on a
...
...
src/backend/utils/adt/like.c
View file @
31d250e0
...
...
@@ -211,7 +211,6 @@ Generic_Text_IC_like(text *str, text *pat, Oid collation)
if
(
pg_database_encoding_max_length
()
>
1
||
(
locale
&&
locale
->
provider
==
COLLPROVIDER_ICU
))
{
/* lower's result is never packed, so OK to use old macros here */
pat
=
DatumGetTextPP
(
DirectFunctionCall1Coll
(
lower
,
collation
,
PointerGetDatum
(
pat
)));
p
=
VARDATA_ANY
(
pat
);
...
...
src/bin/pg_basebackup/pg_basebackup.c
View file @
31d250e0
...
...
@@ -1681,12 +1681,7 @@ GenerateRecoveryConf(PGconn *conn)
initPQExpBuffer
(
&
conninfo_buf
);
for
(
option
=
connOptions
;
option
&&
option
->
keyword
;
option
++
)
{
/*
* Do not emit this setting if: - the setting is "replication",
* "dbname" or "fallback_application_name", since these would be
* overridden by the libpqwalreceiver module anyway. - not set or
* empty.
*/
/* Omit empty settings and those libpqwalreceiver overrides. */
if
(
strcmp
(
option
->
keyword
,
"replication"
)
==
0
||
strcmp
(
option
->
keyword
,
"dbname"
)
==
0
||
strcmp
(
option
->
keyword
,
"fallback_application_name"
)
==
0
||
...
...
src/bin/pg_rewind/t/RewindTest.pm
View file @
31d250e0
...
...
@@ -26,11 +26,7 @@ package RewindTest;
# still running.
#
# The test script can use the helper functions master_psql and standby_psql
# to run psql against the master and standby servers, respectively. The
# test script can also use the $connstr_master and $connstr_standby global
# variables, which contain libpq connection strings for connecting to the
# master and standby servers. The data directories are also available
# in paths $test_master_datadir and $test_standby_datadir
# to run psql against the master and standby servers, respectively.
use
strict
;
use
warnings
;
...
...
src/bin/pg_upgrade/TESTING
View file @
31d250e0
...
...
@@ -36,7 +36,7 @@ Here are the steps needed to create a regression database dump file:
1) Create and populate the regression database in the old cluster.
This database can be created by running 'make installcheck' from
src/test/regress
ion
.
src/test/regress.
2) Use pg_dump to dump out the regression database. Use the new
cluster's pg_dump on the old database to minimize whitespace
...
...
src/bin/pg_upgrade/controldata.c
View file @
31d250e0
...
...
@@ -105,7 +105,7 @@ get_control_data(ClusterInfo *cluster, bool live_check)
#ifndef WIN32
pg_putenv
(
"LANG"
,
NULL
);
#else
/* On Windows the default locale
can
not be English, so force it */
/* On Windows the default locale
may
not be English, so force it */
pg_putenv
(
"LANG"
,
"en"
);
#endif
pg_putenv
(
"LANGUAGE"
,
NULL
);
...
...
src/fe_utils/string_utils.c
View file @
31d250e0
...
...
@@ -541,8 +541,7 @@ appendShellStringNoError(PQExpBuffer buf, const char *str)
/*
* Append the given string to the buffer, with suitable quoting for passing
* the string as a value, in a keyword/pair value in a libpq connection
* string
* the string as a value in a keyword/value pair in a libpq connection string.
*/
void
appendConnStrVal
(
PQExpBuffer
buf
,
const
char
*
str
)
...
...
src/include/storage/s_lock.h
View file @
31d250e0
...
...
@@ -383,7 +383,7 @@ tas(volatile slock_t *lock)
register
slock_t
_res
;
/*
* See comment in
/pg/backend/port/tas/solaris
_sparc.s for why this
* See comment in
src/backend/port/tas/sunstudio
_sparc.s for why this
* uses "ldstub", and that file uses "cas". gcc currently generates
* sparcv7-targeted binaries, so "cas" use isn't possible.
*/
...
...
@@ -598,7 +598,6 @@ tas(volatile slock_t *lock)
#if defined(__mips__) && !defined(__sgi)
/* non-SGI MIPS */
/* Note: on SGI we use the OS' mutex ABI, see below */
/* Note: R10000 processors require a separate SYNC */
#define HAS_TEST_AND_SET
...
...
src/interfaces/libpq/fe-secure-openssl.c
View file @
31d250e0
...
...
@@ -736,7 +736,7 @@ static void
destroy_ssl_system
(
void
)
{
#if defined(ENABLE_THREAD_SAFETY) && defined(HAVE_CRYPTO_LOCK)
/* Mutex is created in
initialize_ssl_system
() */
/* Mutex is created in
pgtls_init
() */
if
(
pthread_mutex_lock
(
&
ssl_config_mutex
))
return
;
...
...
src/test/recovery/t/013_crash_restart.pl
View file @
31d250e0
...
...
@@ -90,9 +90,9 @@ $killme_stdout = '';
$killme_stderr
=
'';
# Start longrunning query in second session
, it's failure will signal
#
that crash-restart has occurred. The initial wait for the trivial
#
select is to
be sure that psql successfully connected to backend.
# Start longrunning query in second session
; its failure will signal that
#
crash-restart has occurred. The initial wait for the trivial select is to
# be sure that psql successfully connected to backend.
$monitor_stdin
.=
q[
SELECT $$psql-connected$$;
SELECT pg_sleep(3600);
...
...
@@ -171,10 +171,9 @@ ok(pump_until($killme, \$killme_stdout, qr/in-progress-before-sigkill/m),
$killme_stdout
=
'';
$killme_stderr
=
'';
# Re-start longrunning query in second session, it's failure will
# signal that crash-restart has occurred. The initial wait for the
# trivial select is to be sure that psql successfully connected to
# backend.
# Re-start longrunning query in second session; its failure will signal that
# crash-restart has occurred. The initial wait for the trivial select is to
# be sure that psql successfully connected to backend.
$monitor_stdin
.=
q[
SELECT $$psql-connected$$;
SELECT pg_sleep(3600);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment