Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
2e54d88a
Commit
2e54d88a
authored
May 06, 2014
by
Simon Riggs
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Correct comment in Hot Standby nbtree handling
Logic is correct, matching handling of LP_DEAD elsewhere.
parent
284c464b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
5 deletions
+5
-5
src/backend/access/nbtree/nbtxlog.c
src/backend/access/nbtree/nbtxlog.c
+5
-5
No files found.
src/backend/access/nbtree/nbtxlog.c
View file @
2e54d88a
...
@@ -714,11 +714,11 @@ btree_xlog_delete_get_latestRemovedXid(xl_btree_delete *xlrec)
...
@@ -714,11 +714,11 @@ btree_xlog_delete_get_latestRemovedXid(xl_btree_delete *xlrec)
UnlockReleaseBuffer
(
ibuffer
);
UnlockReleaseBuffer
(
ibuffer
);
/*
/*
*
XXX
If all heap tuples were LP_DEAD then we will be returning
* If all heap tuples were LP_DEAD then we will be returning
* InvalidTransactionId here,
causing conflict for all HS transactions.
* InvalidTransactionId here,
which avoids conflicts. This matches
*
That should happen very rarely (reasoning please?). Also note that
*
existing logic which assumes that LP_DEAD tuples must already be
*
caller can't tell the difference between this case and the fast path
*
older than the latestRemovedXid on the cleanup record that
*
exit above. May need to change that in future
.
*
set them as LP_DEAD, hence must already have generated a conflict
.
*/
*/
return
latestRemovedXid
;
return
latestRemovedXid
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment