Final optimizer cleanups.

src/backend/nodes/list.c

@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/nodes/list.c,v 1.17 1999/02/13 23:15:57 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/nodes/list.c,v 1.18 1999/02/22 05:26:18 momjian Exp $
  *
  * NOTES
  *	  XXX a few of the following functions are duplicated to handle
@@ -109,6 +109,7 @@ nconc(List *l1, List *l2)
 }
 
 
+#ifdef NOT_USED
 List *
 nreverse(List *list)
 {
@@ -128,6 +129,7 @@ nreverse(List *list)
 	lnext(list) = lnext(rlist);
 	return list;
 }
+#endif
 
 Value *
 makeInteger(long i)
@@ -245,6 +247,7 @@ append(List *l1, List *l2)
 	return newlist;
 }
 
+#ifdef NOT_USED
 /*
  * below are for backwards compatibility
  */
@@ -266,6 +269,7 @@ intAppend(List *l1, List *l2)
 	lnext(p) = newlist2;
 	return newlist;
 }
+#endif
 
 /*
  *		same

src/backend/optimizer/path/allpaths.c

@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/allpaths.c,v 1.43 1999/02/21 03:48:41 scrappy Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/allpaths.c,v 1.44 1999/02/22 05:26:18 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -126,7 +126,7 @@ set_base_rel_pathlist(Query *root, List *rels)
 
 		rel->pathlist = add_pathlist(rel,
 									 sequential_scan_list,
-									 append(rel_index_scan_list,
+									 nconc(rel_index_scan_list,
 											or_index_scan_list));
 
 		set_cheapest(rel, rel->pathlist);

src/backend/optimizer/path/hashutils.c

@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/Attic/hashutils.c,v 1.13 1999/02/13 23:16:16 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/Attic/hashutils.c,v 1.14 1999/02/22 05:26:18 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -83,9 +83,7 @@ group_clauses_by_hashop(List *restrictinfo_list,
 				xhashinfo->jmethod.jmkeys = NIL;
 				xhashinfo->jmethod.clauses = NIL;
 
-				/* XXX was push  */
-				hashinfo_list = lappend(hashinfo_list, xhashinfo);
-				hashinfo_list = nreverse(hashinfo_list);
+				hashinfo_list = lcons(xhashinfo, hashinfo_list);
 			}
 
 			xhashinfo->jmethod.clauses = lcons(clause, xhashinfo->jmethod.clauses);

src/backend/optimizer/path/indxpath.c

@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.52 1999/02/21 03:48:44 scrappy Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.53 1999/02/22 05:26:19 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1384,7 +1384,7 @@ create_index_path_group(Query *root,
 static List *
 add_index_paths(List *indexpaths, List *new_indexpaths)
 {
-	return append(indexpaths, new_indexpaths);
+	return nconc(indexpaths, new_indexpaths);
 }
 
 static bool

src/backend/optimizer/path/joinpath.c

@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/joinpath.c,v 1.31 1999/02/21 01:55:02 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/joinpath.c,v 1.32 1999/02/22 05:26:20 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -104,7 +104,8 @@ update_rels_pathlist_for_joins(Query *root, List *joinrels)
 										lfirsti(innerrel->relids));
 
 		/* need to flatten the relids list */
-		joinrel->relids = intAppend(outerrelids, innerrelids);
+		joinrel->relids = nconc(listCopy(outerrelids),
+								listCopy(innerrelids));
 
 		/*
 		 * 1. Consider mergejoin paths where both relations must be
@@ -213,11 +214,11 @@ sort_inner_and_outer(RelOptInfo *joinrel,
 	{
 		xmergeinfo = (MergeInfo *) lfirst(i);
 
-		outerkeys = extract_path_keys(xmergeinfo->jmethod.jmkeys,
+		outerkeys = make_pathkeys_from_joinkeys(xmergeinfo->jmethod.jmkeys,
 							  outerrel->targetlist,
 							  OUTER);
 
-		innerkeys = extract_path_keys(xmergeinfo->jmethod.jmkeys,
+		innerkeys = make_pathkeys_from_joinkeys(xmergeinfo->jmethod.jmkeys,
 							  innerrel->targetlist,
 							  INNER);
 
@@ -352,7 +353,7 @@ match_unsorted_outer(RelOptInfo *joinrel,
 							innerrel->width, false))));
 			if (!path_is_cheaper_than_sort)
 			{
-				varkeys = extract_path_keys(matchedJoinKeys,
+				varkeys = make_pathkeys_from_joinkeys(matchedJoinKeys,
 									  innerrel->targetlist,
 									  INNER);
 			}
@@ -473,7 +474,7 @@ match_unsorted_inner(RelOptInfo *joinrel,
 
 			if (temp2)
 			{
-				List	   *outerkeys = extract_path_keys(matchedJoinKeys,
+				List	   *outerkeys = make_pathkeys_from_joinkeys(matchedJoinKeys,
 								  outerrel->targetlist,
 								  OUTER);
 				List	   *merge_pathkeys = new_join_pathkeys(outerkeys,
@@ -551,10 +552,12 @@ hash_inner_and_outer(RelOptInfo *joinrel,
 	foreach(i, hashinfo_list)
 	{
 		xhashinfo = (HashInfo *) lfirst(i);
-		outerkeys = extract_path_keys(((JoinMethod *) xhashinfo)->jmkeys,
+		outerkeys = make_pathkeys_from_joinkeys(
+							  ((JoinMethod *) xhashinfo)->jmkeys,
 							  outerrel->targetlist,
 							  OUTER);
-		innerkeys = extract_path_keys(((JoinMethod *) xhashinfo)->jmkeys,
+		innerkeys = make_pathkeys_from_joinkeys(
+							  ((JoinMethod *) xhashinfo)->jmkeys,
 							  innerrel->targetlist,
 							  INNER);
 		hash_pathkeys = new_join_pathkeys(outerkeys,

src/backend/optimizer/path/joinrels.c

@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/joinrels.c,v 1.30 1999/02/18 06:00:46 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/path/joinrels.c,v 1.31 1999/02/22 05:26:20 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -62,7 +62,7 @@ make_rels_by_joins(Query *root, List *old_rels)
 			joined_rels = make_rels_by_clauseless_joins(old_rel,
 														root->base_rel_list);
 			joined_rels = append(joined_rels,
-								 make_rels_by_clauseless_joins(old_rel,
+								make_rels_by_clauseless_joins(old_rel,
 															   old_rels));
 		}
 
@@ -235,9 +235,11 @@ make_join_rel(RelOptInfo *outer_rel, RelOptInfo *inner_rel, JoinInfo *joininfo)
 	if (joininfo)
 		joinrel->restrictinfo = joininfo->jinfo_restrictinfo;
 
-	joinrel_joininfo_list = new_joininfo_list(append(outer_rel->joininfo,
-													 inner_rel->joininfo),
-						intAppend(outer_rel->relids, inner_rel->relids));
+	joinrel_joininfo_list = new_joininfo_list(
+										append(outer_rel->joininfo,
+											   inner_rel->joininfo),
+										nconc(listCopy(outer_rel->relids),
+								  			   listCopy(inner_rel->relids)));
 
 	joinrel->joininfo = joinrel_joininfo_list;
 

src/backend/optimizer/plan/initsplan.c

@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/plan/initsplan.c,v 1.28 1999/02/18 00:49:26 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/plan/initsplan.c,v 1.29 1999/02/22 05:26:21 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -72,7 +72,7 @@ make_var_only_tlist(Query *root, List *tlist)
 	{
 		TargetEntry *entry = (TargetEntry *) lfirst(l);
 
-		tlist_vars = append(tlist_vars, pull_var_clause(entry->expr));
+		tlist_vars = nconc(tlist_vars, pull_var_clause(entry->expr));
 	}
 
 	/* now, the target list only contains Var nodes */

src/backend/optimizer/util/joininfo.c

@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/joininfo.c,v 1.18 1999/02/18 00:49:37 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/joininfo.c,v 1.19 1999/02/22 05:26:26 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -101,9 +101,9 @@ other_join_clause_var(Var *var, Expr *clause)
 		l = (Var *) get_leftop(clause);
 		r = (Var *) get_rightop(clause);
 
-		if (var_equal(var, l))
+		if (equal(var, l))
 			retval = r;
-		else if (var_equal(var, r))
+		else if (equal(var, r))
 			retval = l;
 	}
 

src/backend/optimizer/util/var.c

@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/var.c,v 1.16 1999/02/13 23:16:50 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/var.c,v 1.17 1999/02/22 05:26:27 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -235,6 +235,9 @@ pull_var_clause(Node *clause)
 /*
  *		var_equal
  *
+ *		The only difference between this an equal() is that this does not
+ *		test varnoold and varoattno.
+ *
  *		Returns t iff two var nodes correspond to the same attribute.
  */
 bool

src/backend/parser/gram.c

@@ -242,7 +242,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/Attic/gram.c,v 2.73 1999/02/14 05:14:09 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/Attic/gram.c,v 2.74 1999/02/22 05:26:33 momjian Exp $
  *
  * HISTORY
  *	  AUTHOR			DATE			MAJOR EVENT
@@ -11574,7 +11574,7 @@ makeRowExpr(char *opr, List *largs, List *rargs)
 		elog(ERROR,"Operator '%s' not implemented for row expressions",opr);
 	}
 
-#if FALSE
+#ifdef NOT_USED
 	while ((largs != NIL) && (rargs != NIL))
 	{
 		larg = lfirst(largs);

src/backend/rewrite/rewriteHandler.c

@@ -6,7 +6,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteHandler.c,v 1.36 1999/02/21 03:49:18 scrappy Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteHandler.c,v 1.37 1999/02/22 05:26:46 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -97,7 +97,7 @@ gatherRewriteMeta(Query *parsetree,
 		info->current_varno = rt_index;
 		info->rt = parsetree->rtable;
 		rt_length = length(info->rt);
-		info->rt = append(info->rt, info->rule_action->rtable);
+		info->rt = nconc(info->rt, copyObject(info->rule_action->rtable));
 
 		info->new_varno = PRS2_NEW_VARNO + rt_length;
 		OffsetVarNodes(info->rule_action->qual, rt_length, 0);
@@ -2206,7 +2206,7 @@ CopyAndAddQual(Query *parsetree,
 
 		rtable = new_tree->rtable;
 		rt_length = length(rtable);
-		rtable = append(rtable, listCopy(rule_action->rtable));
+		rtable = nconc(rtable, copyObject(rule_action->rtable));
 		new_tree->rtable = rtable;
 		OffsetVarNodes(new_qual, rt_length, 0);
 		ChangeVarNodes(new_qual, PRS2_CURRENT_VARNO + rt_length, rt_index, 0);

src/include/nodes/pg_list.h

@@ -6,7 +6,7 @@
  *
  * Copyright (c) 1994, Regents of the University of California
  *
- * $Id: pg_list.h,v 1.10 1999/02/13 23:21:39 momjian Exp $
+ * $Id: pg_list.h,v 1.11 1999/02/22 05:26:47 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -82,7 +82,6 @@ typedef struct List
  * function prototypes in nodes/list.c
  */
 extern int	length(List *list);
-extern List *append(List *list1, List *list2);
 extern List *nconc(List *list1, List *list2);
 extern List *lcons(void *datum, List *list);
 extern bool member(void *foo, List *bar);
@@ -101,11 +100,9 @@ extern void set_nth(List *l, int n, void *elem);
 List	   *lconsi(int datum, List *list);
 List	   *lappendi(List *list, int datum);
 extern bool intMember(int, List *);
-extern List *intAppend(List *list1, List *list2);
 
 extern int	nthi(int n, List *l);
 
-extern List *nreverse(List *);
 extern List *set_difference(List *, List *);
 extern List *set_differencei(List *, List *);
 extern List *LispUnion(List *foo, List *bar);

src/include/optimizer/paths.h

@@ -7,7 +7,7 @@
  *
  * Copyright (c) 1994, Regents of the University of California
  *
- * $Id: paths.h,v 1.25 1999/02/21 01:55:03 momjian Exp $
+ * $Id: paths.h,v 1.26 1999/02/22 05:26:52 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -58,8 +58,8 @@ extern bool order_joinkeys_by_pathkeys(List *pathkeys,
 					 List *joinkeys, List *joinclauses, int outer_or_inner,
 					 List **matchedJoinKeysPtr,
 					 List **matchedJoinClausesPtr);
-extern List *extract_path_keys(List *joinkeys, List *tlist,
-				  int outer_or_inner);
+extern List *make_pathkeys_from_joinkeys(List *joinkeys, List *tlist,
+										  int outer_or_inner);
 extern Path *get_cheapest_path_for_joinkeys(List *joinkeys,
 					PathOrder *ordering, List *paths, int outer_or_inner);
 extern List *new_join_pathkeys(List *outer_pathkeys,

src/interfaces/libpq/fe-misc.c

@@ -24,7 +24,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.22 1998/09/20 04:51:12 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.23 1999/02/22 05:26:53 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -438,8 +438,8 @@ tryAgain2:
 definitelyFailed:
 	sprintf(conn->errorMessage,
 			"pqReadData() -- backend closed the channel unexpectedly.\n"
-			"\tThis probably means the backend terminated abnormally"
-			" before or while processing the request.\n");
+			"\tThis probably means the backend terminated abnormally\n"
+			"\tbefore or while processing the request.\n");
 	conn->status = CONNECTION_BAD;		/* No more connection to backend */
 #ifdef WIN32
 	closesocket(conn->sock);

src/man/postmaster.1

 .\" This is -*-nroff-*-
 .\" XXX standard disclaimer belongs here....
-.\" $Header: /cvsroot/pgsql/src/man/Attic/postmaster.1,v 1.14 1999/02/21 03:17:31 tgl Exp $
+.\" $Header: /cvsroot/pgsql/src/man/Attic/postmaster.1,v 1.15 1999/02/22 05:26:58 momjian Exp $
 .TH POSTMASTER UNIX 02/20/99 PostgreSQL PostgreSQL
 .SH "NAME"
 postmaster - run the Postgres postmaster
@@ -13,17 +13,17 @@ n_buffers]
 .BR "-D"
 data_dir]
 [\c
+.BR "-N"
+n_backends]
+.br
+.in +5n
+[\c
 .BR "-S" \c
 ]
 [\c
 .BR "-a"
 system]
 [\c
-.BR "-N"
-n_backends]
-.br
-.in +5n
-[\c
 .BR "-b"
 backend_pathname]
 [\c
@@ -35,7 +35,6 @@ backend_pathname]
 [\c
 .BR "-n" \c
 ]
-.br
 [\c
 .BR "-o"
 backend_options]
@@ -81,6 +80,14 @@ is not set, then the directory used is
 option is not specified, the default directory that was
 set at compile-time is used.
 .TP
+.BR "-N" " n_backends"
+.IR "n_backends"
+is the maximum number of backend server processes that this postmaster
+is allowed to start.  In the stock configuration, this value defaults
+to 64, and can be set as high as 1024 if your system will support that
+many processes. Both the default and upper limit values can be altered
+when building Postgres.
+.TP
 .BR "-S"
 Specifies that the
 .IR "postmaster"
@@ -108,14 +115,6 @@ connections, use
 .BR "-a nounauth .
 This option no longer has any effect.
 .TP
-.BR "-N" " n_backends"
-.IR "n_backends"
-is the maximum number of backend server processes that this postmaster
-is allowed to start.  In the stock configuration, this value defaults
-to 64, and can be set as high as 1024 if your system will support that
-many processes. Both the default and upper limit values can be altered
-when building Postgres.
-.TP
 .BR "-b" " backend_pathname"
 .IR "backend_pathname"
 is the full pathname of the Postgres backend server executable file that