Commit 162bd08b authored by Tom Lane's avatar Tom Lane

Completion of project to use fixed OIDs for all system catalogs and

indexes.  Replace all heap_openr and index_openr calls by heap_open
and index_open.  Remove runtime lookups of catalog OID numbers in
various places.  Remove relcache's support for looking up system
catalogs by name.  Bulky but mostly very boring patch ...
parent 9dc2e6de
...@@ -36,7 +36,6 @@ ...@@ -36,7 +36,6 @@
#include "funcapi.h" #include "funcapi.h"
#include "access/tupdesc.h" #include "access/tupdesc.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_index.h" #include "catalog/pg_index.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
...@@ -1538,7 +1537,7 @@ get_pkey_attnames(Oid relid, int16 *numatts) ...@@ -1538,7 +1537,7 @@ get_pkey_attnames(Oid relid, int16 *numatts)
*numatts = 0; *numatts = 0;
/* use relid to get all related indexes */ /* use relid to get all related indexes */
indexRelation = heap_openr(IndexRelationName, AccessShareLock); indexRelation = heap_open(IndexRelationId, AccessShareLock);
ScanKeyInit(&entry, ScanKeyInit(&entry,
Anum_pg_index_indrelid, Anum_pg_index_indrelid,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
......
...@@ -18,7 +18,6 @@ ...@@ -18,7 +18,6 @@
#include <sys/types.h> #include <sys/types.h>
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
......
...@@ -19,7 +19,6 @@ ...@@ -19,7 +19,6 @@
#include "access/relscan.h" #include "access/relscan.h"
#include "access/skey.h" #include "access/skey.h"
#include "access/tupdesc.h" #include "access/tupdesc.h"
#include "catalog/catname.h"
#include "catalog/pg_listener.h" #include "catalog/pg_listener.h"
#include "commands/async.h" #include "commands/async.h"
#include "fmgr.h" #include "fmgr.h"
...@@ -75,7 +74,7 @@ active_listeners(text *relname) ...@@ -75,7 +74,7 @@ active_listeners(text *relname)
int ourpid = getpid(); int ourpid = getpid();
char listen_name[NAMEDATALEN]; char listen_name[NAMEDATALEN];
lRel = heap_openr(ListenerRelationName, AccessShareLock); lRel = heap_open(ListenerRelationId, AccessShareLock);
tdesc = RelationGetDescr(lRel); tdesc = RelationGetDescr(lRel);
if (relname && (VARSIZE(relname) > VARHDRSZ)) if (relname && (VARSIZE(relname) > VARHDRSZ))
......
...@@ -8,17 +8,15 @@ ...@@ -8,17 +8,15 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.186 2005/03/28 01:50:32 tgl Exp $ * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.187 2005/04/14 20:03:22 tgl Exp $
* *
* *
* INTERFACE ROUTINES * INTERFACE ROUTINES
* relation_open - open any relation by relation OID * relation_open - open any relation by relation OID
* relation_openrv - open any relation specified by a RangeVar * relation_openrv - open any relation specified by a RangeVar
* relation_openr - open a system relation by name
* relation_close - close any relation * relation_close - close any relation
* heap_open - open a heap relation by relation OID * heap_open - open a heap relation by relation OID
* heap_openrv - open a heap relation specified by a RangeVar * heap_openrv - open a heap relation specified by a RangeVar
* heap_openr - open a system heap relation by name
* heap_close - (now just a macro for relation_close) * heap_close - (now just a macro for relation_close)
* heap_beginscan - begin relation scan * heap_beginscan - begin relation scan
* heap_rescan - restart a relation scan * heap_rescan - restart a relation scan
...@@ -502,15 +500,6 @@ relation_openrv(const RangeVar *relation, LOCKMODE lockmode) ...@@ -502,15 +500,6 @@ relation_openrv(const RangeVar *relation, LOCKMODE lockmode)
{ {
Oid relOid; Oid relOid;
/*
* In bootstrap mode, don't do any namespace processing.
*/
if (IsBootstrapProcessingMode())
{
Assert(relation->schemaname == NULL);
return relation_openr(relation->relname, lockmode);
}
/* /*
* Check for shared-cache-inval messages before trying to open the * Check for shared-cache-inval messages before trying to open the
* relation. This is needed to cover the case where the name * relation. This is needed to cover the case where the name
...@@ -533,37 +522,6 @@ relation_openrv(const RangeVar *relation, LOCKMODE lockmode) ...@@ -533,37 +522,6 @@ relation_openrv(const RangeVar *relation, LOCKMODE lockmode)
return relation_open(relOid, lockmode); return relation_open(relOid, lockmode);
} }
/* ----------------
* relation_openr - open a system relation specified by name.
*
* As above, but the relation is specified by an unqualified name;
* it is assumed to live in the system catalog namespace.
* ----------------
*/
Relation
relation_openr(const char *sysRelationName, LOCKMODE lockmode)
{
Relation r;
Assert(lockmode >= NoLock && lockmode < MAX_LOCKMODES);
/*
* We assume we should not need to worry about the rel's OID changing,
* hence no need for AcceptInvalidationMessages here.
*/
/* The relcache does all the real work... */
r = RelationSysNameGetRelation(sysRelationName);
if (!RelationIsValid(r))
elog(ERROR, "could not open relation \"%s\"", sysRelationName);
if (lockmode != NoLock)
LockRelation(r, lockmode);
return r;
}
/* ---------------- /* ----------------
* relation_close - close any relation * relation_close - close any relation
* *
...@@ -657,41 +615,6 @@ heap_openrv(const RangeVar *relation, LOCKMODE lockmode) ...@@ -657,41 +615,6 @@ heap_openrv(const RangeVar *relation, LOCKMODE lockmode)
return r; return r;
} }
/* ----------------
* heap_openr - open a system heap relation specified by name.
*
* As above, but the relation is specified by an unqualified name;
* it is assumed to live in the system catalog namespace.
* ----------------
*/
Relation
heap_openr(const char *sysRelationName, LOCKMODE lockmode)
{
Relation r;
r = relation_openr(sysRelationName, lockmode);
if (r->rd_rel->relkind == RELKIND_INDEX)
ereport(ERROR,
(errcode(ERRCODE_WRONG_OBJECT_TYPE),
errmsg("\"%s\" is an index",
RelationGetRelationName(r))));
else if (r->rd_rel->relkind == RELKIND_SPECIAL)
ereport(ERROR,
(errcode(ERRCODE_WRONG_OBJECT_TYPE),
errmsg("\"%s\" is a special relation",
RelationGetRelationName(r))));
else if (r->rd_rel->relkind == RELKIND_COMPOSITE_TYPE)
ereport(ERROR,
(errcode(ERRCODE_WRONG_OBJECT_TYPE),
errmsg("\"%s\" is a composite type",
RelationGetRelationName(r))));
pgstat_initstats(&r->pgstat_info, r);
return r;
}
/* ---------------- /* ----------------
* heap_beginscan - begin relation scan * heap_beginscan - begin relation scan
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/access/index/genam.c,v 1.46 2005/03/29 00:16:51 tgl Exp $ * $PostgreSQL: pgsql/src/backend/access/index/genam.c,v 1.47 2005/04/14 20:03:23 tgl Exp $
* *
* NOTES * NOTES
* many of the old access method routines have been turned into * many of the old access method routines have been turned into
...@@ -162,7 +162,7 @@ IndexScanEnd(IndexScanDesc scan) ...@@ -162,7 +162,7 @@ IndexScanEnd(IndexScanDesc scan)
* systable_beginscan --- set up for heap-or-index scan * systable_beginscan --- set up for heap-or-index scan
* *
* rel: catalog to scan, already opened and suitably locked * rel: catalog to scan, already opened and suitably locked
* indexRelname: name of index to conditionally use * indexId: OID of index to conditionally use
* indexOK: if false, forces a heap scan (see notes below) * indexOK: if false, forces a heap scan (see notes below)
* snapshot: time qual to use (usually should be SnapshotNow) * snapshot: time qual to use (usually should be SnapshotNow)
* nkeys, key: scan keys * nkeys, key: scan keys
...@@ -179,7 +179,7 @@ IndexScanEnd(IndexScanDesc scan) ...@@ -179,7 +179,7 @@ IndexScanEnd(IndexScanDesc scan)
*/ */
SysScanDesc SysScanDesc
systable_beginscan(Relation heapRelation, systable_beginscan(Relation heapRelation,
const char *indexRelname, Oid indexId,
bool indexOK, bool indexOK,
Snapshot snapshot, Snapshot snapshot,
int nkeys, ScanKey key) int nkeys, ScanKey key)
...@@ -187,18 +187,10 @@ systable_beginscan(Relation heapRelation, ...@@ -187,18 +187,10 @@ systable_beginscan(Relation heapRelation,
SysScanDesc sysscan; SysScanDesc sysscan;
Relation irel; Relation irel;
if (indexOK && !IsIgnoringSystemIndexes()) if (indexOK &&
{ !IsIgnoringSystemIndexes() &&
/* We assume it's a system index, so index_openr is OK */ !ReindexIsProcessingIndex(indexId))
irel = index_openr(indexRelname); irel = index_open(indexId);
if (ReindexIsProcessingIndex(RelationGetRelid(irel)))
{
/* oops, can't use index that's being rebuilt */
index_close(irel);
irel = NULL;
}
}
else else
irel = NULL; irel = NULL;
......
...@@ -8,12 +8,11 @@ ...@@ -8,12 +8,11 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/access/index/indexam.c,v 1.79 2005/03/27 23:52:59 tgl Exp $ * $PostgreSQL: pgsql/src/backend/access/index/indexam.c,v 1.80 2005/04/14 20:03:23 tgl Exp $
* *
* INTERFACE ROUTINES * INTERFACE ROUTINES
* index_open - open an index relation by relation OID * index_open - open an index relation by relation OID
* index_openrv - open an index relation specified by a RangeVar * index_openrv - open an index relation specified by a RangeVar
* index_openr - open a system index relation by name
* index_close - close an index relation * index_close - close an index relation
* index_beginscan - start a scan of an index with amgettuple * index_beginscan - start a scan of an index with amgettuple
* index_beginscan_multi - start a scan of an index with amgetmulti * index_beginscan_multi - start a scan of an index with amgetmulti
...@@ -172,31 +171,6 @@ index_openrv(const RangeVar *relation) ...@@ -172,31 +171,6 @@ index_openrv(const RangeVar *relation)
return r; return r;
} }
/* ----------------
* index_openr - open a system index relation specified by name.
*
* As above, but the relation is specified by an unqualified name;
* it is assumed to live in the system catalog namespace.
* ----------------
*/
Relation
index_openr(const char *sysRelationName)
{
Relation r;
r = relation_openr(sysRelationName, NoLock);
if (r->rd_rel->relkind != RELKIND_INDEX)
ereport(ERROR,
(errcode(ERRCODE_WRONG_OBJECT_TYPE),
errmsg("\"%s\" is not an index",
RelationGetRelationName(r))));
pgstat_initstats(&r->pgstat_info, r);
return r;
}
/* ---------------- /* ----------------
* index_close - close a index relation * index_close - close a index relation
* *
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/bootstrap/bootstrap.c,v 1.201 2005/03/29 19:44:22 tgl Exp $ * $PostgreSQL: pgsql/src/backend/bootstrap/bootstrap.c,v 1.202 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -26,12 +26,12 @@ ...@@ -26,12 +26,12 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/xlog.h" #include "access/xlog.h"
#include "bootstrap/bootstrap.h" #include "bootstrap/bootstrap.h"
#include "catalog/catname.h"
#include "catalog/index.h" #include "catalog/index.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
#include "executor/executor.h" #include "executor/executor.h"
#include "libpq/pqsignal.h" #include "libpq/pqsignal.h"
#include "miscadmin.h" #include "miscadmin.h"
#include "nodes/makefuncs.h"
#include "postmaster/bgwriter.h" #include "postmaster/bgwriter.h"
#include "storage/freespace.h" #include "storage/freespace.h"
#include "storage/ipc.h" #include "storage/ipc.h"
...@@ -46,10 +46,14 @@ ...@@ -46,10 +46,14 @@
#include "utils/ps_status.h" #include "utils/ps_status.h"
#include "utils/relcache.h" #include "utils/relcache.h"
extern int optind;
extern char *optarg;
#define ALLOC(t, c) ((t *) calloc((unsigned)(c), sizeof(t))) #define ALLOC(t, c) ((t *) calloc((unsigned)(c), sizeof(t)))
extern int Int_yyparse(void); extern int Int_yyparse(void);
static void usage(void); static void usage(void);
static void bootstrap_signals(void); static void bootstrap_signals(void);
static hashnode *AddStr(char *str, int strlength, int mderef); static hashnode *AddStr(char *str, int strlength, int mderef);
...@@ -169,17 +173,12 @@ static struct typmap *Ap = NULL; ...@@ -169,17 +173,12 @@ static struct typmap *Ap = NULL;
static int Warnings = 0; static int Warnings = 0;
static char Blanks[MAXATTR]; static char Blanks[MAXATTR];
static char *relname; /* current relation name */
Form_pg_attribute attrtypes[MAXATTR]; /* points to attribute info */ Form_pg_attribute attrtypes[MAXATTR]; /* points to attribute info */
static Datum values[MAXATTR]; /* corresponding attribute values */ static Datum values[MAXATTR]; /* corresponding attribute values */
int numattr; /* number of attributes for cur. rel */ int numattr; /* number of attributes for cur. rel */
static MemoryContext nogc = NULL; /* special no-gc mem context */ static MemoryContext nogc = NULL; /* special no-gc mem context */
extern int optind;
extern char *optarg;
/* /*
* At bootstrap time, we first declare all the indices to be built, and * At bootstrap time, we first declare all the indices to be built, and
* then build them. The IndexList structure stores enough information * then build them. The IndexList structure stores enough information
...@@ -572,12 +571,12 @@ boot_openrel(char *relname) ...@@ -572,12 +571,12 @@ boot_openrel(char *relname)
HeapScanDesc scan; HeapScanDesc scan;
HeapTuple tup; HeapTuple tup;
if (strlen(relname) >= NAMEDATALEN - 1) if (strlen(relname) >= NAMEDATALEN)
relname[NAMEDATALEN - 1] = '\0'; relname[NAMEDATALEN - 1] = '\0';
if (Typ == NULL) if (Typ == NULL)
{ {
rel = heap_openr(TypeRelationName, NoLock); rel = heap_open(TypeRelationId, NoLock);
scan = heap_beginscan(rel, SnapshotNow, 0, NULL); scan = heap_beginscan(rel, SnapshotNow, 0, NULL);
i = 0; i = 0;
while ((tup = heap_getnext(scan, ForwardScanDirection)) != NULL) while ((tup = heap_getnext(scan, ForwardScanDirection)) != NULL)
...@@ -605,10 +604,9 @@ boot_openrel(char *relname) ...@@ -605,10 +604,9 @@ boot_openrel(char *relname)
closerel(NULL); closerel(NULL);
elog(DEBUG4, "open relation %s, attrsize %d", elog(DEBUG4, "open relation %s, attrsize %d",
relname ? relname : "(null)", relname, (int) ATTRIBUTE_TUPLE_SIZE);
(int) ATTRIBUTE_TUPLE_SIZE);
boot_reldesc = heap_openr(relname, NoLock); boot_reldesc = heap_openrv(makeRangeVar(NULL, relname), NoLock);
numattr = boot_reldesc->rd_rel->relnatts; numattr = boot_reldesc->rd_rel->relnatts;
for (i = 0; i < numattr; i++) for (i = 0; i < numattr; i++)
{ {
...@@ -641,7 +639,7 @@ closerel(char *name) ...@@ -641,7 +639,7 @@ closerel(char *name)
{ {
if (strcmp(RelationGetRelationName(boot_reldesc), name) != 0) if (strcmp(RelationGetRelationName(boot_reldesc), name) != 0)
elog(ERROR, "close of %s when %s was expected", elog(ERROR, "close of %s when %s was expected",
name, relname ? relname : "(null)"); name, RelationGetRelationName(boot_reldesc));
} }
else else
elog(ERROR, "close of %s before any relation was opened", elog(ERROR, "close of %s before any relation was opened",
...@@ -652,7 +650,8 @@ closerel(char *name) ...@@ -652,7 +650,8 @@ closerel(char *name)
elog(ERROR, "no open relation to close"); elog(ERROR, "no open relation to close");
else else
{ {
elog(DEBUG4, "close relation %s", relname ? relname : "(null)"); elog(DEBUG4, "close relation %s",
RelationGetRelationName(boot_reldesc));
heap_close(boot_reldesc, NoLock); heap_close(boot_reldesc, NoLock);
boot_reldesc = NULL; boot_reldesc = NULL;
} }
...@@ -676,7 +675,7 @@ DefineAttr(char *name, char *type, int attnum) ...@@ -676,7 +675,7 @@ DefineAttr(char *name, char *type, int attnum)
if (boot_reldesc != NULL) if (boot_reldesc != NULL)
{ {
elog(WARNING, "no open relations allowed with CREATE command"); elog(WARNING, "no open relations allowed with CREATE command");
closerel(relname); closerel(NULL);
} }
if (attrtypes[attnum] == NULL) if (attrtypes[attnum] == NULL)
...@@ -933,7 +932,7 @@ gettype(char *type) ...@@ -933,7 +932,7 @@ gettype(char *type)
return i; return i;
} }
elog(DEBUG4, "external type: %s", type); elog(DEBUG4, "external type: %s", type);
rel = heap_openr(TypeRelationName, NoLock); rel = heap_open(TypeRelationId, NoLock);
scan = heap_beginscan(rel, SnapshotNow, 0, NULL); scan = heap_beginscan(rel, SnapshotNow, 0, NULL);
i = 0; i = 0;
while ((tup = heap_getnext(scan, ForwardScanDirection)) != NULL) while ((tup = heap_getnext(scan, ForwardScanDirection)) != NULL)
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.110 2005/01/27 23:36:06 neilc Exp $ * $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.111 2005/04/14 20:03:23 tgl Exp $
* *
* NOTES * NOTES
* See acl.h. * See acl.h.
...@@ -19,7 +19,6 @@ ...@@ -19,7 +19,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_conversion.h" #include "catalog/pg_conversion.h"
...@@ -270,7 +269,7 @@ ExecuteGrantStmt_Relation(GrantStmt *stmt) ...@@ -270,7 +269,7 @@ ExecuteGrantStmt_Relation(GrantStmt *stmt)
char replaces[Natts_pg_class]; char replaces[Natts_pg_class];
/* open pg_class */ /* open pg_class */
relation = heap_openr(RelationRelationName, RowExclusiveLock); relation = heap_open(RelationRelationId, RowExclusiveLock);
relOid = RangeVarGetRelid(relvar, false); relOid = RangeVarGetRelid(relvar, false);
tuple = SearchSysCache(RELOID, tuple = SearchSysCache(RELOID,
ObjectIdGetDatum(relOid), ObjectIdGetDatum(relOid),
...@@ -438,7 +437,7 @@ ExecuteGrantStmt_Database(GrantStmt *stmt) ...@@ -438,7 +437,7 @@ ExecuteGrantStmt_Database(GrantStmt *stmt)
char nulls[Natts_pg_database]; char nulls[Natts_pg_database];
char replaces[Natts_pg_database]; char replaces[Natts_pg_database];
relation = heap_openr(DatabaseRelationName, RowExclusiveLock); relation = heap_open(DatabaseRelationId, RowExclusiveLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
Anum_pg_database_datname, Anum_pg_database_datname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
...@@ -597,7 +596,7 @@ ExecuteGrantStmt_Function(GrantStmt *stmt) ...@@ -597,7 +596,7 @@ ExecuteGrantStmt_Function(GrantStmt *stmt)
oid = LookupFuncNameTypeNames(func->funcname, func->funcargs, false); oid = LookupFuncNameTypeNames(func->funcname, func->funcargs, false);
relation = heap_openr(ProcedureRelationName, RowExclusiveLock); relation = heap_open(ProcedureRelationId, RowExclusiveLock);
tuple = SearchSysCache(PROCOID, tuple = SearchSysCache(PROCOID,
ObjectIdGetDatum(oid), ObjectIdGetDatum(oid),
0, 0, 0); 0, 0, 0);
...@@ -748,7 +747,7 @@ ExecuteGrantStmt_Language(GrantStmt *stmt) ...@@ -748,7 +747,7 @@ ExecuteGrantStmt_Language(GrantStmt *stmt)
char nulls[Natts_pg_language]; char nulls[Natts_pg_language];
char replaces[Natts_pg_language]; char replaces[Natts_pg_language];
relation = heap_openr(LanguageRelationName, RowExclusiveLock); relation = heap_open(LanguageRelationId, RowExclusiveLock);
tuple = SearchSysCache(LANGNAME, tuple = SearchSysCache(LANGNAME,
PointerGetDatum(langname), PointerGetDatum(langname),
0, 0, 0); 0, 0, 0);
...@@ -911,7 +910,7 @@ ExecuteGrantStmt_Namespace(GrantStmt *stmt) ...@@ -911,7 +910,7 @@ ExecuteGrantStmt_Namespace(GrantStmt *stmt)
char nulls[Natts_pg_namespace]; char nulls[Natts_pg_namespace];
char replaces[Natts_pg_namespace]; char replaces[Natts_pg_namespace];
relation = heap_openr(NamespaceRelationName, RowExclusiveLock); relation = heap_open(NamespaceRelationId, RowExclusiveLock);
tuple = SearchSysCache(NAMESPACENAME, tuple = SearchSysCache(NAMESPACENAME,
CStringGetDatum(nspname), CStringGetDatum(nspname),
0, 0, 0); 0, 0, 0);
...@@ -1067,7 +1066,7 @@ ExecuteGrantStmt_Tablespace(GrantStmt *stmt) ...@@ -1067,7 +1066,7 @@ ExecuteGrantStmt_Tablespace(GrantStmt *stmt)
char nulls[Natts_pg_tablespace]; char nulls[Natts_pg_tablespace];
char replaces[Natts_pg_tablespace]; char replaces[Natts_pg_tablespace];
relation = heap_openr(TableSpaceRelationName, RowExclusiveLock); relation = heap_open(TableSpaceRelationId, RowExclusiveLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
Anum_pg_tablespace_spcname, Anum_pg_tablespace_spcname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
...@@ -1455,7 +1454,7 @@ pg_database_aclmask(Oid db_oid, AclId userid, ...@@ -1455,7 +1454,7 @@ pg_database_aclmask(Oid db_oid, AclId userid,
* *
* There's no syscache for pg_database, so must look the hard way * There's no syscache for pg_database, so must look the hard way
*/ */
pg_database = heap_openr(DatabaseRelationName, AccessShareLock); pg_database = heap_open(DatabaseRelationId, AccessShareLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
...@@ -1726,7 +1725,7 @@ pg_tablespace_aclmask(Oid spc_oid, AclId userid, ...@@ -1726,7 +1725,7 @@ pg_tablespace_aclmask(Oid spc_oid, AclId userid,
* *
* There's no syscache for pg_tablespace, so must look the hard way * There's no syscache for pg_tablespace, so must look the hard way
*/ */
pg_tablespace = heap_openr(TableSpaceRelationName, AccessShareLock); pg_tablespace = heap_open(TableSpaceRelationId, AccessShareLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
...@@ -2002,7 +2001,7 @@ pg_tablespace_ownercheck(Oid spc_oid, AclId userid) ...@@ -2002,7 +2001,7 @@ pg_tablespace_ownercheck(Oid spc_oid, AclId userid)
return true; return true;
/* There's no syscache for pg_tablespace, so must look the hard way */ /* There's no syscache for pg_tablespace, so must look the hard way */
pg_tablespace = heap_openr(TableSpaceRelationName, AccessShareLock); pg_tablespace = heap_open(TableSpaceRelationId, AccessShareLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
...@@ -2070,7 +2069,7 @@ pg_database_ownercheck(Oid db_oid, AclId userid) ...@@ -2070,7 +2069,7 @@ pg_database_ownercheck(Oid db_oid, AclId userid)
return true; return true;
/* There's no syscache for pg_database, so must look the hard way */ /* There's no syscache for pg_database, so must look the hard way */
pg_database = heap_openr(DatabaseRelationName, AccessShareLock); pg_database = heap_open(DatabaseRelationId, AccessShareLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/catalog.c,v 1.58 2005/03/07 04:15:34 neilc Exp $ * $PostgreSQL: pgsql/src/backend/catalog/catalog.c,v 1.59 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -18,7 +18,6 @@ ...@@ -18,7 +18,6 @@
#include "access/transam.h" #include "access/transam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/pg_namespace.h" #include "catalog/pg_namespace.h"
#include "catalog/pg_tablespace.h" #include "catalog/pg_tablespace.h"
#include "miscadmin.h" #include "miscadmin.h"
......
This diff is collapsed.
...@@ -6,11 +6,12 @@ ...@@ -6,11 +6,12 @@
# files. These .bki files are used to initialize the postgres template # files. These .bki files are used to initialize the postgres template
# database. # database.
# #
# Copyright (c) 1994, Regents of the University of California # Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
# Portions Copyright (c) 1994, Regents of the University of California
# #
# #
# IDENTIFICATION # IDENTIFICATION
# $PostgreSQL: pgsql/src/backend/catalog/genbki.sh,v 1.35 2005/04/14 01:38:16 tgl Exp $ # $PostgreSQL: pgsql/src/backend/catalog/genbki.sh,v 1.36 2005/04/14 20:03:23 tgl Exp $
# #
# NOTES # NOTES
# non-essential whitespace is removed from the generated file. # non-essential whitespace is removed from the generated file.
...@@ -230,10 +231,10 @@ comment_level > 0 { next; } ...@@ -230,10 +231,10 @@ comment_level > 0 { next; }
iname = substr(data, 1, pos-1); iname = substr(data, 1, pos-1);
data = substr(data, pos+1, length(data)-pos); data = substr(data, pos+1, length(data)-pos);
pos = index(data, ","); pos = index(data, ",");
ioid = substr(data, 1, pos-1); oid = substr(data, 1, pos-1);
data = substr(data, pos+1, length(data)-pos); data = substr(data, pos+1, length(data)-pos);
print "declare index " iname " " ioid " " data print "declare index " iname " " oid " " data
} }
/^DECLARE_UNIQUE_INDEX\(/ { /^DECLARE_UNIQUE_INDEX\(/ {
...@@ -250,10 +251,10 @@ comment_level > 0 { next; } ...@@ -250,10 +251,10 @@ comment_level > 0 { next; }
iname = substr(data, 1, pos-1); iname = substr(data, 1, pos-1);
data = substr(data, pos+1, length(data)-pos); data = substr(data, pos+1, length(data)-pos);
pos = index(data, ","); pos = index(data, ",");
ioid = substr(data, 1, pos-1); oid = substr(data, 1, pos-1);
data = substr(data, pos+1, length(data)-pos); data = substr(data, pos+1, length(data)-pos);
print "declare unique index " iname " " ioid " " data print "declare unique index " iname " " oid " " data
} }
/^BUILD_INDICES/ { print "build indices"; } /^BUILD_INDICES/ { print "build indices"; }
...@@ -277,7 +278,7 @@ comment_level > 0 { next; } ...@@ -277,7 +278,7 @@ comment_level > 0 { next; }
catalogandoid = substr($1,9,pos-9); catalogandoid = substr($1,9,pos-9);
pos = index(catalogandoid, ","); pos = index(catalogandoid, ",");
catalog = substr(catalogandoid, 1, pos-1); catalog = substr(catalogandoid, 1, pos-1);
catalogoid = substr(catalogandoid, pos+1, length(catalogandoid)-pos); oid = substr(catalogandoid, pos+1, length(catalogandoid)-pos);
if ($0 ~ /BKI_BOOTSTRAP/) { if ($0 ~ /BKI_BOOTSTRAP/) {
bootstrap = "bootstrap "; bootstrap = "bootstrap ";
...@@ -296,7 +297,7 @@ comment_level > 0 { next; } ...@@ -296,7 +297,7 @@ comment_level > 0 { next; }
} }
# ---------------- # ----------------
# process the contents of the catalog definition # process the columns of the catalog definition
# #
# attname[ x ] contains the attribute name for attribute x # attname[ x ] contains the attribute name for attribute x
# atttype[ x ] contains the attribute type fot attribute x # atttype[ x ] contains the attribute type fot attribute x
...@@ -312,7 +313,7 @@ inside == 1 { ...@@ -312,7 +313,7 @@ inside == 1 {
# if this is the last line, then output the bki catalog stuff. # if this is the last line, then output the bki catalog stuff.
# ---- # ----
if ($1 ~ /}/) { if ($1 ~ /}/) {
print "create " bootstrap shared_relation without_oids catalog " " catalogoid; print "create " bootstrap shared_relation without_oids catalog " " oid;
print "\t("; print "\t(";
for (j=1; j<i-1; j++) { for (j=1; j<i-1; j++) {
...@@ -335,7 +336,7 @@ inside == 1 { ...@@ -335,7 +336,7 @@ inside == 1 {
} }
# ---- # ----
# if we are inside the catalog definition, then keep sucking up # we are inside the catalog definition, so keep sucking up
# attribute names and types # attribute names and types
# ---- # ----
if ($2 ~ /\[.*\]/) { # array attribute if ($2 ~ /\[.*\]/) { # array attribute
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/heap.c,v 1.283 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/heap.c,v 1.284 2005/04/14 20:03:23 tgl Exp $
* *
* *
* INTERFACE ROUTINES * INTERFACE ROUTINES
...@@ -32,7 +32,6 @@ ...@@ -32,7 +32,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/genam.h" #include "access/genam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/heap.h" #include "catalog/heap.h"
#include "catalog/index.h" #include "catalog/index.h"
...@@ -40,6 +39,7 @@ ...@@ -40,6 +39,7 @@
#include "catalog/pg_attrdef.h" #include "catalog/pg_attrdef.h"
#include "catalog/pg_constraint.h" #include "catalog/pg_constraint.h"
#include "catalog/pg_inherits.h" #include "catalog/pg_inherits.h"
#include "catalog/pg_namespace.h"
#include "catalog/pg_statistic.h" #include "catalog/pg_statistic.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
#include "commands/tablecmds.h" #include "commands/tablecmds.h"
...@@ -452,7 +452,7 @@ AddNewAttributeTuples(Oid new_rel_oid, ...@@ -452,7 +452,7 @@ AddNewAttributeTuples(Oid new_rel_oid,
/* /*
* open pg_attribute and its indexes. * open pg_attribute and its indexes.
*/ */
rel = heap_openr(AttributeRelationName, RowExclusiveLock); rel = heap_open(AttributeRelationId, RowExclusiveLock);
indstate = CatalogOpenIndexes(rel); indstate = CatalogOpenIndexes(rel);
...@@ -723,7 +723,7 @@ heap_create_with_catalog(const char *relname, ...@@ -723,7 +723,7 @@ heap_create_with_catalog(const char *relname,
* is creating the same relation name in parallel but hadn't committed * is creating the same relation name in parallel but hadn't committed
* yet when we checked for a duplicate name above. * yet when we checked for a duplicate name above.
*/ */
pg_class_desc = heap_openr(RelationRelationName, RowExclusiveLock); pg_class_desc = heap_open(RelationRelationId, RowExclusiveLock);
AddNewRelationTuple(pg_class_desc, AddNewRelationTuple(pg_class_desc,
new_rel_desc, new_rel_desc,
...@@ -764,7 +764,7 @@ heap_create_with_catalog(const char *relname, ...@@ -764,7 +764,7 @@ heap_create_with_catalog(const char *relname,
myself.classId = RelationRelationId; myself.classId = RelationRelationId;
myself.objectId = new_rel_oid; myself.objectId = new_rel_oid;
myself.objectSubId = 0; myself.objectSubId = 0;
referenced.classId = get_system_catalog_relid(NamespaceRelationName); referenced.classId = NamespaceRelationId;
referenced.objectId = relnamespace; referenced.objectId = relnamespace;
referenced.objectSubId = 0; referenced.objectSubId = 0;
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
...@@ -814,14 +814,14 @@ RelationRemoveInheritance(Oid relid) ...@@ -814,14 +814,14 @@ RelationRemoveInheritance(Oid relid)
ScanKeyData key; ScanKeyData key;
HeapTuple tuple; HeapTuple tuple;
catalogRelation = heap_openr(InheritsRelationName, RowExclusiveLock); catalogRelation = heap_open(InheritsRelationId, RowExclusiveLock);
ScanKeyInit(&key, ScanKeyInit(&key,
Anum_pg_inherits_inhrelid, Anum_pg_inherits_inhrelid,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(relid)); ObjectIdGetDatum(relid));
scan = systable_beginscan(catalogRelation, InheritsRelidSeqnoIndex, true, scan = systable_beginscan(catalogRelation, InheritsRelidSeqnoIndexId, true,
SnapshotNow, 1, &key); SnapshotNow, 1, &key);
while (HeapTupleIsValid(tuple = systable_getnext(scan))) while (HeapTupleIsValid(tuple = systable_getnext(scan)))
...@@ -846,7 +846,7 @@ DeleteRelationTuple(Oid relid) ...@@ -846,7 +846,7 @@ DeleteRelationTuple(Oid relid)
HeapTuple tup; HeapTuple tup;
/* Grab an appropriate lock on the pg_class relation */ /* Grab an appropriate lock on the pg_class relation */
pg_class_desc = heap_openr(RelationRelationName, RowExclusiveLock); pg_class_desc = heap_open(RelationRelationId, RowExclusiveLock);
tup = SearchSysCache(RELOID, tup = SearchSysCache(RELOID,
ObjectIdGetDatum(relid), ObjectIdGetDatum(relid),
...@@ -879,7 +879,7 @@ DeleteAttributeTuples(Oid relid) ...@@ -879,7 +879,7 @@ DeleteAttributeTuples(Oid relid)
HeapTuple atttup; HeapTuple atttup;
/* Grab an appropriate lock on the pg_attribute relation */ /* Grab an appropriate lock on the pg_attribute relation */
attrel = heap_openr(AttributeRelationName, RowExclusiveLock); attrel = heap_open(AttributeRelationId, RowExclusiveLock);
/* Use the index to scan only attributes of the target relation */ /* Use the index to scan only attributes of the target relation */
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
...@@ -887,7 +887,7 @@ DeleteAttributeTuples(Oid relid) ...@@ -887,7 +887,7 @@ DeleteAttributeTuples(Oid relid)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(relid)); ObjectIdGetDatum(relid));
scan = systable_beginscan(attrel, AttributeRelidNumIndex, true, scan = systable_beginscan(attrel, AttributeRelidNumIndexId, true,
SnapshotNow, 1, key); SnapshotNow, 1, key);
/* Delete all the matching tuples */ /* Delete all the matching tuples */
...@@ -925,7 +925,7 @@ RemoveAttributeById(Oid relid, AttrNumber attnum) ...@@ -925,7 +925,7 @@ RemoveAttributeById(Oid relid, AttrNumber attnum)
*/ */
rel = relation_open(relid, AccessExclusiveLock); rel = relation_open(relid, AccessExclusiveLock);
attr_rel = heap_openr(AttributeRelationName, RowExclusiveLock); attr_rel = heap_open(AttributeRelationId, RowExclusiveLock);
tuple = SearchSysCacheCopy(ATTNUM, tuple = SearchSysCacheCopy(ATTNUM,
ObjectIdGetDatum(relid), ObjectIdGetDatum(relid),
...@@ -1010,7 +1010,7 @@ RemoveAttrDefault(Oid relid, AttrNumber attnum, ...@@ -1010,7 +1010,7 @@ RemoveAttrDefault(Oid relid, AttrNumber attnum,
HeapTuple tuple; HeapTuple tuple;
bool found = false; bool found = false;
attrdef_rel = heap_openr(AttrDefaultRelationName, RowExclusiveLock); attrdef_rel = heap_open(AttrDefaultRelationId, RowExclusiveLock);
ScanKeyInit(&scankeys[0], ScanKeyInit(&scankeys[0],
Anum_pg_attrdef_adrelid, Anum_pg_attrdef_adrelid,
...@@ -1021,7 +1021,7 @@ RemoveAttrDefault(Oid relid, AttrNumber attnum, ...@@ -1021,7 +1021,7 @@ RemoveAttrDefault(Oid relid, AttrNumber attnum,
BTEqualStrategyNumber, F_INT2EQ, BTEqualStrategyNumber, F_INT2EQ,
Int16GetDatum(attnum)); Int16GetDatum(attnum));
scan = systable_beginscan(attrdef_rel, AttrDefaultIndex, true, scan = systable_beginscan(attrdef_rel, AttrDefaultIndexId, true,
SnapshotNow, 2, scankeys); SnapshotNow, 2, scankeys);
/* There should be at most one matching tuple, but we loop anyway */ /* There should be at most one matching tuple, but we loop anyway */
...@@ -1029,7 +1029,7 @@ RemoveAttrDefault(Oid relid, AttrNumber attnum, ...@@ -1029,7 +1029,7 @@ RemoveAttrDefault(Oid relid, AttrNumber attnum,
{ {
ObjectAddress object; ObjectAddress object;
object.classId = RelationGetRelid(attrdef_rel); object.classId = AttrDefaultRelationId;
object.objectId = HeapTupleGetOid(tuple); object.objectId = HeapTupleGetOid(tuple);
object.objectSubId = 0; object.objectSubId = 0;
...@@ -1066,7 +1066,7 @@ RemoveAttrDefaultById(Oid attrdefId) ...@@ -1066,7 +1066,7 @@ RemoveAttrDefaultById(Oid attrdefId)
AttrNumber myattnum; AttrNumber myattnum;
/* Grab an appropriate lock on the pg_attrdef relation */ /* Grab an appropriate lock on the pg_attrdef relation */
attrdef_rel = heap_openr(AttrDefaultRelationName, RowExclusiveLock); attrdef_rel = heap_open(AttrDefaultRelationId, RowExclusiveLock);
/* Find the pg_attrdef tuple */ /* Find the pg_attrdef tuple */
ScanKeyInit(&scankeys[0], ScanKeyInit(&scankeys[0],
...@@ -1074,7 +1074,7 @@ RemoveAttrDefaultById(Oid attrdefId) ...@@ -1074,7 +1074,7 @@ RemoveAttrDefaultById(Oid attrdefId)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(attrdefId)); ObjectIdGetDatum(attrdefId));
scan = systable_beginscan(attrdef_rel, AttrDefaultOidIndex, true, scan = systable_beginscan(attrdef_rel, AttrDefaultOidIndexId, true,
SnapshotNow, 1, scankeys); SnapshotNow, 1, scankeys);
tuple = systable_getnext(scan); tuple = systable_getnext(scan);
...@@ -1094,7 +1094,7 @@ RemoveAttrDefaultById(Oid attrdefId) ...@@ -1094,7 +1094,7 @@ RemoveAttrDefaultById(Oid attrdefId)
heap_close(attrdef_rel, RowExclusiveLock); heap_close(attrdef_rel, RowExclusiveLock);
/* Fix the pg_attribute row */ /* Fix the pg_attribute row */
attr_rel = heap_openr(AttributeRelationName, RowExclusiveLock); attr_rel = heap_open(AttributeRelationId, RowExclusiveLock);
tuple = SearchSysCacheCopy(ATTNUM, tuple = SearchSysCacheCopy(ATTNUM,
ObjectIdGetDatum(myrelid), ObjectIdGetDatum(myrelid),
...@@ -1236,14 +1236,14 @@ StoreAttrDefault(Relation rel, AttrNumber attnum, char *adbin) ...@@ -1236,14 +1236,14 @@ StoreAttrDefault(Relation rel, AttrNumber attnum, char *adbin)
values[Anum_pg_attrdef_adsrc - 1] = DirectFunctionCall1(textin, values[Anum_pg_attrdef_adsrc - 1] = DirectFunctionCall1(textin,
CStringGetDatum(adsrc)); CStringGetDatum(adsrc));
adrel = heap_openr(AttrDefaultRelationName, RowExclusiveLock); adrel = heap_open(AttrDefaultRelationId, RowExclusiveLock);
tuple = heap_formtuple(adrel->rd_att, values, nulls); tuple = heap_formtuple(adrel->rd_att, values, nulls);
attrdefOid = simple_heap_insert(adrel, tuple); attrdefOid = simple_heap_insert(adrel, tuple);
CatalogUpdateIndexes(adrel, tuple); CatalogUpdateIndexes(adrel, tuple);
defobject.classId = RelationGetRelid(adrel); defobject.classId = AttrDefaultRelationId;
defobject.objectId = attrdefOid; defobject.objectId = attrdefOid;
defobject.objectSubId = 0; defobject.objectSubId = 0;
...@@ -1259,7 +1259,7 @@ StoreAttrDefault(Relation rel, AttrNumber attnum, char *adbin) ...@@ -1259,7 +1259,7 @@ StoreAttrDefault(Relation rel, AttrNumber attnum, char *adbin)
* Update the pg_attribute entry for the column to show that a default * Update the pg_attribute entry for the column to show that a default
* exists. * exists.
*/ */
attrrel = heap_openr(AttributeRelationName, RowExclusiveLock); attrrel = heap_open(AttributeRelationId, RowExclusiveLock);
atttup = SearchSysCacheCopy(ATTNUM, atttup = SearchSysCacheCopy(ATTNUM,
ObjectIdGetDatum(RelationGetRelid(rel)), ObjectIdGetDatum(RelationGetRelid(rel)),
Int16GetDatum(attnum), Int16GetDatum(attnum),
...@@ -1666,7 +1666,7 @@ SetRelationNumChecks(Relation rel, int numchecks) ...@@ -1666,7 +1666,7 @@ SetRelationNumChecks(Relation rel, int numchecks)
HeapTuple reltup; HeapTuple reltup;
Form_pg_class relStruct; Form_pg_class relStruct;
relrel = heap_openr(RelationRelationName, RowExclusiveLock); relrel = heap_open(RelationRelationId, RowExclusiveLock);
reltup = SearchSysCacheCopy(RELOID, reltup = SearchSysCacheCopy(RELOID,
ObjectIdGetDatum(RelationGetRelid(rel)), ObjectIdGetDatum(RelationGetRelid(rel)),
0, 0, 0); 0, 0, 0);
...@@ -1797,7 +1797,7 @@ RemoveRelConstraints(Relation rel, const char *constrName, ...@@ -1797,7 +1797,7 @@ RemoveRelConstraints(Relation rel, const char *constrName,
HeapTuple contup; HeapTuple contup;
/* Grab an appropriate lock on the pg_constraint relation */ /* Grab an appropriate lock on the pg_constraint relation */
conrel = heap_openr(ConstraintRelationName, RowExclusiveLock); conrel = heap_open(ConstraintRelationId, RowExclusiveLock);
/* Use the index to scan only constraints of the target relation */ /* Use the index to scan only constraints of the target relation */
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
...@@ -1805,7 +1805,7 @@ RemoveRelConstraints(Relation rel, const char *constrName, ...@@ -1805,7 +1805,7 @@ RemoveRelConstraints(Relation rel, const char *constrName,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(RelationGetRelid(rel))); ObjectIdGetDatum(RelationGetRelid(rel)));
conscan = systable_beginscan(conrel, ConstraintRelidIndex, true, conscan = systable_beginscan(conrel, ConstraintRelidIndexId, true,
SnapshotNow, 1, key); SnapshotNow, 1, key);
/* /*
...@@ -1819,7 +1819,7 @@ RemoveRelConstraints(Relation rel, const char *constrName, ...@@ -1819,7 +1819,7 @@ RemoveRelConstraints(Relation rel, const char *constrName,
{ {
ObjectAddress conobj; ObjectAddress conobj;
conobj.classId = RelationGetRelid(conrel); conobj.classId = ConstraintRelationId;
conobj.objectId = HeapTupleGetOid(contup); conobj.objectId = HeapTupleGetOid(contup);
conobj.objectSubId = 0; conobj.objectSubId = 0;
...@@ -1852,7 +1852,7 @@ RemoveStatistics(Oid relid, AttrNumber attnum) ...@@ -1852,7 +1852,7 @@ RemoveStatistics(Oid relid, AttrNumber attnum)
int nkeys; int nkeys;
HeapTuple tuple; HeapTuple tuple;
pgstatistic = heap_openr(StatisticRelationName, RowExclusiveLock); pgstatistic = heap_open(StatisticRelationId, RowExclusiveLock);
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
Anum_pg_statistic_starelid, Anum_pg_statistic_starelid,
...@@ -1870,7 +1870,7 @@ RemoveStatistics(Oid relid, AttrNumber attnum) ...@@ -1870,7 +1870,7 @@ RemoveStatistics(Oid relid, AttrNumber attnum)
nkeys = 2; nkeys = 2;
} }
scan = systable_beginscan(pgstatistic, StatisticRelidAttnumIndex, true, scan = systable_beginscan(pgstatistic, StatisticRelidAttnumIndexId, true,
SnapshotNow, nkeys, key); SnapshotNow, nkeys, key);
while (HeapTupleIsValid(tuple = systable_getnext(scan))) while (HeapTupleIsValid(tuple = systable_getnext(scan)))
...@@ -2036,9 +2036,9 @@ heap_truncate_check_FKs(List *relations, bool tempTables) ...@@ -2036,9 +2036,9 @@ heap_truncate_check_FKs(List *relations, bool tempTables)
* Otherwise, must scan pg_constraint. Right now, it is a seqscan * Otherwise, must scan pg_constraint. Right now, it is a seqscan
* because there is no available index on confrelid. * because there is no available index on confrelid.
*/ */
fkeyRel = heap_openr(ConstraintRelationName, AccessShareLock); fkeyRel = heap_open(ConstraintRelationId, AccessShareLock);
fkeyScan = systable_beginscan(fkeyRel, NULL, false, fkeyScan = systable_beginscan(fkeyRel, InvalidOid, false,
SnapshotNow, 0, NULL); SnapshotNow, 0, NULL);
while (HeapTupleIsValid(tuple = systable_getnext(fkeyScan))) while (HeapTupleIsValid(tuple = systable_getnext(fkeyScan)))
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.251 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.252 2005/04/14 20:03:23 tgl Exp $
* *
* *
* INTERFACE ROUTINES * INTERFACE ROUTINES
...@@ -27,7 +27,6 @@ ...@@ -27,7 +27,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "bootstrap/bootstrap.h" #include "bootstrap/bootstrap.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/heap.h" #include "catalog/heap.h"
#include "catalog/index.h" #include "catalog/index.h"
...@@ -245,7 +244,7 @@ UpdateRelationRelation(Relation indexRelation) ...@@ -245,7 +244,7 @@ UpdateRelationRelation(Relation indexRelation)
Relation pg_class; Relation pg_class;
HeapTuple tuple; HeapTuple tuple;
pg_class = heap_openr(RelationRelationName, RowExclusiveLock); pg_class = heap_open(RelationRelationId, RowExclusiveLock);
/* XXX Natts_pg_class_fixed is a hack - see pg_class.h */ /* XXX Natts_pg_class_fixed is a hack - see pg_class.h */
tuple = heap_addheader(Natts_pg_class_fixed, tuple = heap_addheader(Natts_pg_class_fixed,
...@@ -301,7 +300,7 @@ AppendAttributeTuples(Relation indexRelation, int numatts) ...@@ -301,7 +300,7 @@ AppendAttributeTuples(Relation indexRelation, int numatts)
/* /*
* open the attribute relation and its indexes * open the attribute relation and its indexes
*/ */
pg_attribute = heap_openr(AttributeRelationName, RowExclusiveLock); pg_attribute = heap_open(AttributeRelationId, RowExclusiveLock);
indstate = CatalogOpenIndexes(pg_attribute); indstate = CatalogOpenIndexes(pg_attribute);
...@@ -400,7 +399,7 @@ UpdateIndexRelation(Oid indexoid, ...@@ -400,7 +399,7 @@ UpdateIndexRelation(Oid indexoid,
/* /*
* open the system catalog index relation * open the system catalog index relation
*/ */
pg_index = heap_openr(IndexRelationName, RowExclusiveLock); pg_index = heap_open(IndexRelationId, RowExclusiveLock);
/* /*
* Build a pg_index tuple * Build a pg_index tuple
...@@ -649,7 +648,7 @@ index_create(Oid heapRelationId, ...@@ -649,7 +648,7 @@ index_create(Oid heapRelationId,
NULL, NULL,
NULL); NULL);
referenced.classId = get_system_catalog_relid(ConstraintRelationName); referenced.classId = ConstraintRelationId;
referenced.objectId = conOid; referenced.objectId = conOid;
referenced.objectSubId = 0; referenced.objectSubId = 0;
...@@ -672,9 +671,9 @@ index_create(Oid heapRelationId, ...@@ -672,9 +671,9 @@ index_create(Oid heapRelationId,
} }
/* Store dependency on operator classes */ /* Store dependency on operator classes */
referenced.classId = get_system_catalog_relid(OperatorClassRelationName);
for (i = 0; i < indexInfo->ii_NumIndexAttrs; i++) for (i = 0; i < indexInfo->ii_NumIndexAttrs; i++)
{ {
referenced.classId = OperatorClassRelationId;
referenced.objectId = classObjectId[i]; referenced.objectId = classObjectId[i];
referenced.objectSubId = 0; referenced.objectSubId = 0;
...@@ -797,7 +796,7 @@ index_drop(Oid indexId) ...@@ -797,7 +796,7 @@ index_drop(Oid indexId)
/* /*
* fix INDEX relation, and check for expressional index * fix INDEX relation, and check for expressional index
*/ */
indexRelation = heap_openr(IndexRelationName, RowExclusiveLock); indexRelation = heap_open(IndexRelationId, RowExclusiveLock);
tuple = SearchSysCache(INDEXRELID, tuple = SearchSysCache(INDEXRELID,
ObjectIdGetDatum(indexId), ObjectIdGetDatum(indexId),
...@@ -997,7 +996,7 @@ setRelhasindex(Oid relid, bool hasindex, bool isprimary, Oid reltoastidxid) ...@@ -997,7 +996,7 @@ setRelhasindex(Oid relid, bool hasindex, bool isprimary, Oid reltoastidxid)
* use heap_update, so cheat and overwrite the tuple in-place. In * use heap_update, so cheat and overwrite the tuple in-place. In
* normal processing, make a copy to scribble on. * normal processing, make a copy to scribble on.
*/ */
pg_class = heap_openr(RelationRelationName, RowExclusiveLock); pg_class = heap_open(RelationRelationId, RowExclusiveLock);
if (!IsBootstrapProcessingMode()) if (!IsBootstrapProcessingMode())
{ {
...@@ -1110,7 +1109,7 @@ setNewRelfilenode(Relation relation) ...@@ -1110,7 +1109,7 @@ setNewRelfilenode(Relation relation)
* Find the pg_class tuple for the given relation. This is not used * Find the pg_class tuple for the given relation. This is not used
* during bootstrap, so okay to use heap_update always. * during bootstrap, so okay to use heap_update always.
*/ */
pg_class = heap_openr(RelationRelationName, RowExclusiveLock); pg_class = heap_open(RelationRelationId, RowExclusiveLock);
tuple = SearchSysCacheCopy(RELOID, tuple = SearchSysCacheCopy(RELOID,
ObjectIdGetDatum(RelationGetRelid(relation)), ObjectIdGetDatum(RelationGetRelid(relation)),
...@@ -1202,10 +1201,10 @@ UpdateStats(Oid relid, double reltuples) ...@@ -1202,10 +1201,10 @@ UpdateStats(Oid relid, double reltuples)
* case the stats updates will not be WAL-logged and so could be lost * case the stats updates will not be WAL-logged and so could be lost
* in a crash. This seems OK considering VACUUM does the same thing. * in a crash. This seems OK considering VACUUM does the same thing.
*/ */
pg_class = heap_openr(RelationRelationName, RowExclusiveLock); pg_class = heap_open(RelationRelationId, RowExclusiveLock);
in_place_upd = IsBootstrapProcessingMode() || in_place_upd = IsBootstrapProcessingMode() ||
ReindexIsProcessingHeap(RelationGetRelid(pg_class)); ReindexIsProcessingHeap(RelationRelationId);
if (!in_place_upd) if (!in_place_upd)
{ {
......
...@@ -13,14 +13,13 @@ ...@@ -13,14 +13,13 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/namespace.c,v 1.74 2005/03/29 00:16:56 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/namespace.c,v 1.75 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/xact.h" #include "access/xact.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_conversion.h" #include "catalog/pg_conversion.h"
...@@ -1783,7 +1782,7 @@ RemoveTempRelations(Oid tempNamespaceId) ...@@ -1783,7 +1782,7 @@ RemoveTempRelations(Oid tempNamespaceId)
* be a waste of cycles). We do this by finding everything that has a * be a waste of cycles). We do this by finding everything that has a
* dependency on the namespace. * dependency on the namespace.
*/ */
object.classId = get_system_catalog_relid(NamespaceRelationName); object.classId = NamespaceRelationId;
object.objectId = tempNamespaceId; object.objectId = tempNamespaceId;
object.objectSubId = 0; object.objectSubId = 0;
......
...@@ -8,19 +8,19 @@ ...@@ -8,19 +8,19 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_aggregate.c,v 1.74 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_aggregate.c,v 1.75 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_aggregate.h" #include "catalog/pg_aggregate.h"
#include "catalog/pg_language.h" #include "catalog/pg_language.h"
#include "catalog/pg_operator.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
#include "miscadmin.h" #include "miscadmin.h"
#include "optimizer/cost.h" #include "optimizer/cost.h"
...@@ -224,7 +224,7 @@ AggregateCreate(const char *aggName, ...@@ -224,7 +224,7 @@ AggregateCreate(const char *aggName,
else else
nulls[Anum_pg_aggregate_agginitval - 1] = 'n'; nulls[Anum_pg_aggregate_agginitval - 1] = 'n';
aggdesc = heap_openr(AggregateRelationName, RowExclusiveLock); aggdesc = heap_open(AggregateRelationId, RowExclusiveLock);
tupDesc = aggdesc->rd_att; tupDesc = aggdesc->rd_att;
tup = heap_formtuple(tupDesc, values, nulls); tup = heap_formtuple(tupDesc, values, nulls);
...@@ -262,7 +262,7 @@ AggregateCreate(const char *aggName, ...@@ -262,7 +262,7 @@ AggregateCreate(const char *aggName,
/* Depends on sort operator, if any */ /* Depends on sort operator, if any */
if (OidIsValid(sortop)) if (OidIsValid(sortop))
{ {
referenced.classId = get_system_catalog_relid(OperatorRelationName); referenced.classId = OperatorRelationId;
referenced.objectId = sortop; referenced.objectId = sortop;
referenced.objectSubId = 0; referenced.objectSubId = 0;
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_constraint.c,v 1.24 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_constraint.c,v 1.25 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -17,11 +17,11 @@ ...@@ -17,11 +17,11 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/genam.h" #include "access/genam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_constraint.h" #include "catalog/pg_constraint.h"
#include "catalog/pg_depend.h" #include "catalog/pg_depend.h"
#include "catalog/pg_trigger.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
#include "commands/defrem.h" #include "commands/defrem.h"
#include "miscadmin.h" #include "miscadmin.h"
...@@ -72,7 +72,7 @@ CreateConstraintEntry(const char *constraintName, ...@@ -72,7 +72,7 @@ CreateConstraintEntry(const char *constraintName,
int i; int i;
ObjectAddress conobject; ObjectAddress conobject;
conDesc = heap_openr(ConstraintRelationName, RowExclusiveLock); conDesc = heap_open(ConstraintRelationId, RowExclusiveLock);
Assert(constraintName); Assert(constraintName);
namestrcpy(&cname, constraintName); namestrcpy(&cname, constraintName);
...@@ -160,7 +160,7 @@ CreateConstraintEntry(const char *constraintName, ...@@ -160,7 +160,7 @@ CreateConstraintEntry(const char *constraintName,
/* update catalog indexes */ /* update catalog indexes */
CatalogUpdateIndexes(conDesc, tup); CatalogUpdateIndexes(conDesc, tup);
conobject.classId = RelationGetRelid(conDesc); conobject.classId = ConstraintRelationId;
conobject.objectId = conOid; conobject.objectId = conOid;
conobject.objectSubId = 0; conobject.objectSubId = 0;
...@@ -286,7 +286,7 @@ ConstraintNameIsUsed(ConstraintCategory conCat, Oid objId, ...@@ -286,7 +286,7 @@ ConstraintNameIsUsed(ConstraintCategory conCat, Oid objId,
ScanKeyData skey[2]; ScanKeyData skey[2];
HeapTuple tup; HeapTuple tup;
conDesc = heap_openr(ConstraintRelationName, AccessShareLock); conDesc = heap_open(ConstraintRelationId, AccessShareLock);
found = false; found = false;
...@@ -300,7 +300,7 @@ ConstraintNameIsUsed(ConstraintCategory conCat, Oid objId, ...@@ -300,7 +300,7 @@ ConstraintNameIsUsed(ConstraintCategory conCat, Oid objId,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(objNamespace)); ObjectIdGetDatum(objNamespace));
conscan = systable_beginscan(conDesc, ConstraintNameNspIndex, true, conscan = systable_beginscan(conDesc, ConstraintNameNspIndexId, true,
SnapshotNow, 2, skey); SnapshotNow, 2, skey);
while (HeapTupleIsValid(tup = systable_getnext(conscan))) while (HeapTupleIsValid(tup = systable_getnext(conscan)))
...@@ -362,7 +362,7 @@ ChooseConstraintName(const char *name1, const char *name2, ...@@ -362,7 +362,7 @@ ChooseConstraintName(const char *name1, const char *name2,
bool found; bool found;
ListCell *l; ListCell *l;
conDesc = heap_openr(ConstraintRelationName, AccessShareLock); conDesc = heap_open(ConstraintRelationId, AccessShareLock);
/* try the unmodified label first */ /* try the unmodified label first */
StrNCpy(modlabel, label, sizeof(modlabel)); StrNCpy(modlabel, label, sizeof(modlabel));
...@@ -394,7 +394,7 @@ ChooseConstraintName(const char *name1, const char *name2, ...@@ -394,7 +394,7 @@ ChooseConstraintName(const char *name1, const char *name2,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(namespace)); ObjectIdGetDatum(namespace));
conscan = systable_beginscan(conDesc, ConstraintNameNspIndex, true, conscan = systable_beginscan(conDesc, ConstraintNameNspIndexId, true,
SnapshotNow, 2, skey); SnapshotNow, 2, skey);
found = (HeapTupleIsValid(systable_getnext(conscan))); found = (HeapTupleIsValid(systable_getnext(conscan)));
...@@ -427,14 +427,14 @@ RemoveConstraintById(Oid conId) ...@@ -427,14 +427,14 @@ RemoveConstraintById(Oid conId)
HeapTuple tup; HeapTuple tup;
Form_pg_constraint con; Form_pg_constraint con;
conDesc = heap_openr(ConstraintRelationName, RowExclusiveLock); conDesc = heap_open(ConstraintRelationId, RowExclusiveLock);
ScanKeyInit(&skey[0], ScanKeyInit(&skey[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(conId)); ObjectIdGetDatum(conId));
conscan = systable_beginscan(conDesc, ConstraintOidIndex, true, conscan = systable_beginscan(conDesc, ConstraintOidIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
tup = systable_getnext(conscan); tup = systable_getnext(conscan);
...@@ -466,7 +466,7 @@ RemoveConstraintById(Oid conId) ...@@ -466,7 +466,7 @@ RemoveConstraintById(Oid conId)
HeapTuple relTup; HeapTuple relTup;
Form_pg_class classForm; Form_pg_class classForm;
pgrel = heap_openr(RelationRelationName, RowExclusiveLock); pgrel = heap_open(RelationRelationId, RowExclusiveLock);
relTup = SearchSysCacheCopy(RELOID, relTup = SearchSysCacheCopy(RELOID,
ObjectIdGetDatum(con->conrelid), ObjectIdGetDatum(con->conrelid),
0, 0, 0); 0, 0, 0);
...@@ -524,42 +524,37 @@ GetConstraintNameForTrigger(Oid triggerId) ...@@ -524,42 +524,37 @@ GetConstraintNameForTrigger(Oid triggerId)
{ {
char *result; char *result;
Oid constraintId = InvalidOid; Oid constraintId = InvalidOid;
Oid pg_trigger_id;
Oid pg_constraint_id;
Relation depRel; Relation depRel;
Relation conRel; Relation conRel;
ScanKeyData key[2]; ScanKeyData key[2];
SysScanDesc scan; SysScanDesc scan;
HeapTuple tup; HeapTuple tup;
pg_trigger_id = get_system_catalog_relid(TriggerRelationName);
pg_constraint_id = get_system_catalog_relid(ConstraintRelationName);
/* /*
* We must grovel through pg_depend to find the owning constraint. * We must grovel through pg_depend to find the owning constraint.
* Perhaps pg_trigger should have a column for the owning constraint ... * Perhaps pg_trigger should have a column for the owning constraint ...
* but right now this is not performance-critical code. * but right now this is not performance-critical code.
*/ */
depRel = heap_openr(DependRelationName, AccessShareLock); depRel = heap_open(DependRelationId, AccessShareLock);
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
Anum_pg_depend_classid, Anum_pg_depend_classid,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(pg_trigger_id)); ObjectIdGetDatum(TriggerRelationId));
ScanKeyInit(&key[1], ScanKeyInit(&key[1],
Anum_pg_depend_objid, Anum_pg_depend_objid,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(triggerId)); ObjectIdGetDatum(triggerId));
/* assume we can ignore objsubid for a trigger */ /* assume we can ignore objsubid for a trigger */
scan = systable_beginscan(depRel, DependDependerIndex, true, scan = systable_beginscan(depRel, DependDependerIndexId, true,
SnapshotNow, 2, key); SnapshotNow, 2, key);
while (HeapTupleIsValid(tup = systable_getnext(scan))) while (HeapTupleIsValid(tup = systable_getnext(scan)))
{ {
Form_pg_depend foundDep = (Form_pg_depend) GETSTRUCT(tup); Form_pg_depend foundDep = (Form_pg_depend) GETSTRUCT(tup);
if (foundDep->refclassid == pg_constraint_id && if (foundDep->refclassid == ConstraintRelationId &&
foundDep->deptype == DEPENDENCY_INTERNAL) foundDep->deptype == DEPENDENCY_INTERNAL)
{ {
constraintId = foundDep->refobjid; constraintId = foundDep->refobjid;
...@@ -574,14 +569,14 @@ GetConstraintNameForTrigger(Oid triggerId) ...@@ -574,14 +569,14 @@ GetConstraintNameForTrigger(Oid triggerId)
if (!OidIsValid(constraintId)) if (!OidIsValid(constraintId))
return NULL; /* no owning constraint found */ return NULL; /* no owning constraint found */
conRel = heap_openr(ConstraintRelationName, AccessShareLock); conRel = heap_open(ConstraintRelationId, AccessShareLock);
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(constraintId)); ObjectIdGetDatum(constraintId));
scan = systable_beginscan(conRel, ConstraintOidIndex, true, scan = systable_beginscan(conRel, ConstraintOidIndexId, true,
SnapshotNow, 1, key); SnapshotNow, 1, key);
tup = systable_getnext(scan); tup = systable_getnext(scan);
......
...@@ -8,14 +8,13 @@ ...@@ -8,14 +8,13 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_conversion.c,v 1.21 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_conversion.c,v 1.22 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_conversion.h" #include "catalog/pg_conversion.h"
...@@ -82,7 +81,7 @@ ConversionCreate(const char *conname, Oid connamespace, ...@@ -82,7 +81,7 @@ ConversionCreate(const char *conname, Oid connamespace,
} }
/* open pg_conversion */ /* open pg_conversion */
rel = heap_openr(ConversionRelationName, RowExclusiveLock); rel = heap_open(ConversionRelationId, RowExclusiveLock);
tupDesc = rel->rd_att; tupDesc = rel->rd_att;
/* initialize nulls and values */ /* initialize nulls and values */
...@@ -111,7 +110,7 @@ ConversionCreate(const char *conname, Oid connamespace, ...@@ -111,7 +110,7 @@ ConversionCreate(const char *conname, Oid connamespace,
/* update the index if any */ /* update the index if any */
CatalogUpdateIndexes(rel, tup); CatalogUpdateIndexes(rel, tup);
myself.classId = RelationGetRelid(rel); myself.classId = ConversionRelationId;
myself.objectId = HeapTupleGetOid(tup); myself.objectId = HeapTupleGetOid(tup);
myself.objectSubId = 0; myself.objectSubId = 0;
...@@ -154,7 +153,7 @@ ConversionDrop(Oid conversionOid, DropBehavior behavior) ...@@ -154,7 +153,7 @@ ConversionDrop(Oid conversionOid, DropBehavior behavior)
/* /*
* Do the deletion * Do the deletion
*/ */
object.classId = get_system_catalog_relid(ConversionRelationName); object.classId = ConversionRelationId;
object.objectId = conversionOid; object.objectId = conversionOid;
object.objectSubId = 0; object.objectSubId = 0;
...@@ -182,7 +181,7 @@ RemoveConversionById(Oid conversionOid) ...@@ -182,7 +181,7 @@ RemoveConversionById(Oid conversionOid)
ObjectIdGetDatum(conversionOid)); ObjectIdGetDatum(conversionOid));
/* open pg_conversion */ /* open pg_conversion */
rel = heap_openr(ConversionRelationName, RowExclusiveLock); rel = heap_open(ConversionRelationId, RowExclusiveLock);
tupDesc = rel->rd_att; tupDesc = rel->rd_att;
scan = heap_beginscan(rel, SnapshotNow, scan = heap_beginscan(rel, SnapshotNow,
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_depend.c,v 1.12 2004/12/31 21:59:38 pgsql Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_depend.c,v 1.13 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/pg_depend.h" #include "catalog/pg_depend.h"
...@@ -69,7 +68,7 @@ recordMultipleDependencies(const ObjectAddress *depender, ...@@ -69,7 +68,7 @@ recordMultipleDependencies(const ObjectAddress *depender,
if (IsBootstrapProcessingMode()) if (IsBootstrapProcessingMode())
return; return;
dependDesc = heap_openr(DependRelationName, RowExclusiveLock); dependDesc = heap_open(DependRelationId, RowExclusiveLock);
/* Don't open indexes unless we need to make an update */ /* Don't open indexes unless we need to make an update */
indstate = NULL; indstate = NULL;
...@@ -136,7 +135,7 @@ deleteDependencyRecordsFor(Oid classId, Oid objectId) ...@@ -136,7 +135,7 @@ deleteDependencyRecordsFor(Oid classId, Oid objectId)
SysScanDesc scan; SysScanDesc scan;
HeapTuple tup; HeapTuple tup;
depRel = heap_openr(DependRelationName, RowExclusiveLock); depRel = heap_open(DependRelationId, RowExclusiveLock);
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
Anum_pg_depend_classid, Anum_pg_depend_classid,
...@@ -147,7 +146,7 @@ deleteDependencyRecordsFor(Oid classId, Oid objectId) ...@@ -147,7 +146,7 @@ deleteDependencyRecordsFor(Oid classId, Oid objectId)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(objectId)); ObjectIdGetDatum(objectId));
scan = systable_beginscan(depRel, DependDependerIndex, true, scan = systable_beginscan(depRel, DependDependerIndexId, true,
SnapshotNow, 2, key); SnapshotNow, 2, key);
while (HeapTupleIsValid(tup = systable_getnext(scan))) while (HeapTupleIsValid(tup = systable_getnext(scan)))
...@@ -190,7 +189,7 @@ isObjectPinned(const ObjectAddress *object, Relation rel) ...@@ -190,7 +189,7 @@ isObjectPinned(const ObjectAddress *object, Relation rel)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(object->objectId)); ObjectIdGetDatum(object->objectId));
scan = systable_beginscan(rel, DependReferenceIndex, true, scan = systable_beginscan(rel, DependReferenceIndexId, true,
SnapshotNow, 2, key); SnapshotNow, 2, key);
/* /*
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_largeobject.c,v 1.23 2005/02/23 23:27:54 neilc Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_largeobject.c,v 1.24 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_largeobject.h" #include "catalog/pg_largeobject.h"
#include "miscadmin.h" #include "miscadmin.h"
...@@ -40,7 +39,7 @@ LargeObjectCreate(Oid loid) ...@@ -40,7 +39,7 @@ LargeObjectCreate(Oid loid)
char nulls[Natts_pg_largeobject]; char nulls[Natts_pg_largeobject];
int i; int i;
pg_largeobject = heap_openr(LargeObjectRelationName, RowExclusiveLock); pg_largeobject = heap_open(LargeObjectRelationId, RowExclusiveLock);
/* /*
* Form new tuple * Form new tuple
...@@ -86,9 +85,9 @@ LargeObjectDrop(Oid loid) ...@@ -86,9 +85,9 @@ LargeObjectDrop(Oid loid)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(loid)); ObjectIdGetDatum(loid));
pg_largeobject = heap_openr(LargeObjectRelationName, RowExclusiveLock); pg_largeobject = heap_open(LargeObjectRelationId, RowExclusiveLock);
sd = systable_beginscan(pg_largeobject, LargeObjectLOidPNIndex, true, sd = systable_beginscan(pg_largeobject, LargeObjectLOidPNIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
while ((tuple = systable_getnext(sd)) != NULL) while ((tuple = systable_getnext(sd)) != NULL)
...@@ -123,9 +122,9 @@ LargeObjectExists(Oid loid) ...@@ -123,9 +122,9 @@ LargeObjectExists(Oid loid)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(loid)); ObjectIdGetDatum(loid));
pg_largeobject = heap_openr(LargeObjectRelationName, AccessShareLock); pg_largeobject = heap_open(LargeObjectRelationId, AccessShareLock);
sd = systable_beginscan(pg_largeobject, LargeObjectLOidPNIndex, true, sd = systable_beginscan(pg_largeobject, LargeObjectLOidPNIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
if (systable_getnext(sd) != NULL) if (systable_getnext(sd) != NULL)
......
...@@ -8,14 +8,13 @@ ...@@ -8,14 +8,13 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_namespace.c,v 1.12 2004/12/31 21:59:38 pgsql Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_namespace.c,v 1.13 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_namespace.h" #include "catalog/pg_namespace.h"
#include "utils/builtins.h" #include "utils/builtins.h"
...@@ -61,7 +60,7 @@ NamespaceCreate(const char *nspName, int32 ownerSysId) ...@@ -61,7 +60,7 @@ NamespaceCreate(const char *nspName, int32 ownerSysId)
values[Anum_pg_namespace_nspowner - 1] = Int32GetDatum(ownerSysId); values[Anum_pg_namespace_nspowner - 1] = Int32GetDatum(ownerSysId);
nulls[Anum_pg_namespace_nspacl - 1] = 'n'; nulls[Anum_pg_namespace_nspacl - 1] = 'n';
nspdesc = heap_openr(NamespaceRelationName, RowExclusiveLock); nspdesc = heap_open(NamespaceRelationId, RowExclusiveLock);
tupDesc = nspdesc->rd_att; tupDesc = nspdesc->rd_att;
tup = heap_formtuple(tupDesc, values, nulls); tup = heap_formtuple(tupDesc, values, nulls);
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_operator.c,v 1.90 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_operator.c,v 1.91 2005/04/14 20:03:23 tgl Exp $
* *
* NOTES * NOTES
* these routines moved here from commands/define.c and somewhat cleaned up. * these routines moved here from commands/define.c and somewhat cleaned up.
...@@ -18,10 +18,10 @@ ...@@ -18,10 +18,10 @@
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_namespace.h"
#include "catalog/pg_operator.h" #include "catalog/pg_operator.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
...@@ -58,7 +58,7 @@ static Oid get_other_operator(List *otherOp, ...@@ -58,7 +58,7 @@ static Oid get_other_operator(List *otherOp,
Oid leftTypeId, Oid rightTypeId, Oid leftTypeId, Oid rightTypeId,
bool isCommutator); bool isCommutator);
static void makeOperatorDependencies(HeapTuple tuple, Oid pg_operator_relid); static void makeOperatorDependencies(HeapTuple tuple);
/* /*
...@@ -254,7 +254,7 @@ OperatorShellMake(const char *operatorName, ...@@ -254,7 +254,7 @@ OperatorShellMake(const char *operatorName,
/* /*
* open pg_operator * open pg_operator
*/ */
pg_operator_desc = heap_openr(OperatorRelationName, RowExclusiveLock); pg_operator_desc = heap_open(OperatorRelationId, RowExclusiveLock);
tupDesc = pg_operator_desc->rd_att; tupDesc = pg_operator_desc->rd_att;
/* /*
...@@ -270,7 +270,7 @@ OperatorShellMake(const char *operatorName, ...@@ -270,7 +270,7 @@ OperatorShellMake(const char *operatorName,
CatalogUpdateIndexes(pg_operator_desc, tup); CatalogUpdateIndexes(pg_operator_desc, tup);
/* Add dependencies for the entry */ /* Add dependencies for the entry */
makeOperatorDependencies(tup, RelationGetRelid(pg_operator_desc)); makeOperatorDependencies(tup);
heap_freetuple(tup); heap_freetuple(tup);
...@@ -620,7 +620,7 @@ OperatorCreate(const char *operatorName, ...@@ -620,7 +620,7 @@ OperatorCreate(const char *operatorName,
values[i++] = ObjectIdGetDatum(restOid); /* oprrest */ values[i++] = ObjectIdGetDatum(restOid); /* oprrest */
values[i++] = ObjectIdGetDatum(joinOid); /* oprjoin */ values[i++] = ObjectIdGetDatum(joinOid); /* oprjoin */
pg_operator_desc = heap_openr(OperatorRelationName, RowExclusiveLock); pg_operator_desc = heap_open(OperatorRelationId, RowExclusiveLock);
/* /*
* If we are adding to an operator shell, update; else insert * If we are adding to an operator shell, update; else insert
...@@ -654,7 +654,7 @@ OperatorCreate(const char *operatorName, ...@@ -654,7 +654,7 @@ OperatorCreate(const char *operatorName,
CatalogUpdateIndexes(pg_operator_desc, tup); CatalogUpdateIndexes(pg_operator_desc, tup);
/* Add dependencies for the entry */ /* Add dependencies for the entry */
makeOperatorDependencies(tup, RelationGetRelid(pg_operator_desc)); makeOperatorDependencies(tup);
heap_close(pg_operator_desc, RowExclusiveLock); heap_close(pg_operator_desc, RowExclusiveLock);
...@@ -773,7 +773,7 @@ OperatorUpd(Oid baseId, Oid commId, Oid negId) ...@@ -773,7 +773,7 @@ OperatorUpd(Oid baseId, Oid commId, Oid negId)
*/ */
CommandCounterIncrement(); CommandCounterIncrement();
pg_operator_desc = heap_openr(OperatorRelationName, RowExclusiveLock); pg_operator_desc = heap_open(OperatorRelationId, RowExclusiveLock);
tup = SearchSysCacheCopy(OPEROID, tup = SearchSysCacheCopy(OPEROID,
ObjectIdGetDatum(commId), ObjectIdGetDatum(commId),
...@@ -877,13 +877,13 @@ OperatorUpd(Oid baseId, Oid commId, Oid negId) ...@@ -877,13 +877,13 @@ OperatorUpd(Oid baseId, Oid commId, Oid negId)
* the given operator is a shell. * the given operator is a shell.
*/ */
static void static void
makeOperatorDependencies(HeapTuple tuple, Oid pg_operator_relid) makeOperatorDependencies(HeapTuple tuple)
{ {
Form_pg_operator oper = (Form_pg_operator) GETSTRUCT(tuple); Form_pg_operator oper = (Form_pg_operator) GETSTRUCT(tuple);
ObjectAddress myself, ObjectAddress myself,
referenced; referenced;
myself.classId = pg_operator_relid; myself.classId = OperatorRelationId;
myself.objectId = HeapTupleGetOid(tuple); myself.objectId = HeapTupleGetOid(tuple);
myself.objectSubId = 0; myself.objectSubId = 0;
...@@ -893,7 +893,7 @@ makeOperatorDependencies(HeapTuple tuple, Oid pg_operator_relid) ...@@ -893,7 +893,7 @@ makeOperatorDependencies(HeapTuple tuple, Oid pg_operator_relid)
/* Dependency on namespace */ /* Dependency on namespace */
if (OidIsValid(oper->oprnamespace)) if (OidIsValid(oper->oprnamespace))
{ {
referenced.classId = get_system_catalog_relid(NamespaceRelationName); referenced.classId = NamespaceRelationId;
referenced.objectId = oper->oprnamespace; referenced.objectId = oper->oprnamespace;
referenced.objectSubId = 0; referenced.objectSubId = 0;
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
......
...@@ -8,16 +8,17 @@ ...@@ -8,16 +8,17 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_proc.c,v 1.127 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_proc.c,v 1.128 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_language.h"
#include "catalog/pg_namespace.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
#include "executor/functions.h" #include "executor/functions.h"
...@@ -226,7 +227,7 @@ ProcedureCreate(const char *procedureName, ...@@ -226,7 +227,7 @@ ProcedureCreate(const char *procedureName,
/* start out with empty permissions */ /* start out with empty permissions */
nulls[Anum_pg_proc_proacl - 1] = 'n'; nulls[Anum_pg_proc_proacl - 1] = 'n';
rel = heap_openr(ProcedureRelationName, RowExclusiveLock); rel = heap_open(ProcedureRelationId, RowExclusiveLock);
tupDesc = RelationGetDescr(rel); tupDesc = RelationGetDescr(rel);
/* Check for pre-existing definition */ /* Check for pre-existing definition */
...@@ -336,13 +337,13 @@ ProcedureCreate(const char *procedureName, ...@@ -336,13 +337,13 @@ ProcedureCreate(const char *procedureName,
myself.objectSubId = 0; myself.objectSubId = 0;
/* dependency on namespace */ /* dependency on namespace */
referenced.classId = get_system_catalog_relid(NamespaceRelationName); referenced.classId = NamespaceRelationId;
referenced.objectId = procNamespace; referenced.objectId = procNamespace;
referenced.objectSubId = 0; referenced.objectSubId = 0;
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
/* dependency on implementation language */ /* dependency on implementation language */
referenced.classId = get_system_catalog_relid(LanguageRelationName); referenced.classId = LanguageRelationId;
referenced.objectId = languageObjectId; referenced.objectId = languageObjectId;
referenced.objectSubId = 0; referenced.objectSubId = 0;
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
......
...@@ -8,16 +8,16 @@ ...@@ -8,16 +8,16 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/catalog/pg_type.c,v 1.99 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/catalog/pg_type.c,v 1.100 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_namespace.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
#include "miscadmin.h" #include "miscadmin.h"
...@@ -56,7 +56,7 @@ TypeShellMake(const char *typeName, Oid typeNamespace) ...@@ -56,7 +56,7 @@ TypeShellMake(const char *typeName, Oid typeNamespace)
/* /*
* open pg_type * open pg_type
*/ */
pg_type_desc = heap_openr(TypeRelationName, RowExclusiveLock); pg_type_desc = heap_open(TypeRelationId, RowExclusiveLock);
tupDesc = pg_type_desc->rd_att; tupDesc = pg_type_desc->rd_att;
/* /*
...@@ -274,7 +274,7 @@ TypeCreate(const char *typeName, ...@@ -274,7 +274,7 @@ TypeCreate(const char *typeName,
* NOTE: updating will not work correctly in bootstrap mode; but we don't * NOTE: updating will not work correctly in bootstrap mode; but we don't
* expect to be overwriting any shell types in bootstrap mode. * expect to be overwriting any shell types in bootstrap mode.
*/ */
pg_type_desc = heap_openr(TypeRelationName, RowExclusiveLock); pg_type_desc = heap_open(TypeRelationId, RowExclusiveLock);
tup = SearchSysCacheCopy(TYPENAMENSP, tup = SearchSysCacheCopy(TYPENAMENSP,
CStringGetDatum(typeName), CStringGetDatum(typeName),
...@@ -389,7 +389,7 @@ GenerateTypeDependencies(Oid typeNamespace, ...@@ -389,7 +389,7 @@ GenerateTypeDependencies(Oid typeNamespace,
/* skip for relation rowtype, since we have indirect dependency */ /* skip for relation rowtype, since we have indirect dependency */
if (!OidIsValid(relationOid)) if (!OidIsValid(relationOid))
{ {
referenced.classId = get_system_catalog_relid(NamespaceRelationName); referenced.classId = NamespaceRelationId;
referenced.objectId = typeNamespace; referenced.objectId = typeNamespace;
referenced.objectSubId = 0; referenced.objectSubId = 0;
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
...@@ -502,7 +502,7 @@ TypeRename(const char *oldTypeName, Oid typeNamespace, ...@@ -502,7 +502,7 @@ TypeRename(const char *oldTypeName, Oid typeNamespace,
Relation pg_type_desc; Relation pg_type_desc;
HeapTuple tuple; HeapTuple tuple;
pg_type_desc = heap_openr(TypeRelationName, RowExclusiveLock); pg_type_desc = heap_open(TypeRelationId, RowExclusiveLock);
tuple = SearchSysCacheCopy(TYPENAMENSP, tuple = SearchSysCacheCopy(TYPENAMENSP,
CStringGetDatum(oldTypeName), CStringGetDatum(oldTypeName),
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/aggregatecmds.c,v 1.25 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/aggregatecmds.c,v 1.26 2005/04/14 20:03:23 tgl Exp $
* *
* DESCRIPTION * DESCRIPTION
* The "DefineFoo" routines take the parse tree and pick out the * The "DefineFoo" routines take the parse tree and pick out the
...@@ -23,7 +23,6 @@ ...@@ -23,7 +23,6 @@
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
...@@ -236,7 +235,7 @@ RenameAggregate(List *name, TypeName *basetype, const char *newname) ...@@ -236,7 +235,7 @@ RenameAggregate(List *name, TypeName *basetype, const char *newname)
else else
basetypeOid = ANYOID; basetypeOid = ANYOID;
rel = heap_openr(ProcedureRelationName, RowExclusiveLock); rel = heap_open(ProcedureRelationId, RowExclusiveLock);
procOid = find_aggregate_func(name, basetypeOid, false); procOid = find_aggregate_func(name, basetypeOid, false);
...@@ -315,7 +314,7 @@ AlterAggregateOwner(List *name, TypeName *basetype, AclId newOwnerSysId) ...@@ -315,7 +314,7 @@ AlterAggregateOwner(List *name, TypeName *basetype, AclId newOwnerSysId)
else else
basetypeOid = ANYOID; basetypeOid = ANYOID;
rel = heap_openr(ProcedureRelationName, RowExclusiveLock); rel = heap_open(ProcedureRelationId, RowExclusiveLock);
procOid = find_aggregate_func(name, basetypeOid, false); procOid = find_aggregate_func(name, basetypeOid, false);
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.84 2005/03/21 01:24:02 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.85 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -19,7 +19,6 @@ ...@@ -19,7 +19,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/tuptoaster.h" #include "access/tuptoaster.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/index.h" #include "catalog/index.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
...@@ -187,8 +186,7 @@ analyze_rel(Oid relid, VacuumStmt *vacstmt) ...@@ -187,8 +186,7 @@ analyze_rel(Oid relid, VacuumStmt *vacstmt)
/* /*
* We can ANALYZE any table except pg_statistic. See update_attstats * We can ANALYZE any table except pg_statistic. See update_attstats
*/ */
if (IsSystemNamespace(RelationGetNamespace(onerel)) && if (RelationGetRelid(onerel) == StatisticRelationId)
strcmp(RelationGetRelationName(onerel), StatisticRelationName) == 0)
{ {
relation_close(onerel, AccessShareLock); relation_close(onerel, AccessShareLock);
return; return;
...@@ -1091,7 +1089,7 @@ update_attstats(Oid relid, int natts, VacAttrStats **vacattrstats) ...@@ -1091,7 +1089,7 @@ update_attstats(Oid relid, int natts, VacAttrStats **vacattrstats)
if (natts <= 0) if (natts <= 0)
return; /* nothing to do */ return; /* nothing to do */
sd = heap_openr(StatisticRelationName, RowExclusiveLock); sd = heap_open(StatisticRelationId, RowExclusiveLock);
for (attno = 0; attno < natts; attno++) for (attno = 0; attno < natts; attno++)
{ {
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/async.c,v 1.120 2005/03/20 23:40:24 neilc Exp $ * $PostgreSQL: pgsql/src/backend/commands/async.c,v 1.121 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -79,7 +79,6 @@ ...@@ -79,7 +79,6 @@
#include <netinet/in.h> #include <netinet/in.h>
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/pg_listener.h" #include "catalog/pg_listener.h"
#include "commands/async.h" #include "commands/async.h"
#include "libpq/libpq.h" #include "libpq/libpq.h"
...@@ -205,7 +204,7 @@ Async_Listen(char *relname, int pid) ...@@ -205,7 +204,7 @@ Async_Listen(char *relname, int pid)
if (Trace_notify) if (Trace_notify)
elog(DEBUG1, "Async_Listen(%s,%d)", relname, pid); elog(DEBUG1, "Async_Listen(%s,%d)", relname, pid);
lRel = heap_openr(ListenerRelationName, ExclusiveLock); lRel = heap_open(ListenerRelationId, ExclusiveLock);
/* Detect whether we are already listening on this relname */ /* Detect whether we are already listening on this relname */
scan = heap_beginscan(lRel, SnapshotNow, 0, NULL); scan = heap_beginscan(lRel, SnapshotNow, 0, NULL);
...@@ -299,7 +298,7 @@ Async_Unlisten(char *relname, int pid) ...@@ -299,7 +298,7 @@ Async_Unlisten(char *relname, int pid)
if (Trace_notify) if (Trace_notify)
elog(DEBUG1, "Async_Unlisten(%s,%d)", relname, pid); elog(DEBUG1, "Async_Unlisten(%s,%d)", relname, pid);
lRel = heap_openr(ListenerRelationName, ExclusiveLock); lRel = heap_open(ListenerRelationId, ExclusiveLock);
scan = heap_beginscan(lRel, SnapshotNow, 0, NULL); scan = heap_beginscan(lRel, SnapshotNow, 0, NULL);
while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL) while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL)
...@@ -357,7 +356,7 @@ Async_UnlistenAll(void) ...@@ -357,7 +356,7 @@ Async_UnlistenAll(void)
if (Trace_notify) if (Trace_notify)
elog(DEBUG1, "Async_UnlistenAll"); elog(DEBUG1, "Async_UnlistenAll");
lRel = heap_openr(ListenerRelationName, ExclusiveLock); lRel = heap_open(ListenerRelationId, ExclusiveLock);
tdesc = RelationGetDescr(lRel); tdesc = RelationGetDescr(lRel);
/* Find and delete all entries with my listenerPID */ /* Find and delete all entries with my listenerPID */
...@@ -466,7 +465,7 @@ AtCommit_Notify(void) ...@@ -466,7 +465,7 @@ AtCommit_Notify(void)
value[0] = value[1] = value[2] = (Datum) 0; value[0] = value[1] = value[2] = (Datum) 0;
value[Anum_pg_listener_notify - 1] = Int32GetDatum(MyProcPid); value[Anum_pg_listener_notify - 1] = Int32GetDatum(MyProcPid);
lRel = heap_openr(ListenerRelationName, ExclusiveLock); lRel = heap_open(ListenerRelationId, ExclusiveLock);
tdesc = RelationGetDescr(lRel); tdesc = RelationGetDescr(lRel);
scan = heap_beginscan(lRel, SnapshotNow, 0, NULL); scan = heap_beginscan(lRel, SnapshotNow, 0, NULL);
...@@ -902,7 +901,7 @@ ProcessIncomingNotify(void) ...@@ -902,7 +901,7 @@ ProcessIncomingNotify(void)
StartTransactionCommand(); StartTransactionCommand();
lRel = heap_openr(ListenerRelationName, ExclusiveLock); lRel = heap_open(ListenerRelationId, ExclusiveLock);
tdesc = RelationGetDescr(lRel); tdesc = RelationGetDescr(lRel);
/* Scan only entries with my listenerPID */ /* Scan only entries with my listenerPID */
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/cluster.c,v 1.135 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/cluster.c,v 1.136 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -20,7 +20,6 @@ ...@@ -20,7 +20,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/heap.h" #include "catalog/heap.h"
#include "catalog/index.h" #include "catalog/index.h"
...@@ -434,7 +433,7 @@ mark_index_clustered(Relation rel, Oid indexOid) ...@@ -434,7 +433,7 @@ mark_index_clustered(Relation rel, Oid indexOid)
/* /*
* Check each index of the relation and set/clear the bit as needed. * Check each index of the relation and set/clear the bit as needed.
*/ */
pg_index = heap_openr(IndexRelationName, RowExclusiveLock); pg_index = heap_open(IndexRelationId, RowExclusiveLock);
foreach(index, RelationGetIndexList(rel)) foreach(index, RelationGetIndexList(rel))
{ {
...@@ -719,7 +718,7 @@ swap_relation_files(Oid r1, Oid r2) ...@@ -719,7 +718,7 @@ swap_relation_files(Oid r1, Oid r2)
CatalogIndexState indstate; CatalogIndexState indstate;
/* We need writable copies of both pg_class tuples. */ /* We need writable copies of both pg_class tuples. */
relRelation = heap_openr(RelationRelationName, RowExclusiveLock); relRelation = heap_open(RelationRelationId, RowExclusiveLock);
reltup1 = SearchSysCacheCopy(RELOID, reltup1 = SearchSysCacheCopy(RELOID,
ObjectIdGetDatum(r1), ObjectIdGetDatum(r1),
...@@ -883,7 +882,7 @@ get_tables_to_cluster(MemoryContext cluster_context) ...@@ -883,7 +882,7 @@ get_tables_to_cluster(MemoryContext cluster_context)
* ever have indisclustered set, because CLUSTER will refuse to set it * ever have indisclustered set, because CLUSTER will refuse to set it
* when called with one of them as argument. * when called with one of them as argument.
*/ */
indRelation = relation_openr(IndexRelationName, AccessShareLock); indRelation = heap_open(IndexRelationId, AccessShareLock);
ScanKeyInit(&entry, ScanKeyInit(&entry,
Anum_pg_index_indisclustered, Anum_pg_index_indisclustered,
BTEqualStrategyNumber, F_BOOLEQ, BTEqualStrategyNumber, F_BOOLEQ,
......
This diff is collapsed.
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/conversioncmds.c,v 1.16 2004/12/31 21:59:41 pgsql Exp $ * $PostgreSQL: pgsql/src/backend/commands/conversioncmds.c,v 1.17 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -17,7 +17,6 @@ ...@@ -17,7 +17,6 @@
#include "catalog/pg_conversion.h" #include "catalog/pg_conversion.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
...@@ -124,7 +123,7 @@ RenameConversion(List *name, const char *newname) ...@@ -124,7 +123,7 @@ RenameConversion(List *name, const char *newname)
Relation rel; Relation rel;
AclResult aclresult; AclResult aclresult;
rel = heap_openr(ConversionRelationName, RowExclusiveLock); rel = heap_open(ConversionRelationId, RowExclusiveLock);
conversionOid = FindConversionByName(name); conversionOid = FindConversionByName(name);
if (!OidIsValid(conversionOid)) if (!OidIsValid(conversionOid))
...@@ -183,7 +182,7 @@ AlterConversionOwner(List *name, AclId newOwnerSysId) ...@@ -183,7 +182,7 @@ AlterConversionOwner(List *name, AclId newOwnerSysId)
Relation rel; Relation rel;
Form_pg_conversion convForm; Form_pg_conversion convForm;
rel = heap_openr(ConversionRelationName, RowExclusiveLock); rel = heap_open(ConversionRelationId, RowExclusiveLock);
conversionOid = FindConversionByName(name); conversionOid = FindConversionByName(name);
if (!OidIsValid(conversionOid)) if (!OidIsValid(conversionOid))
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/copy.c,v 1.239 2005/03/25 21:57:57 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/copy.c,v 1.240 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -22,7 +22,6 @@ ...@@ -22,7 +22,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "access/printtup.h" #include "access/printtup.h"
#include "catalog/catname.h"
#include "catalog/index.h" #include "catalog/index.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_index.h" #include "catalog/pg_index.h"
......
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/dbcommands.c,v 1.155 2005/03/23 00:03:28 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/dbcommands.c,v 1.156 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -27,7 +27,6 @@ ...@@ -27,7 +27,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/pg_database.h" #include "catalog/pg_database.h"
#include "catalog/pg_shadow.h" #include "catalog/pg_shadow.h"
...@@ -364,7 +363,7 @@ createdb(const CreatedbStmt *stmt) ...@@ -364,7 +363,7 @@ createdb(const CreatedbStmt *stmt)
* Iterate through all tablespaces of the template database, and copy * Iterate through all tablespaces of the template database, and copy
* each one to the new database. * each one to the new database.
*/ */
rel = heap_openr(TableSpaceRelationName, AccessShareLock); rel = heap_open(TableSpaceRelationId, AccessShareLock);
scan = heap_beginscan(rel, SnapshotNow, 0, NULL); scan = heap_beginscan(rel, SnapshotNow, 0, NULL);
while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL) while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL)
{ {
...@@ -459,7 +458,7 @@ createdb(const CreatedbStmt *stmt) ...@@ -459,7 +458,7 @@ createdb(const CreatedbStmt *stmt)
/* /*
* Now OK to grab exclusive lock on pg_database. * Now OK to grab exclusive lock on pg_database.
*/ */
pg_database_rel = heap_openr(DatabaseRelationName, ExclusiveLock); pg_database_rel = heap_open(DatabaseRelationId, ExclusiveLock);
/* Check to see if someone else created same DB name meanwhile. */ /* Check to see if someone else created same DB name meanwhile. */
if (get_db_info(dbname, NULL, NULL, NULL, if (get_db_info(dbname, NULL, NULL, NULL,
...@@ -557,7 +556,7 @@ dropdb(const char *dbname) ...@@ -557,7 +556,7 @@ dropdb(const char *dbname)
* since ReverifyMyDatabase takes RowShareLock. This allows ordinary * since ReverifyMyDatabase takes RowShareLock. This allows ordinary
* readers of pg_database to proceed in parallel. * readers of pg_database to proceed in parallel.
*/ */
pgdbrel = heap_openr(DatabaseRelationName, ExclusiveLock); pgdbrel = heap_open(DatabaseRelationId, ExclusiveLock);
if (!get_db_info(dbname, &db_id, &db_owner, NULL, if (!get_db_info(dbname, &db_id, &db_owner, NULL,
&db_istemplate, NULL, NULL, NULL, NULL, NULL)) &db_istemplate, NULL, NULL, NULL, NULL, NULL))
...@@ -596,7 +595,7 @@ dropdb(const char *dbname) ...@@ -596,7 +595,7 @@ dropdb(const char *dbname)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(db_id)); ObjectIdGetDatum(db_id));
pgdbscan = systable_beginscan(pgdbrel, DatabaseOidIndex, true, pgdbscan = systable_beginscan(pgdbrel, DatabaseOidIndexId, true,
SnapshotNow, 1, &key); SnapshotNow, 1, &key);
tup = systable_getnext(pgdbscan); tup = systable_getnext(pgdbscan);
...@@ -621,7 +620,7 @@ dropdb(const char *dbname) ...@@ -621,7 +620,7 @@ dropdb(const char *dbname)
* NOTE: this is probably dead code since any such comments should have * NOTE: this is probably dead code since any such comments should have
* been in that database, not mine. * been in that database, not mine.
*/ */
DeleteComments(db_id, RelationGetRelid(pgdbrel), 0); DeleteComments(db_id, DatabaseRelationId, 0);
/* /*
* Drop pages for this database that are in the shared buffer cache. * Drop pages for this database that are in the shared buffer cache.
...@@ -676,13 +675,13 @@ RenameDatabase(const char *oldname, const char *newname) ...@@ -676,13 +675,13 @@ RenameDatabase(const char *oldname, const char *newname)
* Obtain ExclusiveLock so that no new session gets started * Obtain ExclusiveLock so that no new session gets started
* while the rename is in progress. * while the rename is in progress.
*/ */
rel = heap_openr(DatabaseRelationName, ExclusiveLock); rel = heap_open(DatabaseRelationId, ExclusiveLock);
ScanKeyInit(&key, ScanKeyInit(&key,
Anum_pg_database_datname, Anum_pg_database_datname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
NameGetDatum(oldname)); NameGetDatum(oldname));
scan = systable_beginscan(rel, DatabaseNameIndex, true, scan = systable_beginscan(rel, DatabaseNameIndexId, true,
SnapshotNow, 1, &key); SnapshotNow, 1, &key);
tup = systable_getnext(scan); tup = systable_getnext(scan);
...@@ -717,7 +716,7 @@ RenameDatabase(const char *oldname, const char *newname) ...@@ -717,7 +716,7 @@ RenameDatabase(const char *oldname, const char *newname)
Anum_pg_database_datname, Anum_pg_database_datname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
NameGetDatum(newname)); NameGetDatum(newname));
scan2 = systable_beginscan(rel, DatabaseNameIndex, true, scan2 = systable_beginscan(rel, DatabaseNameIndexId, true,
SnapshotNow, 1, &key2); SnapshotNow, 1, &key2);
if (HeapTupleIsValid(systable_getnext(scan2))) if (HeapTupleIsValid(systable_getnext(scan2)))
ereport(ERROR, ereport(ERROR,
...@@ -776,12 +775,12 @@ AlterDatabaseSet(AlterDatabaseSetStmt *stmt) ...@@ -776,12 +775,12 @@ AlterDatabaseSet(AlterDatabaseSetStmt *stmt)
* We don't need ExclusiveLock since we aren't updating the * We don't need ExclusiveLock since we aren't updating the
* flat file. * flat file.
*/ */
rel = heap_openr(DatabaseRelationName, RowExclusiveLock); rel = heap_open(DatabaseRelationId, RowExclusiveLock);
ScanKeyInit(&scankey, ScanKeyInit(&scankey,
Anum_pg_database_datname, Anum_pg_database_datname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
NameGetDatum(stmt->dbname)); NameGetDatum(stmt->dbname));
scan = systable_beginscan(rel, DatabaseNameIndex, true, scan = systable_beginscan(rel, DatabaseNameIndexId, true,
SnapshotNow, 1, &scankey); SnapshotNow, 1, &scankey);
tuple = systable_getnext(scan); tuple = systable_getnext(scan);
if (!HeapTupleIsValid(tuple)) if (!HeapTupleIsValid(tuple))
...@@ -861,12 +860,12 @@ AlterDatabaseOwner(const char *dbname, AclId newOwnerSysId) ...@@ -861,12 +860,12 @@ AlterDatabaseOwner(const char *dbname, AclId newOwnerSysId)
* We don't need ExclusiveLock since we aren't updating the * We don't need ExclusiveLock since we aren't updating the
* flat file. * flat file.
*/ */
rel = heap_openr(DatabaseRelationName, RowExclusiveLock); rel = heap_open(DatabaseRelationId, RowExclusiveLock);
ScanKeyInit(&scankey, ScanKeyInit(&scankey,
Anum_pg_database_datname, Anum_pg_database_datname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
NameGetDatum(dbname)); NameGetDatum(dbname));
scan = systable_beginscan(rel, DatabaseNameIndex, true, scan = systable_beginscan(rel, DatabaseNameIndexId, true,
SnapshotNow, 1, &scankey); SnapshotNow, 1, &scankey);
tuple = systable_getnext(scan); tuple = systable_getnext(scan);
if (!HeapTupleIsValid(tuple)) if (!HeapTupleIsValid(tuple))
...@@ -958,14 +957,14 @@ get_db_info(const char *name, Oid *dbIdP, int4 *ownerIdP, ...@@ -958,14 +957,14 @@ get_db_info(const char *name, Oid *dbIdP, int4 *ownerIdP,
AssertArg(name); AssertArg(name);
/* Caller may wish to grab a better lock on pg_database beforehand... */ /* Caller may wish to grab a better lock on pg_database beforehand... */
relation = heap_openr(DatabaseRelationName, AccessShareLock); relation = heap_open(DatabaseRelationId, AccessShareLock);
ScanKeyInit(&scanKey, ScanKeyInit(&scanKey,
Anum_pg_database_datname, Anum_pg_database_datname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
NameGetDatum(name)); NameGetDatum(name));
scan = systable_beginscan(relation, DatabaseNameIndex, true, scan = systable_beginscan(relation, DatabaseNameIndexId, true,
SnapshotNow, 1, &scanKey); SnapshotNow, 1, &scanKey);
tuple = systable_getnext(scan); tuple = systable_getnext(scan);
...@@ -1041,7 +1040,7 @@ remove_dbtablespaces(Oid db_id) ...@@ -1041,7 +1040,7 @@ remove_dbtablespaces(Oid db_id)
HeapScanDesc scan; HeapScanDesc scan;
HeapTuple tuple; HeapTuple tuple;
rel = heap_openr(TableSpaceRelationName, AccessShareLock); rel = heap_open(TableSpaceRelationId, AccessShareLock);
scan = heap_beginscan(rel, SnapshotNow, 0, NULL); scan = heap_beginscan(rel, SnapshotNow, 0, NULL);
while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL) while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL)
{ {
...@@ -1108,12 +1107,12 @@ get_database_oid(const char *dbname) ...@@ -1108,12 +1107,12 @@ get_database_oid(const char *dbname)
Oid oid; Oid oid;
/* There's no syscache for pg_database, so must look the hard way */ /* There's no syscache for pg_database, so must look the hard way */
pg_database = heap_openr(DatabaseRelationName, AccessShareLock); pg_database = heap_open(DatabaseRelationId, AccessShareLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
Anum_pg_database_datname, Anum_pg_database_datname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
CStringGetDatum(dbname)); CStringGetDatum(dbname));
scan = systable_beginscan(pg_database, DatabaseNameIndex, true, scan = systable_beginscan(pg_database, DatabaseNameIndexId, true,
SnapshotNow, 1, entry); SnapshotNow, 1, entry);
dbtuple = systable_getnext(scan); dbtuple = systable_getnext(scan);
...@@ -1148,12 +1147,12 @@ get_database_name(Oid dbid) ...@@ -1148,12 +1147,12 @@ get_database_name(Oid dbid)
char *result; char *result;
/* There's no syscache for pg_database, so must look the hard way */ /* There's no syscache for pg_database, so must look the hard way */
pg_database = heap_openr(DatabaseRelationName, AccessShareLock); pg_database = heap_open(DatabaseRelationId, AccessShareLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(dbid)); ObjectIdGetDatum(dbid));
scan = systable_beginscan(pg_database, DatabaseOidIndex, true, scan = systable_beginscan(pg_database, DatabaseOidIndexId, true,
SnapshotNow, 1, entry); SnapshotNow, 1, entry);
dbtuple = systable_getnext(scan); dbtuple = systable_getnext(scan);
......
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/functioncmds.c,v 1.60 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/functioncmds.c,v 1.61 2005/04/14 20:03:23 tgl Exp $
* *
* DESCRIPTION * DESCRIPTION
* These routines take the parse tree and pick out the * These routines take the parse tree and pick out the
...@@ -34,10 +34,10 @@ ...@@ -34,10 +34,10 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_aggregate.h"
#include "catalog/pg_cast.h" #include "catalog/pg_cast.h"
#include "catalog/pg_language.h" #include "catalog/pg_language.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
...@@ -742,7 +742,7 @@ RemoveFunctionById(Oid funcOid) ...@@ -742,7 +742,7 @@ RemoveFunctionById(Oid funcOid)
/* /*
* Delete the pg_proc tuple. * Delete the pg_proc tuple.
*/ */
relation = heap_openr(ProcedureRelationName, RowExclusiveLock); relation = heap_open(ProcedureRelationId, RowExclusiveLock);
tup = SearchSysCache(PROCOID, tup = SearchSysCache(PROCOID,
ObjectIdGetDatum(funcOid), ObjectIdGetDatum(funcOid),
...@@ -763,7 +763,7 @@ RemoveFunctionById(Oid funcOid) ...@@ -763,7 +763,7 @@ RemoveFunctionById(Oid funcOid)
*/ */
if (isagg) if (isagg)
{ {
relation = heap_openr(AggregateRelationName, RowExclusiveLock); relation = heap_open(AggregateRelationId, RowExclusiveLock);
tup = SearchSysCache(AGGFNOID, tup = SearchSysCache(AGGFNOID,
ObjectIdGetDatum(funcOid), ObjectIdGetDatum(funcOid),
...@@ -793,7 +793,7 @@ RenameFunction(List *name, List *argtypes, const char *newname) ...@@ -793,7 +793,7 @@ RenameFunction(List *name, List *argtypes, const char *newname)
Relation rel; Relation rel;
AclResult aclresult; AclResult aclresult;
rel = heap_openr(ProcedureRelationName, RowExclusiveLock); rel = heap_open(ProcedureRelationId, RowExclusiveLock);
procOid = LookupFuncNameTypeNames(name, argtypes, false); procOid = LookupFuncNameTypeNames(name, argtypes, false);
...@@ -860,7 +860,7 @@ AlterFunctionOwner(List *name, List *argtypes, AclId newOwnerSysId) ...@@ -860,7 +860,7 @@ AlterFunctionOwner(List *name, List *argtypes, AclId newOwnerSysId)
Form_pg_proc procForm; Form_pg_proc procForm;
Relation rel; Relation rel;
rel = heap_openr(ProcedureRelationName, RowExclusiveLock); rel = heap_open(ProcedureRelationId, RowExclusiveLock);
procOid = LookupFuncNameTypeNames(name, argtypes, false); procOid = LookupFuncNameTypeNames(name, argtypes, false);
...@@ -948,7 +948,7 @@ AlterFunction(AlterFunctionStmt *stmt) ...@@ -948,7 +948,7 @@ AlterFunction(AlterFunctionStmt *stmt)
DefElem *strict_item = NULL; DefElem *strict_item = NULL;
DefElem *security_def_item = NULL; DefElem *security_def_item = NULL;
rel = heap_openr(ProcedureRelationName, RowExclusiveLock); rel = heap_open(ProcedureRelationId, RowExclusiveLock);
funcOid = LookupFuncNameTypeNames(stmt->func->funcname, funcOid = LookupFuncNameTypeNames(stmt->func->funcname,
stmt->func->funcargs, stmt->func->funcargs,
...@@ -1014,7 +1014,7 @@ SetFunctionReturnType(Oid funcOid, Oid newRetType) ...@@ -1014,7 +1014,7 @@ SetFunctionReturnType(Oid funcOid, Oid newRetType)
HeapTuple tup; HeapTuple tup;
Form_pg_proc procForm; Form_pg_proc procForm;
pg_proc_rel = heap_openr(ProcedureRelationName, RowExclusiveLock); pg_proc_rel = heap_open(ProcedureRelationId, RowExclusiveLock);
tup = SearchSysCacheCopy(PROCOID, tup = SearchSysCacheCopy(PROCOID,
ObjectIdGetDatum(funcOid), ObjectIdGetDatum(funcOid),
...@@ -1050,7 +1050,7 @@ SetFunctionArgType(Oid funcOid, int argIndex, Oid newArgType) ...@@ -1050,7 +1050,7 @@ SetFunctionArgType(Oid funcOid, int argIndex, Oid newArgType)
HeapTuple tup; HeapTuple tup;
Form_pg_proc procForm; Form_pg_proc procForm;
pg_proc_rel = heap_openr(ProcedureRelationName, RowExclusiveLock); pg_proc_rel = heap_open(ProcedureRelationId, RowExclusiveLock);
tup = SearchSysCacheCopy(PROCOID, tup = SearchSysCacheCopy(PROCOID,
ObjectIdGetDatum(funcOid), ObjectIdGetDatum(funcOid),
...@@ -1266,7 +1266,7 @@ CreateCast(CreateCastStmt *stmt) ...@@ -1266,7 +1266,7 @@ CreateCast(CreateCastStmt *stmt)
break; break;
} }
relation = heap_openr(CastRelationName, RowExclusiveLock); relation = heap_open(CastRelationId, RowExclusiveLock);
/* /*
* Check for duplicate. This is just to give a friendly error * Check for duplicate. This is just to give a friendly error
...@@ -1299,7 +1299,7 @@ CreateCast(CreateCastStmt *stmt) ...@@ -1299,7 +1299,7 @@ CreateCast(CreateCastStmt *stmt)
CatalogUpdateIndexes(relation, tuple); CatalogUpdateIndexes(relation, tuple);
/* make dependency entries */ /* make dependency entries */
myself.classId = RelationGetRelid(relation); myself.classId = CastRelationId;
myself.objectId = HeapTupleGetOid(tuple); myself.objectId = HeapTupleGetOid(tuple);
myself.objectSubId = 0; myself.objectSubId = 0;
...@@ -1379,7 +1379,7 @@ DropCast(DropCastStmt *stmt) ...@@ -1379,7 +1379,7 @@ DropCast(DropCastStmt *stmt)
/* /*
* Do the deletion * Do the deletion
*/ */
object.classId = get_system_catalog_relid(CastRelationName); object.classId = CastRelationId;
object.objectId = HeapTupleGetOid(tuple); object.objectId = HeapTupleGetOid(tuple);
object.objectSubId = 0; object.objectSubId = 0;
...@@ -1397,13 +1397,13 @@ DropCastById(Oid castOid) ...@@ -1397,13 +1397,13 @@ DropCastById(Oid castOid)
SysScanDesc scan; SysScanDesc scan;
HeapTuple tuple; HeapTuple tuple;
relation = heap_openr(CastRelationName, RowExclusiveLock); relation = heap_open(CastRelationId, RowExclusiveLock);
ScanKeyInit(&scankey, ScanKeyInit(&scankey,
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(castOid)); ObjectIdGetDatum(castOid));
scan = systable_beginscan(relation, CastOidIndex, true, scan = systable_beginscan(relation, CastOidIndexId, true,
SnapshotNow, 1, &scankey); SnapshotNow, 1, &scankey);
tuple = systable_getnext(scan); tuple = systable_getnext(scan);
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.129 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.130 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -17,7 +17,6 @@ ...@@ -17,7 +17,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/heap.h" #include "catalog/heap.h"
#include "catalog/index.h" #include "catalog/index.h"
...@@ -1039,7 +1038,7 @@ ReindexDatabase(const char *dbname, bool force /* currently unused */ , ...@@ -1039,7 +1038,7 @@ ReindexDatabase(const char *dbname, bool force /* currently unused */ ,
* We only consider plain relations here (toast rels will be processed * We only consider plain relations here (toast rels will be processed
* indirectly by reindex_relation). * indirectly by reindex_relation).
*/ */
relationRelation = heap_openr(RelationRelationName, AccessShareLock); relationRelation = heap_open(RelationRelationId, AccessShareLock);
scan = heap_beginscan(relationRelation, SnapshotNow, 0, NULL); scan = heap_beginscan(relationRelation, SnapshotNow, 0, NULL);
while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL) while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL)
{ {
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/opclasscmds.c,v 1.31 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/opclasscmds.c,v 1.32 2005/04/14 20:03:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -17,13 +17,13 @@ ...@@ -17,13 +17,13 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_am.h" #include "catalog/pg_am.h"
#include "catalog/pg_amop.h" #include "catalog/pg_amop.h"
#include "catalog/pg_amproc.h" #include "catalog/pg_amproc.h"
#include "catalog/pg_namespace.h"
#include "catalog/pg_opclass.h" #include "catalog/pg_opclass.h"
#include "catalog/pg_operator.h" #include "catalog/pg_operator.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
...@@ -255,7 +255,7 @@ DefineOpClass(CreateOpClassStmt *stmt) ...@@ -255,7 +255,7 @@ DefineOpClass(CreateOpClassStmt *stmt)
} }
} }
rel = heap_openr(OperatorClassRelationName, RowExclusiveLock); rel = heap_open(OperatorClassRelationId, RowExclusiveLock);
/* /*
* Make sure there is no existing opclass of this name (this is just * Make sure there is no existing opclass of this name (this is just
...@@ -287,7 +287,7 @@ DefineOpClass(CreateOpClassStmt *stmt) ...@@ -287,7 +287,7 @@ DefineOpClass(CreateOpClassStmt *stmt)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(amoid)); ObjectIdGetDatum(amoid));
scan = systable_beginscan(rel, OpclassAmNameNspIndex, true, scan = systable_beginscan(rel, OpclassAmNameNspIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
while (HeapTupleIsValid(tup = systable_getnext(scan))) while (HeapTupleIsValid(tup = systable_getnext(scan)))
...@@ -345,12 +345,12 @@ DefineOpClass(CreateOpClassStmt *stmt) ...@@ -345,12 +345,12 @@ DefineOpClass(CreateOpClassStmt *stmt)
* Create dependencies. Note: we do not create a dependency link to * Create dependencies. Note: we do not create a dependency link to
* the AM, because we don't currently support DROP ACCESS METHOD. * the AM, because we don't currently support DROP ACCESS METHOD.
*/ */
myself.classId = RelationGetRelid(rel); myself.classId = OperatorClassRelationId;
myself.objectId = opclassoid; myself.objectId = opclassoid;
myself.objectSubId = 0; myself.objectSubId = 0;
/* dependency on namespace */ /* dependency on namespace */
referenced.classId = get_system_catalog_relid(NamespaceRelationName); referenced.classId = NamespaceRelationId;
referenced.objectId = namespaceoid; referenced.objectId = namespaceoid;
referenced.objectSubId = 0; referenced.objectSubId = 0;
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
...@@ -371,11 +371,11 @@ DefineOpClass(CreateOpClassStmt *stmt) ...@@ -371,11 +371,11 @@ DefineOpClass(CreateOpClassStmt *stmt)
} }
/* dependencies on operators */ /* dependencies on operators */
referenced.classId = get_system_catalog_relid(OperatorRelationName);
foreach(l, operators) foreach(l, operators)
{ {
OpClassMember *op = (OpClassMember *) lfirst(l); OpClassMember *op = (OpClassMember *) lfirst(l);
referenced.classId = OperatorRelationId;
referenced.objectId = op->object; referenced.objectId = op->object;
referenced.objectSubId = 0; referenced.objectSubId = 0;
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
...@@ -547,7 +547,7 @@ storeOperators(Oid opclassoid, List *operators) ...@@ -547,7 +547,7 @@ storeOperators(Oid opclassoid, List *operators)
ListCell *l; ListCell *l;
int i; int i;
rel = heap_openr(AccessMethodOperatorRelationName, RowExclusiveLock); rel = heap_open(AccessMethodOperatorRelationId, RowExclusiveLock);
foreach(l, operators) foreach(l, operators)
{ {
...@@ -591,7 +591,7 @@ storeProcedures(Oid opclassoid, List *procedures) ...@@ -591,7 +591,7 @@ storeProcedures(Oid opclassoid, List *procedures)
ListCell *l; ListCell *l;
int i; int i;
rel = heap_openr(AccessMethodProcedureRelationName, RowExclusiveLock); rel = heap_open(AccessMethodProcedureRelationId, RowExclusiveLock);
foreach(l, procedures) foreach(l, procedures)
{ {
...@@ -701,7 +701,7 @@ RemoveOpClass(RemoveOpClassStmt *stmt) ...@@ -701,7 +701,7 @@ RemoveOpClass(RemoveOpClassStmt *stmt)
/* /*
* Do the deletion * Do the deletion
*/ */
object.classId = get_system_catalog_relid(OperatorClassRelationName); object.classId = OperatorClassRelationId;
object.objectId = opcID; object.objectId = opcID;
object.objectSubId = 0; object.objectSubId = 0;
...@@ -722,7 +722,7 @@ RemoveOpClassById(Oid opclassOid) ...@@ -722,7 +722,7 @@ RemoveOpClassById(Oid opclassOid)
/* /*
* First remove the pg_opclass entry itself. * First remove the pg_opclass entry itself.
*/ */
rel = heap_openr(OperatorClassRelationName, RowExclusiveLock); rel = heap_open(OperatorClassRelationId, RowExclusiveLock);
tup = SearchSysCache(CLAOID, tup = SearchSysCache(CLAOID,
ObjectIdGetDatum(opclassOid), ObjectIdGetDatum(opclassOid),
...@@ -744,9 +744,9 @@ RemoveOpClassById(Oid opclassOid) ...@@ -744,9 +744,9 @@ RemoveOpClassById(Oid opclassOid)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(opclassOid)); ObjectIdGetDatum(opclassOid));
rel = heap_openr(AccessMethodOperatorRelationName, RowExclusiveLock); rel = heap_open(AccessMethodOperatorRelationId, RowExclusiveLock);
scan = systable_beginscan(rel, AccessMethodStrategyIndex, true, scan = systable_beginscan(rel, AccessMethodStrategyIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
while (HeapTupleIsValid(tup = systable_getnext(scan))) while (HeapTupleIsValid(tup = systable_getnext(scan)))
...@@ -763,9 +763,9 @@ RemoveOpClassById(Oid opclassOid) ...@@ -763,9 +763,9 @@ RemoveOpClassById(Oid opclassOid)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(opclassOid)); ObjectIdGetDatum(opclassOid));
rel = heap_openr(AccessMethodProcedureRelationName, RowExclusiveLock); rel = heap_open(AccessMethodProcedureRelationId, RowExclusiveLock);
scan = systable_beginscan(rel, AccessMethodProcedureIndex, true, scan = systable_beginscan(rel, AccessMethodProcedureIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
while (HeapTupleIsValid(tup = systable_getnext(scan))) while (HeapTupleIsValid(tup = systable_getnext(scan)))
...@@ -800,7 +800,7 @@ RenameOpClass(List *name, const char *access_method, const char *newname) ...@@ -800,7 +800,7 @@ RenameOpClass(List *name, const char *access_method, const char *newname)
errmsg("access method \"%s\" does not exist", errmsg("access method \"%s\" does not exist",
access_method))); access_method)));
rel = heap_openr(OperatorClassRelationName, RowExclusiveLock); rel = heap_open(OperatorClassRelationId, RowExclusiveLock);
/* /*
* Look up the opclass * Look up the opclass
...@@ -900,7 +900,7 @@ AlterOpClassOwner(List *name, const char *access_method, AclId newOwnerSysId) ...@@ -900,7 +900,7 @@ AlterOpClassOwner(List *name, const char *access_method, AclId newOwnerSysId)
errmsg("access method \"%s\" does not exist", errmsg("access method \"%s\" does not exist",
access_method))); access_method)));
rel = heap_openr(OperatorClassRelationName, RowExclusiveLock); rel = heap_open(OperatorClassRelationId, RowExclusiveLock);
/* /*
* Look up the opclass * Look up the opclass
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/operatorcmds.c,v 1.20 2004/12/31 21:59:41 pgsql Exp $ * $PostgreSQL: pgsql/src/backend/commands/operatorcmds.c,v 1.21 2005/04/14 20:03:24 tgl Exp $
* *
* DESCRIPTION * DESCRIPTION
* The "DefineFoo" routines take the parse tree and pick out the * The "DefineFoo" routines take the parse tree and pick out the
...@@ -35,7 +35,6 @@ ...@@ -35,7 +35,6 @@
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
...@@ -234,7 +233,7 @@ RemoveOperator(RemoveOperStmt *stmt) ...@@ -234,7 +233,7 @@ RemoveOperator(RemoveOperStmt *stmt)
/* /*
* Do the deletion * Do the deletion
*/ */
object.classId = get_system_catalog_relid(OperatorRelationName); object.classId = OperatorRelationId;
object.objectId = operOid; object.objectId = operOid;
object.objectSubId = 0; object.objectSubId = 0;
...@@ -250,7 +249,7 @@ RemoveOperatorById(Oid operOid) ...@@ -250,7 +249,7 @@ RemoveOperatorById(Oid operOid)
Relation relation; Relation relation;
HeapTuple tup; HeapTuple tup;
relation = heap_openr(OperatorRelationName, RowExclusiveLock); relation = heap_open(OperatorRelationId, RowExclusiveLock);
tup = SearchSysCache(OPEROID, tup = SearchSysCache(OPEROID,
ObjectIdGetDatum(operOid), ObjectIdGetDatum(operOid),
...@@ -277,7 +276,7 @@ AlterOperatorOwner(List *name, TypeName *typeName1, TypeName *typeName2, ...@@ -277,7 +276,7 @@ AlterOperatorOwner(List *name, TypeName *typeName1, TypeName *typeName2,
Relation rel; Relation rel;
Form_pg_operator oprForm; Form_pg_operator oprForm;
rel = heap_openr(OperatorRelationName, RowExclusiveLock); rel = heap_open(OperatorRelationId, RowExclusiveLock);
operOid = LookupOperNameTypeNames(name, typeName1, typeName2, operOid = LookupOperNameTypeNames(name, typeName1, typeName2,
false); false);
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/proclang.c,v 1.59 2005/04/14 01:38:16 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/proclang.c,v 1.60 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include <ctype.h> #include <ctype.h>
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
...@@ -132,7 +131,7 @@ CreateProceduralLanguage(CreatePLangStmt *stmt) ...@@ -132,7 +131,7 @@ CreateProceduralLanguage(CreatePLangStmt *stmt)
values[i++] = ObjectIdGetDatum(valProcOid); /* lanvalidator */ values[i++] = ObjectIdGetDatum(valProcOid); /* lanvalidator */
nulls[i] = 'n'; /* lanacl */ nulls[i] = 'n'; /* lanacl */
rel = heap_openr(LanguageRelationName, RowExclusiveLock); rel = heap_open(LanguageRelationId, RowExclusiveLock);
tupDesc = rel->rd_att; tupDesc = rel->rd_att;
tup = heap_formtuple(tupDesc, values, nulls); tup = heap_formtuple(tupDesc, values, nulls);
...@@ -144,7 +143,7 @@ CreateProceduralLanguage(CreatePLangStmt *stmt) ...@@ -144,7 +143,7 @@ CreateProceduralLanguage(CreatePLangStmt *stmt)
/* /*
* Create dependencies for language * Create dependencies for language
*/ */
myself.classId = RelationGetRelid(rel); myself.classId = LanguageRelationId;
myself.objectId = HeapTupleGetOid(tup); myself.objectId = HeapTupleGetOid(tup);
myself.objectSubId = 0; myself.objectSubId = 0;
...@@ -200,7 +199,7 @@ DropProceduralLanguage(DropPLangStmt *stmt) ...@@ -200,7 +199,7 @@ DropProceduralLanguage(DropPLangStmt *stmt)
(errcode(ERRCODE_UNDEFINED_OBJECT), (errcode(ERRCODE_UNDEFINED_OBJECT),
errmsg("language \"%s\" does not exist", languageName))); errmsg("language \"%s\" does not exist", languageName)));
object.classId = get_system_catalog_relid(LanguageRelationName); object.classId = LanguageRelationId;
object.objectId = HeapTupleGetOid(langTup); object.objectId = HeapTupleGetOid(langTup);
object.objectSubId = 0; object.objectSubId = 0;
...@@ -221,7 +220,7 @@ DropProceduralLanguageById(Oid langOid) ...@@ -221,7 +220,7 @@ DropProceduralLanguageById(Oid langOid)
Relation rel; Relation rel;
HeapTuple langTup; HeapTuple langTup;
rel = heap_openr(LanguageRelationName, RowExclusiveLock); rel = heap_open(LanguageRelationId, RowExclusiveLock);
langTup = SearchSysCache(LANGOID, langTup = SearchSysCache(LANGOID,
ObjectIdGetDatum(langOid), ObjectIdGetDatum(langOid),
...@@ -245,7 +244,7 @@ RenameLanguage(const char *oldname, const char *newname) ...@@ -245,7 +244,7 @@ RenameLanguage(const char *oldname, const char *newname)
HeapTuple tup; HeapTuple tup;
Relation rel; Relation rel;
rel = heap_openr(LanguageRelationName, RowExclusiveLock); rel = heap_open(LanguageRelationId, RowExclusiveLock);
tup = SearchSysCacheCopy(LANGNAME, tup = SearchSysCacheCopy(LANGNAME,
CStringGetDatum(oldname), CStringGetDatum(oldname),
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/schemacmds.c,v 1.28 2005/01/27 23:23:55 neilc Exp $ * $PostgreSQL: pgsql/src/backend/commands/schemacmds.c,v 1.29 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
...@@ -189,7 +188,7 @@ RemoveSchema(List *names, DropBehavior behavior) ...@@ -189,7 +188,7 @@ RemoveSchema(List *names, DropBehavior behavior)
* Do the deletion. Objects contained in the schema are removed by * Do the deletion. Objects contained in the schema are removed by
* means of their dependency links to the schema. * means of their dependency links to the schema.
*/ */
object.classId = get_system_catalog_relid(NamespaceRelationName); object.classId = NamespaceRelationId;
object.objectId = namespaceId; object.objectId = namespaceId;
object.objectSubId = 0; object.objectSubId = 0;
...@@ -206,7 +205,7 @@ RemoveSchemaById(Oid schemaOid) ...@@ -206,7 +205,7 @@ RemoveSchemaById(Oid schemaOid)
Relation relation; Relation relation;
HeapTuple tup; HeapTuple tup;
relation = heap_openr(NamespaceRelationName, RowExclusiveLock); relation = heap_open(NamespaceRelationId, RowExclusiveLock);
tup = SearchSysCache(NAMESPACEOID, tup = SearchSysCache(NAMESPACEOID,
ObjectIdGetDatum(schemaOid), ObjectIdGetDatum(schemaOid),
...@@ -232,7 +231,7 @@ RenameSchema(const char *oldname, const char *newname) ...@@ -232,7 +231,7 @@ RenameSchema(const char *oldname, const char *newname)
Relation rel; Relation rel;
AclResult aclresult; AclResult aclresult;
rel = heap_openr(NamespaceRelationName, RowExclusiveLock); rel = heap_open(NamespaceRelationId, RowExclusiveLock);
tup = SearchSysCacheCopy(NAMESPACENAME, tup = SearchSysCacheCopy(NAMESPACENAME,
CStringGetDatum(oldname), CStringGetDatum(oldname),
...@@ -287,7 +286,7 @@ AlterSchemaOwner(const char *name, AclId newOwnerSysId) ...@@ -287,7 +286,7 @@ AlterSchemaOwner(const char *name, AclId newOwnerSysId)
Relation rel; Relation rel;
Form_pg_namespace nspForm; Form_pg_namespace nspForm;
rel = heap_openr(NamespaceRelationName, RowExclusiveLock); rel = heap_open(NamespaceRelationId, RowExclusiveLock);
tup = SearchSysCache(NAMESPACENAME, tup = SearchSysCache(NAMESPACENAME,
CStringGetDatum(name), CStringGetDatum(name),
......
This diff is collapsed.
...@@ -37,7 +37,7 @@ ...@@ -37,7 +37,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/tablespace.c,v 1.16 2005/01/27 23:23:55 neilc Exp $ * $PostgreSQL: pgsql/src/backend/commands/tablespace.c,v 1.17 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -50,7 +50,6 @@ ...@@ -50,7 +50,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_namespace.h" #include "catalog/pg_namespace.h"
#include "catalog/pg_tablespace.h" #include "catalog/pg_tablespace.h"
...@@ -125,7 +124,7 @@ TablespaceCreateDbspace(Oid spcNode, Oid dbNode, bool isRedo) ...@@ -125,7 +124,7 @@ TablespaceCreateDbspace(Oid spcNode, Oid dbNode, bool isRedo)
Relation rel; Relation rel;
if (!isRedo) if (!isRedo)
rel = heap_openr(TableSpaceRelationName, ExclusiveLock); rel = heap_open(TableSpaceRelationId, ExclusiveLock);
else else
rel = NULL; rel = NULL;
...@@ -291,7 +290,7 @@ CreateTableSpace(CreateTableSpaceStmt *stmt) ...@@ -291,7 +290,7 @@ CreateTableSpace(CreateTableSpaceStmt *stmt)
* is to lock the proposed tablename against other would-be creators. * is to lock the proposed tablename against other would-be creators.
* The insertion will roll back if we find problems below. * The insertion will roll back if we find problems below.
*/ */
rel = heap_openr(TableSpaceRelationName, RowExclusiveLock); rel = heap_open(TableSpaceRelationId, RowExclusiveLock);
MemSet(nulls, ' ', Natts_pg_tablespace); MemSet(nulls, ' ', Natts_pg_tablespace);
...@@ -407,7 +406,7 @@ DropTableSpace(DropTableSpaceStmt *stmt) ...@@ -407,7 +406,7 @@ DropTableSpace(DropTableSpaceStmt *stmt)
* is trying to do DROP TABLESPACE or TablespaceCreateDbspace * is trying to do DROP TABLESPACE or TablespaceCreateDbspace
* concurrently. * concurrently.
*/ */
rel = heap_openr(TableSpaceRelationName, ExclusiveLock); rel = heap_open(TableSpaceRelationId, ExclusiveLock);
/* /*
* Find the target tuple * Find the target tuple
...@@ -736,7 +735,7 @@ RenameTableSpace(const char *oldname, const char *newname) ...@@ -736,7 +735,7 @@ RenameTableSpace(const char *oldname, const char *newname)
Form_pg_tablespace newform; Form_pg_tablespace newform;
/* Search pg_tablespace */ /* Search pg_tablespace */
rel = heap_openr(TableSpaceRelationName, RowExclusiveLock); rel = heap_open(TableSpaceRelationId, RowExclusiveLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
Anum_pg_tablespace_spcname, Anum_pg_tablespace_spcname,
...@@ -803,7 +802,7 @@ AlterTableSpaceOwner(const char *name, AclId newOwnerSysId) ...@@ -803,7 +802,7 @@ AlterTableSpaceOwner(const char *name, AclId newOwnerSysId)
HeapTuple tup; HeapTuple tup;
/* Search pg_tablespace */ /* Search pg_tablespace */
rel = heap_openr(TableSpaceRelationName, RowExclusiveLock); rel = heap_open(TableSpaceRelationId, RowExclusiveLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
Anum_pg_tablespace_spcname, Anum_pg_tablespace_spcname,
...@@ -952,7 +951,7 @@ get_tablespace_oid(const char *tablespacename) ...@@ -952,7 +951,7 @@ get_tablespace_oid(const char *tablespacename)
ScanKeyData entry[1]; ScanKeyData entry[1];
/* Search pg_tablespace */ /* Search pg_tablespace */
rel = heap_openr(TableSpaceRelationName, AccessShareLock); rel = heap_open(TableSpaceRelationId, AccessShareLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
Anum_pg_tablespace_spcname, Anum_pg_tablespace_spcname,
...@@ -987,7 +986,7 @@ get_tablespace_name(Oid spc_oid) ...@@ -987,7 +986,7 @@ get_tablespace_name(Oid spc_oid)
ScanKeyData entry[1]; ScanKeyData entry[1];
/* Search pg_tablespace */ /* Search pg_tablespace */
rel = heap_openr(TableSpaceRelationName, AccessShareLock); rel = heap_open(TableSpaceRelationId, AccessShareLock);
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.185 2005/04/14 01:38:17 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.186 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -17,7 +17,6 @@ ...@@ -17,7 +17,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/xact.h" #include "access/xact.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
...@@ -252,12 +251,12 @@ CreateTrigger(CreateTrigStmt *stmt, bool forConstraint) ...@@ -252,12 +251,12 @@ CreateTrigger(CreateTrigStmt *stmt, bool forConstraint)
* NOTE that this is cool only because we have AccessExclusiveLock on the * NOTE that this is cool only because we have AccessExclusiveLock on the
* relation, so the trigger set won't be changing underneath us. * relation, so the trigger set won't be changing underneath us.
*/ */
tgrel = heap_openr(TriggerRelationName, RowExclusiveLock); tgrel = heap_open(TriggerRelationId, RowExclusiveLock);
ScanKeyInit(&key, ScanKeyInit(&key,
Anum_pg_trigger_tgrelid, Anum_pg_trigger_tgrelid,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(RelationGetRelid(rel))); ObjectIdGetDatum(RelationGetRelid(rel)));
tgscan = systable_beginscan(tgrel, TriggerRelidNameIndex, true, tgscan = systable_beginscan(tgrel, TriggerRelidNameIndexId, true,
SnapshotNow, 1, &key); SnapshotNow, 1, &key);
while (HeapTupleIsValid(tuple = systable_getnext(tgscan))) while (HeapTupleIsValid(tuple = systable_getnext(tgscan)))
{ {
...@@ -374,7 +373,7 @@ CreateTrigger(CreateTrigStmt *stmt, bool forConstraint) ...@@ -374,7 +373,7 @@ CreateTrigger(CreateTrigStmt *stmt, bool forConstraint)
CatalogUpdateIndexes(tgrel, tuple); CatalogUpdateIndexes(tgrel, tuple);
myself.classId = RelationGetRelid(tgrel); myself.classId = TriggerRelationId;
myself.objectId = trigoid; myself.objectId = trigoid;
myself.objectSubId = 0; myself.objectSubId = 0;
...@@ -389,7 +388,7 @@ CreateTrigger(CreateTrigStmt *stmt, bool forConstraint) ...@@ -389,7 +388,7 @@ CreateTrigger(CreateTrigStmt *stmt, bool forConstraint)
* backends (and this one too!) are sent SI message to make them * backends (and this one too!) are sent SI message to make them
* rebuild relcache entries. * rebuild relcache entries.
*/ */
pgrel = heap_openr(RelationRelationName, RowExclusiveLock); pgrel = heap_open(RelationRelationId, RowExclusiveLock);
tuple = SearchSysCacheCopy(RELOID, tuple = SearchSysCacheCopy(RELOID,
ObjectIdGetDatum(RelationGetRelid(rel)), ObjectIdGetDatum(RelationGetRelid(rel)),
0, 0, 0); 0, 0, 0);
...@@ -463,7 +462,7 @@ DropTrigger(Oid relid, const char *trigname, DropBehavior behavior) ...@@ -463,7 +462,7 @@ DropTrigger(Oid relid, const char *trigname, DropBehavior behavior)
/* /*
* Find the trigger, verify permissions, set up object address * Find the trigger, verify permissions, set up object address
*/ */
tgrel = heap_openr(TriggerRelationName, AccessShareLock); tgrel = heap_open(TriggerRelationId, AccessShareLock);
ScanKeyInit(&skey[0], ScanKeyInit(&skey[0],
Anum_pg_trigger_tgrelid, Anum_pg_trigger_tgrelid,
...@@ -475,7 +474,7 @@ DropTrigger(Oid relid, const char *trigname, DropBehavior behavior) ...@@ -475,7 +474,7 @@ DropTrigger(Oid relid, const char *trigname, DropBehavior behavior)
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
CStringGetDatum(trigname)); CStringGetDatum(trigname));
tgscan = systable_beginscan(tgrel, TriggerRelidNameIndex, true, tgscan = systable_beginscan(tgrel, TriggerRelidNameIndexId, true,
SnapshotNow, 2, skey); SnapshotNow, 2, skey);
tup = systable_getnext(tgscan); tup = systable_getnext(tgscan);
...@@ -490,7 +489,7 @@ DropTrigger(Oid relid, const char *trigname, DropBehavior behavior) ...@@ -490,7 +489,7 @@ DropTrigger(Oid relid, const char *trigname, DropBehavior behavior)
aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS, aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS,
get_rel_name(relid)); get_rel_name(relid));
object.classId = RelationGetRelid(tgrel); object.classId = TriggerRelationId;
object.objectId = HeapTupleGetOid(tup); object.objectId = HeapTupleGetOid(tup);
object.objectSubId = 0; object.objectSubId = 0;
...@@ -519,7 +518,7 @@ RemoveTriggerById(Oid trigOid) ...@@ -519,7 +518,7 @@ RemoveTriggerById(Oid trigOid)
HeapTuple tuple; HeapTuple tuple;
Form_pg_class classForm; Form_pg_class classForm;
tgrel = heap_openr(TriggerRelationName, RowExclusiveLock); tgrel = heap_open(TriggerRelationId, RowExclusiveLock);
/* /*
* Find the trigger to delete. * Find the trigger to delete.
...@@ -529,7 +528,7 @@ RemoveTriggerById(Oid trigOid) ...@@ -529,7 +528,7 @@ RemoveTriggerById(Oid trigOid)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(trigOid)); ObjectIdGetDatum(trigOid));
tgscan = systable_beginscan(tgrel, TriggerOidIndex, true, tgscan = systable_beginscan(tgrel, TriggerOidIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
tup = systable_getnext(tgscan); tup = systable_getnext(tgscan);
...@@ -572,7 +571,7 @@ RemoveTriggerById(Oid trigOid) ...@@ -572,7 +571,7 @@ RemoveTriggerById(Oid trigOid)
* so no one else is creating/deleting triggers on this rel at the * so no one else is creating/deleting triggers on this rel at the
* same time. * same time.
*/ */
pgrel = heap_openr(RelationRelationName, RowExclusiveLock); pgrel = heap_open(RelationRelationId, RowExclusiveLock);
tuple = SearchSysCacheCopy(RELOID, tuple = SearchSysCacheCopy(RELOID,
ObjectIdGetDatum(relid), ObjectIdGetDatum(relid),
0, 0, 0); 0, 0, 0);
...@@ -636,7 +635,7 @@ renametrig(Oid relid, ...@@ -636,7 +635,7 @@ renametrig(Oid relid,
* NOTE that this is cool only because we have AccessExclusiveLock on the * NOTE that this is cool only because we have AccessExclusiveLock on the
* relation, so the trigger set won't be changing underneath us. * relation, so the trigger set won't be changing underneath us.
*/ */
tgrel = heap_openr(TriggerRelationName, RowExclusiveLock); tgrel = heap_open(TriggerRelationId, RowExclusiveLock);
/* /*
* First pass -- look for name conflict * First pass -- look for name conflict
...@@ -649,7 +648,7 @@ renametrig(Oid relid, ...@@ -649,7 +648,7 @@ renametrig(Oid relid,
Anum_pg_trigger_tgname, Anum_pg_trigger_tgname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
PointerGetDatum(newname)); PointerGetDatum(newname));
tgscan = systable_beginscan(tgrel, TriggerRelidNameIndex, true, tgscan = systable_beginscan(tgrel, TriggerRelidNameIndexId, true,
SnapshotNow, 2, key); SnapshotNow, 2, key);
if (HeapTupleIsValid(tuple = systable_getnext(tgscan))) if (HeapTupleIsValid(tuple = systable_getnext(tgscan)))
ereport(ERROR, ereport(ERROR,
...@@ -669,7 +668,7 @@ renametrig(Oid relid, ...@@ -669,7 +668,7 @@ renametrig(Oid relid,
Anum_pg_trigger_tgname, Anum_pg_trigger_tgname,
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
PointerGetDatum(oldname)); PointerGetDatum(oldname));
tgscan = systable_beginscan(tgrel, TriggerRelidNameIndex, true, tgscan = systable_beginscan(tgrel, TriggerRelidNameIndexId, true,
SnapshotNow, 2, key); SnapshotNow, 2, key);
if (HeapTupleIsValid(tuple = systable_getnext(tgscan))) if (HeapTupleIsValid(tuple = systable_getnext(tgscan)))
{ {
...@@ -739,7 +738,7 @@ RelationBuildTriggers(Relation relation) ...@@ -739,7 +738,7 @@ RelationBuildTriggers(Relation relation)
triggers = (Trigger *) palloc(ntrigs * sizeof(Trigger)); triggers = (Trigger *) palloc(ntrigs * sizeof(Trigger));
/* /*
* Note: since we scan the triggers using TriggerRelidNameIndex, we * Note: since we scan the triggers using TriggerRelidNameIndexId, we
* will be reading the triggers in name order, except possibly during * will be reading the triggers in name order, except possibly during
* emergency-recovery operations (ie, IsIgnoringSystemIndexes). This * emergency-recovery operations (ie, IsIgnoringSystemIndexes). This
* in turn ensures that triggers will be fired in name order. * in turn ensures that triggers will be fired in name order.
...@@ -749,8 +748,8 @@ RelationBuildTriggers(Relation relation) ...@@ -749,8 +748,8 @@ RelationBuildTriggers(Relation relation)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(RelationGetRelid(relation))); ObjectIdGetDatum(RelationGetRelid(relation)));
tgrel = heap_openr(TriggerRelationName, AccessShareLock); tgrel = heap_open(TriggerRelationId, AccessShareLock);
tgscan = systable_beginscan(tgrel, TriggerRelidNameIndex, true, tgscan = systable_beginscan(tgrel, TriggerRelidNameIndexId, true,
SnapshotNow, 1, &skey); SnapshotNow, 1, &skey);
while (HeapTupleIsValid(htup = systable_getnext(tgscan))) while (HeapTupleIsValid(htup = systable_getnext(tgscan)))
...@@ -2802,7 +2801,7 @@ AfterTriggerSetState(ConstraintsSetStmt *stmt) ...@@ -2802,7 +2801,7 @@ AfterTriggerSetState(ConstraintsSetStmt *stmt)
* First lookup all trigger Oid's for the constraint names. * First lookup all trigger Oid's for the constraint names.
* ---------- * ----------
*/ */
tgrel = heap_openr(TriggerRelationName, AccessShareLock); tgrel = heap_open(TriggerRelationId, AccessShareLock);
foreach(l, stmt->constraints) foreach(l, stmt->constraints)
{ {
...@@ -2828,7 +2827,7 @@ AfterTriggerSetState(ConstraintsSetStmt *stmt) ...@@ -2828,7 +2827,7 @@ AfterTriggerSetState(ConstraintsSetStmt *stmt)
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
PointerGetDatum(cname)); PointerGetDatum(cname));
tgscan = systable_beginscan(tgrel, TriggerConstrNameIndex, true, tgscan = systable_beginscan(tgrel, TriggerConstrNameIndexId, true,
SnapshotNow, 1, &skey); SnapshotNow, 1, &skey);
/* /*
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/typecmds.c,v 1.69 2005/04/14 01:38:17 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/typecmds.c,v 1.70 2005/04/14 20:03:24 tgl Exp $
* *
* DESCRIPTION * DESCRIPTION
* The "DefineFoo" routines take the parse tree and pick out the * The "DefineFoo" routines take the parse tree and pick out the
...@@ -33,7 +33,6 @@ ...@@ -33,7 +33,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/genam.h" #include "access/genam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/heap.h" #include "catalog/heap.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
...@@ -458,7 +457,7 @@ RemoveTypeById(Oid typeOid) ...@@ -458,7 +457,7 @@ RemoveTypeById(Oid typeOid)
Relation relation; Relation relation;
HeapTuple tup; HeapTuple tup;
relation = heap_openr(TypeRelationName, RowExclusiveLock); relation = heap_open(TypeRelationId, RowExclusiveLock);
tup = SearchSysCache(TYPEOID, tup = SearchSysCache(TYPEOID,
ObjectIdGetDatum(typeOid), ObjectIdGetDatum(typeOid),
...@@ -1143,7 +1142,7 @@ AlterDomainDefault(List *names, Node *defaultRaw) ...@@ -1143,7 +1142,7 @@ AlterDomainDefault(List *names, Node *defaultRaw)
typename->arrayBounds = NIL; typename->arrayBounds = NIL;
/* Lock the domain in the type table */ /* Lock the domain in the type table */
rel = heap_openr(TypeRelationName, RowExclusiveLock); rel = heap_open(TypeRelationId, RowExclusiveLock);
/* Use LookupTypeName here so that shell types can be removed. */ /* Use LookupTypeName here so that shell types can be removed. */
domainoid = LookupTypeName(typename); domainoid = LookupTypeName(typename);
...@@ -1265,7 +1264,7 @@ AlterDomainNotNull(List *names, bool notNull) ...@@ -1265,7 +1264,7 @@ AlterDomainNotNull(List *names, bool notNull)
typename->arrayBounds = NIL; typename->arrayBounds = NIL;
/* Lock the type table */ /* Lock the type table */
typrel = heap_openr(TypeRelationName, RowExclusiveLock); typrel = heap_open(TypeRelationId, RowExclusiveLock);
/* Use LookupTypeName here so that shell types can be found (why?). */ /* Use LookupTypeName here so that shell types can be found (why?). */
domainoid = LookupTypeName(typename); domainoid = LookupTypeName(typename);
...@@ -1377,7 +1376,7 @@ AlterDomainDropConstraint(List *names, const char *constrName, DropBehavior beha ...@@ -1377,7 +1376,7 @@ AlterDomainDropConstraint(List *names, const char *constrName, DropBehavior beha
typename->arrayBounds = NIL; typename->arrayBounds = NIL;
/* Lock the type table */ /* Lock the type table */
rel = heap_openr(TypeRelationName, RowExclusiveLock); rel = heap_open(TypeRelationId, RowExclusiveLock);
/* Use LookupTypeName here so that shell types can be removed. */ /* Use LookupTypeName here so that shell types can be removed. */
domainoid = LookupTypeName(typename); domainoid = LookupTypeName(typename);
...@@ -1397,7 +1396,7 @@ AlterDomainDropConstraint(List *names, const char *constrName, DropBehavior beha ...@@ -1397,7 +1396,7 @@ AlterDomainDropConstraint(List *names, const char *constrName, DropBehavior beha
domainOwnerCheck(tup, typename); domainOwnerCheck(tup, typename);
/* Grab an appropriate lock on the pg_constraint relation */ /* Grab an appropriate lock on the pg_constraint relation */
conrel = heap_openr(ConstraintRelationName, RowExclusiveLock); conrel = heap_open(ConstraintRelationId, RowExclusiveLock);
/* Use the index to scan only constraints of the target relation */ /* Use the index to scan only constraints of the target relation */
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
...@@ -1405,7 +1404,7 @@ AlterDomainDropConstraint(List *names, const char *constrName, DropBehavior beha ...@@ -1405,7 +1404,7 @@ AlterDomainDropConstraint(List *names, const char *constrName, DropBehavior beha
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(HeapTupleGetOid(tup))); ObjectIdGetDatum(HeapTupleGetOid(tup)));
conscan = systable_beginscan(conrel, ConstraintTypidIndex, true, conscan = systable_beginscan(conrel, ConstraintTypidIndexId, true,
SnapshotNow, 1, key); SnapshotNow, 1, key);
typTup = (Form_pg_type) GETSTRUCT(tup); typTup = (Form_pg_type) GETSTRUCT(tup);
...@@ -1421,7 +1420,7 @@ AlterDomainDropConstraint(List *names, const char *constrName, DropBehavior beha ...@@ -1421,7 +1420,7 @@ AlterDomainDropConstraint(List *names, const char *constrName, DropBehavior beha
{ {
ObjectAddress conobj; ObjectAddress conobj;
conobj.classId = RelationGetRelid(conrel); conobj.classId = ConstraintRelationId;
conobj.objectId = HeapTupleGetOid(contup); conobj.objectId = HeapTupleGetOid(contup);
conobj.objectSubId = 0; conobj.objectSubId = 0;
...@@ -1464,7 +1463,7 @@ AlterDomainAddConstraint(List *names, Node *newConstraint) ...@@ -1464,7 +1463,7 @@ AlterDomainAddConstraint(List *names, Node *newConstraint)
typename->arrayBounds = NIL; typename->arrayBounds = NIL;
/* Lock the type table */ /* Lock the type table */
typrel = heap_openr(TypeRelationName, RowExclusiveLock); typrel = heap_open(TypeRelationId, RowExclusiveLock);
/* Use LookupTypeName here so that shell types can be found (why?). */ /* Use LookupTypeName here so that shell types can be found (why?). */
domainoid = LookupTypeName(typename); domainoid = LookupTypeName(typename);
...@@ -1650,7 +1649,7 @@ get_rels_with_domain(Oid domainOid, LOCKMODE lockmode) ...@@ -1650,7 +1649,7 @@ get_rels_with_domain(Oid domainOid, LOCKMODE lockmode)
* We scan pg_depend to find those things that depend on the domain. * We scan pg_depend to find those things that depend on the domain.
* (We assume we can ignore refobjsubid for a domain.) * (We assume we can ignore refobjsubid for a domain.)
*/ */
depRel = relation_openr(DependRelationName, AccessShareLock); depRel = heap_open(DependRelationId, AccessShareLock);
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
Anum_pg_depend_refclassid, Anum_pg_depend_refclassid,
...@@ -1661,7 +1660,7 @@ get_rels_with_domain(Oid domainOid, LOCKMODE lockmode) ...@@ -1661,7 +1660,7 @@ get_rels_with_domain(Oid domainOid, LOCKMODE lockmode)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(domainOid)); ObjectIdGetDatum(domainOid));
depScan = systable_beginscan(depRel, DependReferenceIndex, true, depScan = systable_beginscan(depRel, DependReferenceIndexId, true,
SnapshotNow, 2, key); SnapshotNow, 2, key);
while (HeapTupleIsValid(depTup = systable_getnext(depScan))) while (HeapTupleIsValid(depTup = systable_getnext(depScan)))
...@@ -1927,7 +1926,7 @@ GetDomainConstraints(Oid typeOid) ...@@ -1927,7 +1926,7 @@ GetDomainConstraints(Oid typeOid)
bool notNull = false; bool notNull = false;
Relation conRel; Relation conRel;
conRel = heap_openr(ConstraintRelationName, AccessShareLock); conRel = heap_open(ConstraintRelationId, AccessShareLock);
for (;;) for (;;)
{ {
...@@ -1961,7 +1960,7 @@ GetDomainConstraints(Oid typeOid) ...@@ -1961,7 +1960,7 @@ GetDomainConstraints(Oid typeOid)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(typeOid)); ObjectIdGetDatum(typeOid));
scan = systable_beginscan(conRel, ConstraintTypidIndex, true, scan = systable_beginscan(conRel, ConstraintTypidIndexId, true,
SnapshotNow, 1, key); SnapshotNow, 1, key);
while (HeapTupleIsValid(conTup = systable_getnext(scan))) while (HeapTupleIsValid(conTup = systable_getnext(scan)))
...@@ -2052,7 +2051,7 @@ AlterTypeOwner(List *names, AclId newOwnerSysId) ...@@ -2052,7 +2051,7 @@ AlterTypeOwner(List *names, AclId newOwnerSysId)
typename->arrayBounds = NIL; typename->arrayBounds = NIL;
/* Lock the type table */ /* Lock the type table */
rel = heap_openr(TypeRelationName, RowExclusiveLock); rel = heap_open(TypeRelationId, RowExclusiveLock);
/* Use LookupTypeName here so that shell types can be processed (why?) */ /* Use LookupTypeName here so that shell types can be processed (why?) */
typeOid = LookupTypeName(typename); typeOid = LookupTypeName(typename);
......
...@@ -6,14 +6,13 @@ ...@@ -6,14 +6,13 @@
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/backend/commands/user.c,v 1.150 2005/04/14 01:38:17 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/user.c,v 1.151 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_database.h" #include "catalog/pg_database.h"
#include "catalog/pg_group.h" #include "catalog/pg_group.h"
...@@ -180,7 +179,7 @@ CreateUser(CreateUserStmt *stmt) ...@@ -180,7 +179,7 @@ CreateUser(CreateUserStmt *stmt)
* to be sure of what the next usesysid should be, and we need to * to be sure of what the next usesysid should be, and we need to
* protect our eventual update of the flat password file. * protect our eventual update of the flat password file.
*/ */
pg_shadow_rel = heap_openr(ShadowRelationName, ExclusiveLock); pg_shadow_rel = heap_open(ShadowRelationId, ExclusiveLock);
pg_shadow_dsc = RelationGetDescr(pg_shadow_rel); pg_shadow_dsc = RelationGetDescr(pg_shadow_rel);
scan = heap_beginscan(pg_shadow_rel, SnapshotNow, 0, NULL); scan = heap_beginscan(pg_shadow_rel, SnapshotNow, 0, NULL);
...@@ -401,7 +400,7 @@ AlterUser(AlterUserStmt *stmt) ...@@ -401,7 +400,7 @@ AlterUser(AlterUserStmt *stmt)
* secure exclusive lock to protect our update of the flat password * secure exclusive lock to protect our update of the flat password
* file. * file.
*/ */
pg_shadow_rel = heap_openr(ShadowRelationName, ExclusiveLock); pg_shadow_rel = heap_open(ShadowRelationId, ExclusiveLock);
pg_shadow_dsc = RelationGetDescr(pg_shadow_rel); pg_shadow_dsc = RelationGetDescr(pg_shadow_rel);
tuple = SearchSysCache(SHADOWNAME, tuple = SearchSysCache(SHADOWNAME,
...@@ -516,7 +515,7 @@ AlterUserSet(AlterUserSetStmt *stmt) ...@@ -516,7 +515,7 @@ AlterUserSet(AlterUserSetStmt *stmt)
* RowExclusiveLock is sufficient, because we don't need to update the * RowExclusiveLock is sufficient, because we don't need to update the
* flat password file. * flat password file.
*/ */
rel = heap_openr(ShadowRelationName, RowExclusiveLock); rel = heap_open(ShadowRelationId, RowExclusiveLock);
oldtuple = SearchSysCache(SHADOWNAME, oldtuple = SearchSysCache(SHADOWNAME,
PointerGetDatum(stmt->user), PointerGetDatum(stmt->user),
0, 0, 0); 0, 0, 0);
...@@ -594,7 +593,7 @@ DropUser(DropUserStmt *stmt) ...@@ -594,7 +593,7 @@ DropUser(DropUserStmt *stmt)
* deleted. Note we secure exclusive lock, because we need to protect * deleted. Note we secure exclusive lock, because we need to protect
* our update of the flat password file. * our update of the flat password file.
*/ */
pg_shadow_rel = heap_openr(ShadowRelationName, ExclusiveLock); pg_shadow_rel = heap_open(ShadowRelationId, ExclusiveLock);
pg_shadow_dsc = RelationGetDescr(pg_shadow_rel); pg_shadow_dsc = RelationGetDescr(pg_shadow_rel);
foreach(item, stmt->users) foreach(item, stmt->users)
...@@ -635,7 +634,7 @@ DropUser(DropUserStmt *stmt) ...@@ -635,7 +634,7 @@ DropUser(DropUserStmt *stmt)
* don't read the manual, it doesn't seem to be the behaviour one * don't read the manual, it doesn't seem to be the behaviour one
* would expect either.) -- petere 2000/01/14) * would expect either.) -- petere 2000/01/14)
*/ */
pg_rel = heap_openr(DatabaseRelationName, AccessShareLock); pg_rel = heap_open(DatabaseRelationId, AccessShareLock);
pg_dsc = RelationGetDescr(pg_rel); pg_dsc = RelationGetDescr(pg_rel);
ScanKeyInit(&scankey, ScanKeyInit(&scankey,
...@@ -677,7 +676,7 @@ DropUser(DropUserStmt *stmt) ...@@ -677,7 +676,7 @@ DropUser(DropUserStmt *stmt)
* *
* try calling alter group drop user for every group * try calling alter group drop user for every group
*/ */
pg_rel = heap_openr(GroupRelationName, ExclusiveLock); pg_rel = heap_open(GroupRelationId, ExclusiveLock);
pg_dsc = RelationGetDescr(pg_rel); pg_dsc = RelationGetDescr(pg_rel);
scan = heap_beginscan(pg_rel, SnapshotNow, 0, NULL); scan = heap_beginscan(pg_rel, SnapshotNow, 0, NULL);
while ((tmp_tuple = heap_getnext(scan, ForwardScanDirection)) != NULL) while ((tmp_tuple = heap_getnext(scan, ForwardScanDirection)) != NULL)
...@@ -734,7 +733,7 @@ RenameUser(const char *oldname, const char *newname) ...@@ -734,7 +733,7 @@ RenameUser(const char *oldname, const char *newname)
int i; int i;
/* ExclusiveLock because we need to update the password file */ /* ExclusiveLock because we need to update the password file */
rel = heap_openr(ShadowRelationName, ExclusiveLock); rel = heap_open(ShadowRelationId, ExclusiveLock);
dsc = RelationGetDescr(rel); dsc = RelationGetDescr(rel);
oldtuple = SearchSysCache(SHADOWNAME, oldtuple = SearchSysCache(SHADOWNAME,
...@@ -819,13 +818,17 @@ CheckPgUserAclNotNull(void) ...@@ -819,13 +818,17 @@ CheckPgUserAclNotNull(void)
elog(ERROR, "cache lookup failed for relation %u", ShadowRelationId); elog(ERROR, "cache lookup failed for relation %u", ShadowRelationId);
if (heap_attisnull(htup, Anum_pg_class_relacl)) if (heap_attisnull(htup, Anum_pg_class_relacl))
{
Form_pg_class classForm = (Form_pg_class) GETSTRUCT(htup);
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("before using passwords you must revoke privileges on %s", errmsg("before using passwords you must revoke privileges on %s",
ShadowRelationName), NameStr(classForm->relname)),
errdetail("This restriction is to prevent unprivileged users from reading the passwords."), errdetail("This restriction is to prevent unprivileged users from reading the passwords."),
errhint("Try REVOKE ALL ON \"%s\" FROM PUBLIC.", errhint("Try REVOKE ALL ON \"%s\" FROM PUBLIC.",
ShadowRelationName))); NameStr(classForm->relname))));
}
ReleaseSysCache(htup); ReleaseSysCache(htup);
} }
...@@ -914,7 +917,7 @@ CreateGroup(CreateGroupStmt *stmt) ...@@ -914,7 +917,7 @@ CreateGroup(CreateGroupStmt *stmt)
* to be sure of what the next grosysid should be, and we need to * to be sure of what the next grosysid should be, and we need to
* protect our eventual update of the flat group file. * protect our eventual update of the flat group file.
*/ */
pg_group_rel = heap_openr(GroupRelationName, ExclusiveLock); pg_group_rel = heap_open(GroupRelationId, ExclusiveLock);
pg_group_dsc = RelationGetDescr(pg_group_rel); pg_group_dsc = RelationGetDescr(pg_group_rel);
scan = heap_beginscan(pg_group_rel, SnapshotNow, 0, NULL); scan = heap_beginscan(pg_group_rel, SnapshotNow, 0, NULL);
...@@ -1032,7 +1035,7 @@ AlterGroup(AlterGroupStmt *stmt, const char *tag) ...@@ -1032,7 +1035,7 @@ AlterGroup(AlterGroupStmt *stmt, const char *tag)
/* /*
* Secure exclusive lock to protect our update of the flat group file. * Secure exclusive lock to protect our update of the flat group file.
*/ */
pg_group_rel = heap_openr(GroupRelationName, ExclusiveLock); pg_group_rel = heap_open(GroupRelationId, ExclusiveLock);
pg_group_dsc = RelationGetDescr(pg_group_rel); pg_group_dsc = RelationGetDescr(pg_group_rel);
/* /*
...@@ -1271,7 +1274,7 @@ DropGroup(DropGroupStmt *stmt) ...@@ -1271,7 +1274,7 @@ DropGroup(DropGroupStmt *stmt)
/* /*
* Secure exclusive lock to protect our update of the flat group file. * Secure exclusive lock to protect our update of the flat group file.
*/ */
pg_group_rel = heap_openr(GroupRelationName, ExclusiveLock); pg_group_rel = heap_open(GroupRelationId, ExclusiveLock);
/* Find and delete the group. */ /* Find and delete the group. */
...@@ -1308,7 +1311,7 @@ RenameGroup(const char *oldname, const char *newname) ...@@ -1308,7 +1311,7 @@ RenameGroup(const char *oldname, const char *newname)
Relation rel; Relation rel;
/* ExclusiveLock because we need to update the flat group file */ /* ExclusiveLock because we need to update the flat group file */
rel = heap_openr(GroupRelationName, ExclusiveLock); rel = heap_open(GroupRelationId, ExclusiveLock);
tup = SearchSysCacheCopy(GRONAME, tup = SearchSysCacheCopy(GRONAME,
CStringGetDatum(oldname), CStringGetDatum(oldname),
......
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/vacuum.c,v 1.305 2005/03/20 22:00:52 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/vacuum.c,v 1.306 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -28,7 +28,6 @@ ...@@ -28,7 +28,6 @@
#include "access/subtrans.h" #include "access/subtrans.h"
#include "access/xlog.h" #include "access/xlog.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_database.h" #include "catalog/pg_database.h"
#include "catalog/pg_index.h" #include "catalog/pg_index.h"
...@@ -542,7 +541,7 @@ get_rel_oids(const RangeVar *vacrel, const char *stmttype) ...@@ -542,7 +541,7 @@ get_rel_oids(const RangeVar *vacrel, const char *stmttype)
BTEqualStrategyNumber, F_CHAREQ, BTEqualStrategyNumber, F_CHAREQ,
CharGetDatum(RELKIND_RELATION)); CharGetDatum(RELKIND_RELATION));
pgclass = heap_openr(RelationRelationName, AccessShareLock); pgclass = heap_open(RelationRelationId, AccessShareLock);
scan = heap_beginscan(pgclass, SnapshotNow, 1, &key); scan = heap_beginscan(pgclass, SnapshotNow, 1, &key);
...@@ -642,7 +641,7 @@ vac_update_relstats(Oid relid, BlockNumber num_pages, double num_tuples, ...@@ -642,7 +641,7 @@ vac_update_relstats(Oid relid, BlockNumber num_pages, double num_tuples,
/* /*
* update number of tuples and number of pages in pg_class * update number of tuples and number of pages in pg_class
*/ */
rd = heap_openr(RelationRelationName, RowExclusiveLock); rd = heap_open(RelationRelationId, RowExclusiveLock);
ctup = SearchSysCache(RELOID, ctup = SearchSysCache(RELOID,
ObjectIdGetDatum(relid), ObjectIdGetDatum(relid),
...@@ -718,7 +717,7 @@ vac_update_dbstats(Oid dbid, ...@@ -718,7 +717,7 @@ vac_update_dbstats(Oid dbid,
HeapTuple tuple; HeapTuple tuple;
Form_pg_database dbform; Form_pg_database dbform;
relation = heap_openr(DatabaseRelationName, RowExclusiveLock); relation = heap_open(DatabaseRelationId, RowExclusiveLock);
/* Must use a heap scan, since there's no syscache for pg_database */ /* Must use a heap scan, since there's no syscache for pg_database */
ScanKeyInit(&entry[0], ScanKeyInit(&entry[0],
...@@ -792,7 +791,7 @@ vac_truncate_clog(TransactionId vacuumXID, TransactionId frozenXID) ...@@ -792,7 +791,7 @@ vac_truncate_clog(TransactionId vacuumXID, TransactionId frozenXID)
* Note: the "already wrapped" cases should now be impossible due to the * Note: the "already wrapped" cases should now be impossible due to the
* defenses in GetNewTransactionId, but we keep them anyway. * defenses in GetNewTransactionId, but we keep them anyway.
*/ */
relation = heap_openr(DatabaseRelationName, AccessShareLock); relation = heap_open(DatabaseRelationId, AccessShareLock);
scan = heap_beginscan(relation, SnapshotNow, 0, NULL); scan = heap_beginscan(relation, SnapshotNow, 0, NULL);
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/executor/execUtils.c,v 1.120 2005/04/06 16:34:04 tgl Exp $ * $PostgreSQL: pgsql/src/backend/executor/execUtils.c,v 1.121 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -40,7 +40,6 @@ ...@@ -40,7 +40,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/index.h" #include "catalog/index.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/pg_index.h" #include "catalog/pg_index.h"
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/optimizer/util/plancat.c,v 1.104 2005/04/06 16:34:06 tgl Exp $ * $PostgreSQL: pgsql/src/backend/optimizer/util/plancat.c,v 1.105 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -19,7 +19,6 @@ ...@@ -19,7 +19,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/pg_amop.h" #include "catalog/pg_amop.h"
#include "catalog/pg_inherits.h" #include "catalog/pg_inherits.h"
#include "catalog/pg_index.h" #include "catalog/pg_index.h"
...@@ -509,7 +508,7 @@ find_inheritance_children(Oid inhparent) ...@@ -509,7 +508,7 @@ find_inheritance_children(Oid inhparent)
Anum_pg_inherits_inhparent, Anum_pg_inherits_inhparent,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(inhparent)); ObjectIdGetDatum(inhparent));
relation = heap_openr(InheritsRelationName, AccessShareLock); relation = heap_open(InheritsRelationId, AccessShareLock);
scan = heap_beginscan(relation, SnapshotNow, 1, key); scan = heap_beginscan(relation, SnapshotNow, 1, key);
while ((inheritsTuple = heap_getnext(scan, ForwardScanDirection)) != NULL) while ((inheritsTuple = heap_getnext(scan, ForwardScanDirection)) != NULL)
{ {
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/backend/parser/analyze.c,v 1.319 2005/04/13 16:50:54 tgl Exp $ * $PostgreSQL: pgsql/src/backend/parser/analyze.c,v 1.320 2005/04/14 20:03:24 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -14,7 +14,6 @@ ...@@ -14,7 +14,6 @@
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/heap.h" #include "catalog/heap.h"
#include "catalog/index.h" #include "catalog/index.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
......
...@@ -8,14 +8,13 @@ ...@@ -8,14 +8,13 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/parser/parse_func.c,v 1.177 2005/03/31 22:46:13 tgl Exp $ * $PostgreSQL: pgsql/src/backend/parser/parse_func.c,v 1.178 2005/04/14 20:03:25 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/pg_inherits.h" #include "catalog/pg_inherits.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
#include "funcapi.h" #include "funcapi.h"
...@@ -922,7 +921,7 @@ find_inheritors(Oid relid, Oid **supervec) ...@@ -922,7 +921,7 @@ find_inheritors(Oid relid, Oid **supervec)
queue = list_make1_oid(relid); queue = list_make1_oid(relid);
visited = NIL; visited = NIL;
inhrel = heap_openr(InheritsRelationName, AccessShareLock); inhrel = heap_open(InheritsRelationId, AccessShareLock);
/* /*
* Use queue to do a breadth-first traversal of the inheritance graph * Use queue to do a breadth-first traversal of the inheritance graph
......
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
* *
* Copyright (c) 2001-2005, PostgreSQL Global Development Group * Copyright (c) 2001-2005, PostgreSQL Global Development Group
* *
* $PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.90 2005/04/08 00:55:07 neilc Exp $ * $PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.91 2005/04/14 20:03:25 tgl Exp $
* ---------- * ----------
*/ */
#include "postgres.h" #include "postgres.h"
...@@ -33,7 +33,6 @@ ...@@ -33,7 +33,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/xact.h" #include "access/xact.h"
#include "catalog/catname.h"
#include "catalog/pg_database.h" #include "catalog/pg_database.h"
#include "catalog/pg_shadow.h" #include "catalog/pg_shadow.h"
#include "libpq/libpq.h" #include "libpq/libpq.h"
...@@ -865,7 +864,7 @@ pgstat_vacuum_tabstat(void) ...@@ -865,7 +864,7 @@ pgstat_vacuum_tabstat(void)
dbidused = 0; dbidused = 0;
dbidlist = (Oid *) palloc(sizeof(Oid) * dbidalloc); dbidlist = (Oid *) palloc(sizeof(Oid) * dbidalloc);
dbrel = heap_openr(DatabaseRelationName, AccessShareLock); dbrel = heap_open(DatabaseRelationId, AccessShareLock);
dbscan = heap_beginscan(dbrel, SnapshotNow, 0, NULL); dbscan = heap_beginscan(dbrel, SnapshotNow, 0, NULL);
while ((dbtup = heap_getnext(dbscan, ForwardScanDirection)) != NULL) while ((dbtup = heap_getnext(dbscan, ForwardScanDirection)) != NULL)
{ {
......
...@@ -8,14 +8,13 @@ ...@@ -8,14 +8,13 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/rewrite/rewriteDefine.c,v 1.103 2005/04/14 01:38:17 tgl Exp $ * $PostgreSQL: pgsql/src/backend/rewrite/rewriteDefine.c,v 1.104 2005/04/14 20:03:25 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_rewrite.h" #include "catalog/pg_rewrite.h"
...@@ -87,7 +86,7 @@ InsertRule(char *rulname, ...@@ -87,7 +86,7 @@ InsertRule(char *rulname,
/* /*
* Ready to store new pg_rewrite tuple * Ready to store new pg_rewrite tuple
*/ */
pg_rewrite_desc = heap_openr(RewriteRelationName, RowExclusiveLock); pg_rewrite_desc = heap_open(RewriteRelationId, RowExclusiveLock);
/* /*
* Check to see if we are replacing an existing tuple * Check to see if we are replacing an existing tuple
...@@ -139,8 +138,7 @@ InsertRule(char *rulname, ...@@ -139,8 +138,7 @@ InsertRule(char *rulname,
/* If replacing, get rid of old dependencies and make new ones */ /* If replacing, get rid of old dependencies and make new ones */
if (is_update) if (is_update)
deleteDependencyRecordsFor(RelationGetRelid(pg_rewrite_desc), deleteDependencyRecordsFor(RewriteRelationId, rewriteObjectId);
rewriteObjectId);
/* /*
* Install dependency on rule's relation to ensure it will go away on * Install dependency on rule's relation to ensure it will go away on
...@@ -570,7 +568,7 @@ RenameRewriteRule(Oid owningRel, const char *oldName, ...@@ -570,7 +568,7 @@ RenameRewriteRule(Oid owningRel, const char *oldName,
Relation pg_rewrite_desc; Relation pg_rewrite_desc;
HeapTuple ruletup; HeapTuple ruletup;
pg_rewrite_desc = heap_openr(RewriteRelationName, RowExclusiveLock); pg_rewrite_desc = heap_open(RewriteRelationId, RowExclusiveLock);
ruletup = SearchSysCacheCopy(RULERELNAME, ruletup = SearchSysCacheCopy(RULERELNAME,
ObjectIdGetDatum(owningRel), ObjectIdGetDatum(owningRel),
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/rewrite/rewriteRemove.c,v 1.61 2004/12/31 22:00:46 pgsql Exp $ * $PostgreSQL: pgsql/src/backend/rewrite/rewriteRemove.c,v 1.62 2005/04/14 20:03:25 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_rewrite.h" #include "catalog/pg_rewrite.h"
...@@ -72,7 +71,7 @@ RemoveRewriteRule(Oid owningRel, const char *ruleName, DropBehavior behavior) ...@@ -72,7 +71,7 @@ RemoveRewriteRule(Oid owningRel, const char *ruleName, DropBehavior behavior)
/* /*
* Do the deletion * Do the deletion
*/ */
object.classId = get_system_catalog_relid(RewriteRelationName); object.classId = RewriteRelationId;
object.objectId = HeapTupleGetOid(tuple); object.objectId = HeapTupleGetOid(tuple);
object.objectSubId = 0; object.objectSubId = 0;
...@@ -99,7 +98,7 @@ RemoveRewriteRuleById(Oid ruleOid) ...@@ -99,7 +98,7 @@ RemoveRewriteRuleById(Oid ruleOid)
/* /*
* Open the pg_rewrite relation. * Open the pg_rewrite relation.
*/ */
RewriteRelation = heap_openr(RewriteRelationName, RowExclusiveLock); RewriteRelation = heap_open(RewriteRelationId, RowExclusiveLock);
/* /*
* Find the tuple for the target rule. * Find the tuple for the target rule.
...@@ -109,7 +108,7 @@ RemoveRewriteRuleById(Oid ruleOid) ...@@ -109,7 +108,7 @@ RemoveRewriteRuleById(Oid ruleOid)
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(ruleOid)); ObjectIdGetDatum(ruleOid));
rcscan = systable_beginscan(RewriteRelation, RewriteOidIndex, true, rcscan = systable_beginscan(RewriteRelation, RewriteOidIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
tuple = systable_getnext(rcscan); tuple = systable_getnext(rcscan);
......
...@@ -8,14 +8,13 @@ ...@@ -8,14 +8,13 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/rewrite/rewriteSupport.c,v 1.60 2004/12/31 22:00:46 pgsql Exp $ * $PostgreSQL: pgsql/src/backend/rewrite/rewriteSupport.c,v 1.61 2005/04/14 20:03:25 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "rewrite/rewriteSupport.h" #include "rewrite/rewriteSupport.h"
#include "utils/inval.h" #include "utils/inval.h"
...@@ -60,7 +59,7 @@ SetRelationRuleStatus(Oid relationId, bool relHasRules, ...@@ -60,7 +59,7 @@ SetRelationRuleStatus(Oid relationId, bool relHasRules,
* Find the tuple to update in pg_class, using syscache for the * Find the tuple to update in pg_class, using syscache for the
* lookup. * lookup.
*/ */
relationRelation = heap_openr(RelationRelationName, RowExclusiveLock); relationRelation = heap_open(RelationRelationId, RowExclusiveLock);
tuple = SearchSysCacheCopy(RELOID, tuple = SearchSysCacheCopy(RELOID,
ObjectIdGetDatum(relationId), ObjectIdGetDatum(relationId),
0, 0, 0); 0, 0, 0);
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/storage/large_object/inv_api.c,v 1.109 2005/01/27 23:24:09 neilc Exp $ * $PostgreSQL: pgsql/src/backend/storage/large_object/inv_api.c,v 1.110 2005/04/14 20:03:25 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -19,7 +19,6 @@ ...@@ -19,7 +19,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/tuptoaster.h" #include "access/tuptoaster.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_largeobject.h" #include "catalog/pg_largeobject.h"
#include "commands/comment.h" #include "commands/comment.h"
...@@ -60,9 +59,9 @@ open_lo_relation(void) ...@@ -60,9 +59,9 @@ open_lo_relation(void)
/* Use RowExclusiveLock since we might either read or write */ /* Use RowExclusiveLock since we might either read or write */
if (lo_heap_r == NULL) if (lo_heap_r == NULL)
lo_heap_r = heap_openr(LargeObjectRelationName, RowExclusiveLock); lo_heap_r = heap_open(LargeObjectRelationId, RowExclusiveLock);
if (lo_index_r == NULL) if (lo_index_r == NULL)
lo_index_r = index_openr(LargeObjectLOidPNIndex); lo_index_r = index_open(LargeObjectLOidPNIndexId);
} }
PG_CATCH(); PG_CATCH();
{ {
...@@ -230,15 +229,10 @@ inv_close(LargeObjectDesc *obj_desc) ...@@ -230,15 +229,10 @@ inv_close(LargeObjectDesc *obj_desc)
int int
inv_drop(Oid lobjId) inv_drop(Oid lobjId)
{ {
Oid classoid;
LargeObjectDrop(lobjId); LargeObjectDrop(lobjId);
/* pg_largeobject doesn't have a hard-coded OID, so must look it up */
classoid = get_system_catalog_relid(LargeObjectRelationName);
/* Delete any comments on the large object */ /* Delete any comments on the large object */
DeleteComments(lobjId, classoid, 0); DeleteComments(lobjId, LargeObjectRelationId, 0);
/* /*
* Advance command counter so that tuple removal will be seen by later * Advance command counter so that tuple removal will be seen by later
......
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/adt/regproc.c,v 1.93 2005/03/29 00:17:08 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/adt/regproc.c,v 1.94 2005/04/14 20:03:26 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -23,7 +23,6 @@ ...@@ -23,7 +23,6 @@
#include "access/genam.h" #include "access/genam.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_operator.h" #include "catalog/pg_operator.h"
...@@ -97,8 +96,8 @@ regprocin(PG_FUNCTION_ARGS) ...@@ -97,8 +96,8 @@ regprocin(PG_FUNCTION_ARGS)
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
CStringGetDatum(pro_name_or_oid)); CStringGetDatum(pro_name_or_oid));
hdesc = heap_openr(ProcedureRelationName, AccessShareLock); hdesc = heap_open(ProcedureRelationId, AccessShareLock);
sysscan = systable_beginscan(hdesc, ProcedureNameArgsNspIndex, true, sysscan = systable_beginscan(hdesc, ProcedureNameArgsNspIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
while (HeapTupleIsValid(tuple = systable_getnext(sysscan))) while (HeapTupleIsValid(tuple = systable_getnext(sysscan)))
...@@ -447,8 +446,8 @@ regoperin(PG_FUNCTION_ARGS) ...@@ -447,8 +446,8 @@ regoperin(PG_FUNCTION_ARGS)
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
CStringGetDatum(opr_name_or_oid)); CStringGetDatum(opr_name_or_oid));
hdesc = heap_openr(OperatorRelationName, AccessShareLock); hdesc = heap_open(OperatorRelationId, AccessShareLock);
sysscan = systable_beginscan(hdesc, OperatorNameNspIndex, true, sysscan = systable_beginscan(hdesc, OperatorNameNspIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
while (HeapTupleIsValid(tuple = systable_getnext(sysscan))) while (HeapTupleIsValid(tuple = systable_getnext(sysscan)))
...@@ -825,8 +824,8 @@ regclassin(PG_FUNCTION_ARGS) ...@@ -825,8 +824,8 @@ regclassin(PG_FUNCTION_ARGS)
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
CStringGetDatum(class_name_or_oid)); CStringGetDatum(class_name_or_oid));
hdesc = heap_openr(RelationRelationName, AccessShareLock); hdesc = heap_open(RelationRelationId, AccessShareLock);
sysscan = systable_beginscan(hdesc, ClassNameNspIndex, true, sysscan = systable_beginscan(hdesc, ClassNameNspIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
if (HeapTupleIsValid(tuple = systable_getnext(sysscan))) if (HeapTupleIsValid(tuple = systable_getnext(sysscan)))
...@@ -991,8 +990,8 @@ regtypein(PG_FUNCTION_ARGS) ...@@ -991,8 +990,8 @@ regtypein(PG_FUNCTION_ARGS)
BTEqualStrategyNumber, F_NAMEEQ, BTEqualStrategyNumber, F_NAMEEQ,
CStringGetDatum(typ_name_or_oid)); CStringGetDatum(typ_name_or_oid));
hdesc = heap_openr(TypeRelationName, AccessShareLock); hdesc = heap_open(TypeRelationId, AccessShareLock);
sysscan = systable_beginscan(hdesc, TypeNameNspIndex, true, sysscan = systable_beginscan(hdesc, TypeNameNspIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
if (HeapTupleIsValid(tuple = systable_getnext(sysscan))) if (HeapTupleIsValid(tuple = systable_getnext(sysscan)))
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
* back to source text * back to source text
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.192 2005/04/14 01:38:19 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.193 2005/04/14 20:03:26 tgl Exp $
* *
* This software is copyrighted by Jan Wieck - Hamburg. * This software is copyrighted by Jan Wieck - Hamburg.
* *
...@@ -41,7 +41,6 @@ ...@@ -41,7 +41,6 @@
#include <fcntl.h> #include <fcntl.h>
#include "access/genam.h" #include "access/genam.h"
#include "catalog/catname.h"
#include "catalog/dependency.h" #include "catalog/dependency.h"
#include "catalog/heap.h" #include "catalog/heap.h"
#include "catalog/index.h" #include "catalog/index.h"
...@@ -469,14 +468,14 @@ pg_get_triggerdef(PG_FUNCTION_ARGS) ...@@ -469,14 +468,14 @@ pg_get_triggerdef(PG_FUNCTION_ARGS)
/* /*
* Fetch the pg_trigger tuple by the Oid of the trigger * Fetch the pg_trigger tuple by the Oid of the trigger
*/ */
tgrel = heap_openr(TriggerRelationName, AccessShareLock); tgrel = heap_open(TriggerRelationId, AccessShareLock);
ScanKeyInit(&skey[0], ScanKeyInit(&skey[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(trigid)); ObjectIdGetDatum(trigid));
tgscan = systable_beginscan(tgrel, TriggerOidIndex, true, tgscan = systable_beginscan(tgrel, TriggerOidIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
ht_trig = systable_getnext(tgscan); ht_trig = systable_getnext(tgscan);
...@@ -867,14 +866,14 @@ pg_get_constraintdef_worker(Oid constraintId, bool fullCommand, ...@@ -867,14 +866,14 @@ pg_get_constraintdef_worker(Oid constraintId, bool fullCommand,
* Fetch the pg_constraint row. There's no syscache for pg_constraint * Fetch the pg_constraint row. There's no syscache for pg_constraint
* so we must do it the hard way. * so we must do it the hard way.
*/ */
conDesc = heap_openr(ConstraintRelationName, AccessShareLock); conDesc = heap_open(ConstraintRelationId, AccessShareLock);
ScanKeyInit(&skey[0], ScanKeyInit(&skey[0],
ObjectIdAttributeNumber, ObjectIdAttributeNumber,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(constraintId)); ObjectIdGetDatum(constraintId));
conscan = systable_beginscan(conDesc, ConstraintOidIndex, true, conscan = systable_beginscan(conDesc, ConstraintOidIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
tup = systable_getnext(conscan); tup = systable_getnext(conscan);
...@@ -1269,7 +1268,7 @@ pg_get_serial_sequence(PG_FUNCTION_ARGS) ...@@ -1269,7 +1268,7 @@ pg_get_serial_sequence(PG_FUNCTION_ARGS)
column, tablerv->relname))); column, tablerv->relname)));
/* Search the dependency table for the dependent sequence */ /* Search the dependency table for the dependent sequence */
depRel = heap_openr(DependRelationName, AccessShareLock); depRel = heap_open(DependRelationId, AccessShareLock);
ScanKeyInit(&key[0], ScanKeyInit(&key[0],
Anum_pg_depend_refclassid, Anum_pg_depend_refclassid,
...@@ -1284,7 +1283,7 @@ pg_get_serial_sequence(PG_FUNCTION_ARGS) ...@@ -1284,7 +1283,7 @@ pg_get_serial_sequence(PG_FUNCTION_ARGS)
BTEqualStrategyNumber, F_INT4EQ, BTEqualStrategyNumber, F_INT4EQ,
Int32GetDatum(attnum)); Int32GetDatum(attnum));
scan = systable_beginscan(depRel, DependReferenceIndex, true, scan = systable_beginscan(depRel, DependReferenceIndexId, true,
SnapshotNow, 3, key); SnapshotNow, 3, key);
while (HeapTupleIsValid(tup = systable_getnext(scan))) while (HeapTupleIsValid(tup = systable_getnext(scan)))
......
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/adt/selfuncs.c,v 1.176 2005/04/01 20:31:50 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/adt/selfuncs.c,v 1.177 2005/04/14 20:03:26 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -79,7 +79,6 @@ ...@@ -79,7 +79,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/nbtree.h" #include "access/nbtree.h"
#include "access/tuptoaster.h" #include "access/tuptoaster.h"
#include "catalog/catname.h"
#include "catalog/pg_namespace.h" #include "catalog/pg_namespace.h"
#include "catalog/pg_opclass.h" #include "catalog/pg_opclass.h"
#include "catalog/pg_operator.h" #include "catalog/pg_operator.h"
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/cache/catcache.c,v 1.119 2005/03/25 18:30:27 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/cache/catcache.c,v 1.120 2005/04/14 20:03:26 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -21,7 +21,6 @@ ...@@ -21,7 +21,6 @@
#include "catalog/pg_opclass.h" #include "catalog/pg_opclass.h"
#include "catalog/pg_operator.h" #include "catalog/pg_operator.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "miscadmin.h" #include "miscadmin.h"
#ifdef CATCACHE_STATS #ifdef CATCACHE_STATS
...@@ -35,7 +34,7 @@ ...@@ -35,7 +34,7 @@
#include "utils/syscache.h" #include "utils/syscache.h"
/* #define CACHEDEBUG */ /* turns DEBUG elogs on */ /* #define CACHEDEBUG */ /* turns DEBUG elogs on */
/* /*
* Constants related to size of the catcache. * Constants related to size of the catcache.
...@@ -297,9 +296,9 @@ CatCachePrintStats(void) ...@@ -297,9 +296,9 @@ CatCachePrintStats(void)
{ {
if (cache->cc_ntup == 0 && cache->cc_searches == 0) if (cache->cc_ntup == 0 && cache->cc_searches == 0)
continue; /* don't print unused caches */ continue; /* don't print unused caches */
elog(DEBUG2, "catcache %s/%s: %d tup, %ld srch, %ld+%ld=%ld hits, %ld+%ld=%ld loads, %ld invals, %ld discards, %ld lsrch, %ld lhits", elog(DEBUG2, "catcache %s/%u: %d tup, %ld srch, %ld+%ld=%ld hits, %ld+%ld=%ld loads, %ld invals, %ld discards, %ld lsrch, %ld lhits",
cache->cc_relname, cache->cc_relname,
cache->cc_indname, cache->cc_indexoid,
cache->cc_ntup, cache->cc_ntup,
cache->cc_searches, cache->cc_searches,
cache->cc_hits, cache->cc_hits,
...@@ -763,8 +762,9 @@ CatalogCacheFlushRelation(Oid relId) ...@@ -763,8 +762,9 @@ CatalogCacheFlushRelation(Oid relId)
#ifdef CACHEDEBUG #ifdef CACHEDEBUG
#define InitCatCache_DEBUG2 \ #define InitCatCache_DEBUG2 \
do { \ do { \
elog(DEBUG2, "InitCatCache: rel=%s id=%d nkeys=%d size=%d", \ elog(DEBUG2, "InitCatCache: rel=%u ind=%u id=%d nkeys=%d size=%d", \
cp->cc_relname, cp->id, cp->cc_nkeys, cp->cc_nbuckets); \ cp->cc_reloid, cp->cc_indexoid, cp->id, \
cp->cc_nkeys, cp->cc_nbuckets); \
} while(0) } while(0)
#else #else
...@@ -773,8 +773,8 @@ do { \ ...@@ -773,8 +773,8 @@ do { \
CatCache * CatCache *
InitCatCache(int id, InitCatCache(int id,
const char *relname, Oid reloid,
const char *indname, Oid indexoid,
int reloidattr, int reloidattr,
int nkeys, int nkeys,
const int *key) const int *key)
...@@ -821,9 +821,9 @@ InitCatCache(int id, ...@@ -821,9 +821,9 @@ InitCatCache(int id,
* other internal fields. But don't open the relation yet. * other internal fields. But don't open the relation yet.
*/ */
cp->id = id; cp->id = id;
cp->cc_relname = relname; cp->cc_relname = "(not known yet)";
cp->cc_indname = indname; cp->cc_reloid = reloid;
cp->cc_reloid = InvalidOid; /* temporary */ cp->cc_indexoid = indexoid;
cp->cc_relisshared = false; /* temporary */ cp->cc_relisshared = false; /* temporary */
cp->cc_tupdesc = (TupleDesc) NULL; cp->cc_tupdesc = (TupleDesc) NULL;
cp->cc_reloidattr = reloidattr; cp->cc_reloidattr = reloidattr;
...@@ -861,9 +861,9 @@ InitCatCache(int id, ...@@ -861,9 +861,9 @@ InitCatCache(int id,
* that the relcache entry can be opened at this point! * that the relcache entry can be opened at this point!
*/ */
#ifdef CACHEDEBUG #ifdef CACHEDEBUG
#define CatalogCacheInitializeCache_DEBUG2 \ #define CatalogCacheInitializeCache_DEBUG1 \
elog(DEBUG2, "CatalogCacheInitializeCache: cache @%p %s", cache, \ elog(DEBUG2, "CatalogCacheInitializeCache: cache @%p rel=%u", cache, \
cache->cc_relname) cache->cc_reloid)
#define CatalogCacheInitializeCache_DEBUG2 \ #define CatalogCacheInitializeCache_DEBUG2 \
do { \ do { \
...@@ -878,7 +878,7 @@ do { \ ...@@ -878,7 +878,7 @@ do { \
} while(0) } while(0)
#else #else
#define CatalogCacheInitializeCache_DEBUG2 #define CatalogCacheInitializeCache_DEBUG1
#define CatalogCacheInitializeCache_DEBUG2 #define CatalogCacheInitializeCache_DEBUG2
#endif #endif
...@@ -890,13 +890,13 @@ CatalogCacheInitializeCache(CatCache *cache) ...@@ -890,13 +890,13 @@ CatalogCacheInitializeCache(CatCache *cache)
TupleDesc tupdesc; TupleDesc tupdesc;
int i; int i;
CatalogCacheInitializeCache_DEBUG2; CatalogCacheInitializeCache_DEBUG1;
/* /*
* Open the relation without locking --- we only need the tupdesc, * Open the relation without locking --- we only need the tupdesc,
* which we assume will never change ... * which we assume will never change ...
*/ */
relation = heap_openr(cache->cc_relname, NoLock); relation = heap_open(cache->cc_reloid, NoLock);
Assert(RelationIsValid(relation)); Assert(RelationIsValid(relation));
/* /*
...@@ -913,9 +913,10 @@ CatalogCacheInitializeCache(CatCache *cache) ...@@ -913,9 +913,10 @@ CatalogCacheInitializeCache(CatCache *cache)
tupdesc = CreateTupleDescCopyConstr(RelationGetDescr(relation)); tupdesc = CreateTupleDescCopyConstr(RelationGetDescr(relation));
/* /*
* get the relation's OID and relisshared flag, too * save the relation's name and relisshared flag, too (cc_relname
* is used only for debugging purposes)
*/ */
cache->cc_reloid = RelationGetRelid(relation); cache->cc_relname = pstrdup(RelationGetRelationName(relation));
cache->cc_relisshared = RelationGetForm(relation)->relisshared; cache->cc_relisshared = RelationGetForm(relation)->relisshared;
/* /*
...@@ -999,7 +1000,7 @@ InitCatCachePhase2(CatCache *cache) ...@@ -999,7 +1000,7 @@ InitCatCachePhase2(CatCache *cache)
{ {
Relation idesc; Relation idesc;
idesc = index_openr(cache->cc_indname); idesc = index_open(cache->cc_indexoid);
index_close(idesc); index_close(idesc);
} }
} }
...@@ -1202,7 +1203,7 @@ SearchCatCache(CatCache *cache, ...@@ -1202,7 +1203,7 @@ SearchCatCache(CatCache *cache,
relation = heap_open(cache->cc_reloid, AccessShareLock); relation = heap_open(cache->cc_reloid, AccessShareLock);
scandesc = systable_beginscan(relation, scandesc = systable_beginscan(relation,
cache->cc_indname, cache->cc_indexoid,
IndexScanOK(cache, cur_skey), IndexScanOK(cache, cur_skey),
SnapshotNow, SnapshotNow,
cache->cc_nkeys, cache->cc_nkeys,
...@@ -1230,9 +1231,17 @@ SearchCatCache(CatCache *cache, ...@@ -1230,9 +1231,17 @@ SearchCatCache(CatCache *cache,
* If tuple was not found, we need to build a negative cache entry * If tuple was not found, we need to build a negative cache entry
* containing a fake tuple. The fake tuple has the correct key * containing a fake tuple. The fake tuple has the correct key
* columns, but nulls everywhere else. * columns, but nulls everywhere else.
*
* In bootstrap mode, we don't build negative entries, because the
* cache invalidation mechanism isn't alive and can't clear them
* if the tuple gets created later. (Bootstrap doesn't do UPDATEs,
* so it doesn't need cache inval for that.)
*/ */
if (ct == NULL) if (ct == NULL)
{ {
if (IsBootstrapProcessingMode())
return NULL;
ntp = build_dummy_tuple(cache, cache->cc_nkeys, cur_skey); ntp = build_dummy_tuple(cache, cache->cc_nkeys, cur_skey);
ct = CatalogCacheCreateEntry(cache, ntp, ct = CatalogCacheCreateEntry(cache, ntp,
hashValue, hashIndex, hashValue, hashIndex,
...@@ -1427,7 +1436,7 @@ SearchCatCacheList(CatCache *cache, ...@@ -1427,7 +1436,7 @@ SearchCatCacheList(CatCache *cache,
relation = heap_open(cache->cc_reloid, AccessShareLock); relation = heap_open(cache->cc_reloid, AccessShareLock);
scandesc = systable_beginscan(relation, scandesc = systable_beginscan(relation,
cache->cc_indname, cache->cc_indexoid,
true, true,
SnapshotNow, SnapshotNow,
nkeys, nkeys,
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/cache/lsyscache.c,v 1.123 2005/04/11 23:06:56 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/cache/lsyscache.c,v 1.124 2005/04/14 20:03:26 tgl Exp $
* *
* NOTES * NOTES
* Eventually, the index information should go through here, too. * Eventually, the index information should go through here, too.
...@@ -931,25 +931,6 @@ get_relname_relid(const char *relname, Oid relnamespace) ...@@ -931,25 +931,6 @@ get_relname_relid(const char *relname, Oid relnamespace)
0, 0); 0, 0);
} }
/*
* get_system_catalog_relid
* Get the OID of a system catalog identified by name.
*/
Oid
get_system_catalog_relid(const char *catname)
{
Oid relid;
relid = GetSysCacheOid(RELNAMENSP,
PointerGetDatum(catname),
ObjectIdGetDatum(PG_CATALOG_NAMESPACE),
0, 0);
if (!OidIsValid(relid))
elog(ERROR, "cache lookup failed for system relation %s", catname);
return relid;
}
#ifdef NOT_USED #ifdef NOT_USED
/* /*
* get_relnatts * get_relnatts
......
This diff is collapsed.
This diff is collapsed.
...@@ -36,7 +36,7 @@ ...@@ -36,7 +36,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/cache/typcache.c,v 1.11 2004/12/31 22:01:25 pgsql Exp $ * $PostgreSQL: pgsql/src/backend/utils/cache/typcache.c,v 1.12 2005/04/14 20:03:26 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -46,7 +46,6 @@ ...@@ -46,7 +46,6 @@
#include "access/heapam.h" #include "access/heapam.h"
#include "access/hash.h" #include "access/hash.h"
#include "access/nbtree.h" #include "access/nbtree.h"
#include "catalog/catname.h"
#include "catalog/indexing.h" #include "catalog/indexing.h"
#include "catalog/pg_am.h" #include "catalog/pg_am.h"
#include "catalog/pg_opclass.h" #include "catalog/pg_opclass.h"
...@@ -328,14 +327,14 @@ lookup_default_opclass(Oid type_id, Oid am_id) ...@@ -328,14 +327,14 @@ lookup_default_opclass(Oid type_id, Oid am_id)
* that we consider all opclasses, regardless of the current search * that we consider all opclasses, regardless of the current search
* path. * path.
*/ */
rel = heap_openr(OperatorClassRelationName, AccessShareLock); rel = heap_open(OperatorClassRelationId, AccessShareLock);
ScanKeyInit(&skey[0], ScanKeyInit(&skey[0],
Anum_pg_opclass_opcamid, Anum_pg_opclass_opcamid,
BTEqualStrategyNumber, F_OIDEQ, BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(am_id)); ObjectIdGetDatum(am_id));
scan = systable_beginscan(rel, OpclassAmNameNspIndex, true, scan = systable_beginscan(rel, OpclassAmNameNspIndexId, true,
SnapshotNow, 1, skey); SnapshotNow, 1, skey);
while (HeapTupleIsValid(tup = systable_getnext(scan))) while (HeapTupleIsValid(tup = systable_getnext(scan)))
......
...@@ -22,7 +22,7 @@ ...@@ -22,7 +22,7 @@
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/backend/utils/init/flatfiles.c,v 1.5 2005/04/14 01:38:20 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/init/flatfiles.c,v 1.6 2005/04/14 20:03:26 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -32,7 +32,6 @@ ...@@ -32,7 +32,6 @@
#include <unistd.h> #include <unistd.h>
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/pg_database.h" #include "catalog/pg_database.h"
#include "catalog/pg_group.h" #include "catalog/pg_group.h"
#include "catalog/pg_namespace.h" #include "catalog/pg_namespace.h"
...@@ -724,11 +723,11 @@ AtEOXact_UpdateFlatFiles(bool isCommit) ...@@ -724,11 +723,11 @@ AtEOXact_UpdateFlatFiles(bool isCommit)
* so get the locks we need before writing anything. * so get the locks we need before writing anything.
*/ */
if (database_file_update_subid != InvalidSubTransactionId) if (database_file_update_subid != InvalidSubTransactionId)
drel = heap_openr(DatabaseRelationName, ExclusiveLock); drel = heap_open(DatabaseRelationId, ExclusiveLock);
if (group_file_update_subid != InvalidSubTransactionId) if (group_file_update_subid != InvalidSubTransactionId)
grel = heap_openr(GroupRelationName, ExclusiveLock); grel = heap_open(GroupRelationId, ExclusiveLock);
if (user_file_update_subid != InvalidSubTransactionId) if (user_file_update_subid != InvalidSubTransactionId)
urel = heap_openr(ShadowRelationName, ExclusiveLock); urel = heap_open(ShadowRelationId, ExclusiveLock);
/* Okay to write the files */ /* Okay to write the files */
if (database_file_update_subid != InvalidSubTransactionId) if (database_file_update_subid != InvalidSubTransactionId)
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/init/miscinit.c,v 1.138 2005/03/18 03:48:49 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/init/miscinit.c,v 1.139 2005/04/14 20:03:26 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -29,7 +29,6 @@ ...@@ -29,7 +29,6 @@
#include <utime.h> #include <utime.h>
#endif #endif
#include "catalog/catname.h"
#include "catalog/pg_shadow.h" #include "catalog/pg_shadow.h"
#include "libpq/libpq-be.h" #include "libpq/libpq-be.h"
#include "miscadmin.h" #include "miscadmin.h"
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/init/postinit.c,v 1.144 2005/03/19 23:27:06 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/init/postinit.c,v 1.145 2005/04/14 20:03:26 tgl Exp $
* *
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
...@@ -22,7 +22,6 @@ ...@@ -22,7 +22,6 @@
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_database.h" #include "catalog/pg_database.h"
#include "catalog/pg_shadow.h" #include "catalog/pg_shadow.h"
...@@ -134,7 +133,7 @@ ReverifyMyDatabase(const char *name) ...@@ -134,7 +133,7 @@ ReverifyMyDatabase(const char *name)
* Because we grab RowShareLock here, we can be sure that dropdb() * Because we grab RowShareLock here, we can be sure that dropdb()
* is not running in parallel with us (any more). * is not running in parallel with us (any more).
*/ */
pgdbrel = heap_openr(DatabaseRelationName, RowShareLock); pgdbrel = heap_open(DatabaseRelationId, RowShareLock);
ScanKeyInit(&key, ScanKeyInit(&key,
Anum_pg_database_datname, Anum_pg_database_datname,
...@@ -537,7 +536,7 @@ ThereIsAtLeastOneUser(void) ...@@ -537,7 +536,7 @@ ThereIsAtLeastOneUser(void)
HeapScanDesc scan; HeapScanDesc scan;
bool result; bool result;
pg_shadow_rel = heap_openr(ShadowRelationName, AccessExclusiveLock); pg_shadow_rel = heap_open(ShadowRelationId, AccessExclusiveLock);
pg_shadow_dsc = RelationGetDescr(pg_shadow_rel); pg_shadow_dsc = RelationGetDescr(pg_shadow_rel);
scan = heap_beginscan(pg_shadow_rel, SnapshotNow, 0, NULL); scan = heap_beginscan(pg_shadow_rel, SnapshotNow, 0, NULL);
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/include/access/genam.h,v 1.49 2005/03/27 23:53:04 tgl Exp $ * $PostgreSQL: pgsql/src/include/access/genam.h,v 1.50 2005/04/14 20:03:27 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -70,7 +70,6 @@ typedef SysScanDescData *SysScanDesc; ...@@ -70,7 +70,6 @@ typedef SysScanDescData *SysScanDesc;
*/ */
extern Relation index_open(Oid relationId); extern Relation index_open(Oid relationId);
extern Relation index_openrv(const RangeVar *relation); extern Relation index_openrv(const RangeVar *relation);
extern Relation index_openr(const char *sysRelationName);
extern void index_close(Relation relation); extern void index_close(Relation relation);
extern bool index_insert(Relation indexRelation, extern bool index_insert(Relation indexRelation,
Datum *values, bool *isnull, Datum *values, bool *isnull,
...@@ -119,7 +118,7 @@ extern void IndexScanEnd(IndexScanDesc scan); ...@@ -119,7 +118,7 @@ extern void IndexScanEnd(IndexScanDesc scan);
* heap-or-index access to system catalogs (in genam.c) * heap-or-index access to system catalogs (in genam.c)
*/ */
extern SysScanDesc systable_beginscan(Relation heapRelation, extern SysScanDesc systable_beginscan(Relation heapRelation,
const char *indexRelname, Oid indexId,
bool indexOK, bool indexOK,
Snapshot snapshot, Snapshot snapshot,
int nkeys, ScanKey key); int nkeys, ScanKey key);
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/include/access/heapam.h,v 1.98 2005/03/21 01:24:04 tgl Exp $ * $PostgreSQL: pgsql/src/include/access/heapam.h,v 1.99 2005/04/14 20:03:27 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -126,12 +126,10 @@ extern Datum fastgetattr(HeapTuple tup, int attnum, TupleDesc tupleDesc, ...@@ -126,12 +126,10 @@ extern Datum fastgetattr(HeapTuple tup, int attnum, TupleDesc tupleDesc,
extern Relation relation_open(Oid relationId, LOCKMODE lockmode); extern Relation relation_open(Oid relationId, LOCKMODE lockmode);
extern Relation conditional_relation_open(Oid relationId, LOCKMODE lockmode, bool nowait); extern Relation conditional_relation_open(Oid relationId, LOCKMODE lockmode, bool nowait);
extern Relation relation_openrv(const RangeVar *relation, LOCKMODE lockmode); extern Relation relation_openrv(const RangeVar *relation, LOCKMODE lockmode);
extern Relation relation_openr(const char *sysRelationName, LOCKMODE lockmode);
extern void relation_close(Relation relation, LOCKMODE lockmode); extern void relation_close(Relation relation, LOCKMODE lockmode);
extern Relation heap_open(Oid relationId, LOCKMODE lockmode); extern Relation heap_open(Oid relationId, LOCKMODE lockmode);
extern Relation heap_openrv(const RangeVar *relation, LOCKMODE lockmode); extern Relation heap_openrv(const RangeVar *relation, LOCKMODE lockmode);
extern Relation heap_openr(const char *sysRelationName, LOCKMODE lockmode);
#define heap_close(r,l) relation_close(r,l) #define heap_close(r,l) relation_close(r,l)
......
/*-------------------------------------------------------------------------
*
* catname.h
* POSTGRES system catalog relation name definitions.
*
*
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* $PostgreSQL: pgsql/src/include/catalog/catname.h,v 1.35 2005/04/14 01:38:20 tgl Exp $
*
*-------------------------------------------------------------------------
*/
#ifndef CATNAME_H
#define CATNAME_H
#define AggregateRelationName "pg_aggregate"
#define AccessMethodRelationName "pg_am"
#define AccessMethodOperatorRelationName "pg_amop"
#define AccessMethodProcedureRelationName "pg_amproc"
#define AttributeRelationName "pg_attribute"
#define CastRelationName "pg_cast"
#define ConstraintRelationName "pg_constraint"
#define ConversionRelationName "pg_conversion"
#define DatabaseRelationName "pg_database"
#define DependRelationName "pg_depend"
#define DescriptionRelationName "pg_description"
#define GroupRelationName "pg_group"
#define IndexRelationName "pg_index"
#define InheritsRelationName "pg_inherits"
#define LanguageRelationName "pg_language"
#define LargeObjectRelationName "pg_largeobject"
#define ListenerRelationName "pg_listener"
#define NamespaceRelationName "pg_namespace"
#define OperatorClassRelationName "pg_opclass"
#define OperatorRelationName "pg_operator"
#define ProcedureRelationName "pg_proc"
#define RelationRelationName "pg_class"
#define RewriteRelationName "pg_rewrite"
#define ShadowRelationName "pg_shadow"
#define StatisticRelationName "pg_statistic"
#define TableSpaceRelationName "pg_tablespace"
#define TypeRelationName "pg_type"
#define AttrDefaultRelationName "pg_attrdef"
#define TriggerRelationName "pg_trigger"
#endif /* CATNAME_H */
This diff is collapsed.
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/include/utils/catcache.h,v 1.53 2005/03/25 18:30:28 tgl Exp $ * $PostgreSQL: pgsql/src/include/utils/catcache.h,v 1.54 2005/04/14 20:03:27 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -36,8 +36,8 @@ typedef struct catcache ...@@ -36,8 +36,8 @@ typedef struct catcache
int id; /* cache identifier --- see syscache.h */ int id; /* cache identifier --- see syscache.h */
struct catcache *cc_next; /* link to next catcache */ struct catcache *cc_next; /* link to next catcache */
const char *cc_relname; /* name of relation the tuples come from */ const char *cc_relname; /* name of relation the tuples come from */
const char *cc_indname; /* name of index matching cache keys */
Oid cc_reloid; /* OID of relation the tuples come from */ Oid cc_reloid; /* OID of relation the tuples come from */
Oid cc_indexoid; /* OID of index matching cache keys */
bool cc_relisshared; /* is relation shared across databases? */ bool cc_relisshared; /* is relation shared across databases? */
TupleDesc cc_tupdesc; /* tuple descriptor (copied from reldesc) */ TupleDesc cc_tupdesc; /* tuple descriptor (copied from reldesc) */
int cc_reloidattr; /* AttrNumber of relation OID attr, or 0 */ int cc_reloidattr; /* AttrNumber of relation OID attr, or 0 */
...@@ -164,7 +164,7 @@ extern DLLIMPORT MemoryContext CacheMemoryContext; ...@@ -164,7 +164,7 @@ extern DLLIMPORT MemoryContext CacheMemoryContext;
extern void CreateCacheMemoryContext(void); extern void CreateCacheMemoryContext(void);
extern void AtEOXact_CatCache(bool isCommit); extern void AtEOXact_CatCache(bool isCommit);
extern CatCache *InitCatCache(int id, const char *relname, const char *indname, extern CatCache *InitCatCache(int id, Oid reloid, Oid indexoid,
int reloidattr, int reloidattr,
int nkeys, const int *key); int nkeys, const int *key);
extern void InitCatCachePhase2(CatCache *cache); extern void InitCatCachePhase2(CatCache *cache);
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/include/utils/lsyscache.h,v 1.97 2005/04/11 23:06:56 tgl Exp $ * $PostgreSQL: pgsql/src/include/utils/lsyscache.h,v 1.98 2005/04/14 20:03:27 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -62,7 +62,6 @@ extern bool get_func_retset(Oid funcid); ...@@ -62,7 +62,6 @@ extern bool get_func_retset(Oid funcid);
extern bool func_strict(Oid funcid); extern bool func_strict(Oid funcid);
extern char func_volatile(Oid funcid); extern char func_volatile(Oid funcid);
extern Oid get_relname_relid(const char *relname, Oid relnamespace); extern Oid get_relname_relid(const char *relname, Oid relnamespace);
extern Oid get_system_catalog_relid(const char *catname);
extern char *get_rel_name(Oid relid); extern char *get_rel_name(Oid relid);
extern Oid get_rel_namespace(Oid relid); extern Oid get_rel_namespace(Oid relid);
extern Oid get_rel_type_id(Oid relid); extern Oid get_rel_type_id(Oid relid);
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/include/utils/relcache.h,v 1.49 2005/04/14 01:38:22 tgl Exp $ * $PostgreSQL: pgsql/src/include/utils/relcache.h,v 1.50 2005/04/14 20:03:27 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -20,7 +20,6 @@ ...@@ -20,7 +20,6 @@
* relation lookup routines * relation lookup routines
*/ */
extern Relation RelationIdGetRelation(Oid relationId); extern Relation RelationIdGetRelation(Oid relationId);
extern Relation RelationSysNameGetRelation(const char *relationName);
/* finds an existing cache entry, but won't make a new one */ /* finds an existing cache entry, but won't make a new one */
extern Relation RelationIdCacheGetRelation(Oid relationId); extern Relation RelationIdCacheGetRelation(Oid relationId);
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
* procedural language * procedural language
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_comp.c,v 1.87 2005/04/07 14:53:04 tgl Exp $ * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_comp.c,v 1.88 2005/04/14 20:03:27 tgl Exp $
* *
* This software is copyrighted by Jan Wieck - Hamburg. * This software is copyrighted by Jan Wieck - Hamburg.
* *
...@@ -42,7 +42,6 @@ ...@@ -42,7 +42,6 @@
#include "pl.tab.h" #include "pl.tab.h"
#include "access/heapam.h" #include "access/heapam.h"
#include "catalog/catname.h"
#include "catalog/namespace.h" #include "catalog/namespace.h"
#include "catalog/pg_attribute.h" #include "catalog/pg_attribute.h"
#include "catalog/pg_attrdef.h" #include "catalog/pg_attrdef.h"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment