Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
150a9df5
Commit
150a9df5
authored
Apr 10, 2014
by
Heikki Linnakangas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix a few more misc typos in comments.
parent
85c6bba2
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
7 deletions
+7
-7
src/backend/replication/logical/snapbuild.c
src/backend/replication/logical/snapbuild.c
+6
-6
src/include/access/htup.h
src/include/access/htup.h
+1
-1
No files found.
src/backend/replication/logical/snapbuild.c
View file @
150a9df5
...
...
@@ -29,7 +29,7 @@
* As the percentage of transactions modifying the catalog normally is fairly
* small in comparisons to ones only manipulating user data, we keep track of
* the committed catalog modifying ones inside (xmin, xmax) instead of keeping
* track of all running transactions like its done in a normal snapshot. Note
* track of all running transactions like it
'
s done in a normal snapshot. Note
* that we're generally only looking at transactions that have acquired an
* xid. That is we keep a list of transactions between snapshot->(xmin, xmax)
* that we consider committed, everything else is considered aborted/in
...
...
@@ -81,7 +81,7 @@
*
* Initially the machinery is in the START stage. When a xl_running_xacts
* record is read that is sufficiently new (above the safe xmin horizon),
* there's a state trans
a
tion. If there were no running xacts when the
* there's a state trans
i
tion. If there were no running xacts when the
* runnign_xacts record was generated, we'll directly go into CONSISTENT
* state, otherwise we'll switch to the FULL_SNAPSHOT state. Having a full
* snapshot means that all transactions that start henceforth can be decoded
...
...
@@ -412,7 +412,7 @@ SnapBuildSnapDecRefcount(Snapshot snap)
Assert
(
snap
->
active_count
);
/* slightly more likely, so its checked even without casserts */
/* slightly more likely, so it
'
s checked even without casserts */
if
(
snap
->
copied
)
elog
(
ERROR
,
"cannot free a copied snapshot"
);
...
...
@@ -451,7 +451,7 @@ SnapBuildBuildSnapshot(SnapBuild *builder, TransactionId xid)
*
* In the 'xip' array we store transactions that have to be treated as
* committed. Since we will only ever look at tuples from transactions
* that have modified the catalog its more efficient to store those few
* that have modified the catalog it
'
s more efficient to store those few
* that exist between xmin and xmax (frequently there are none).
*
* Snapshots that are used in transactions that have modified the catalog
...
...
@@ -1117,7 +1117,7 @@ SnapBuildProcessRunningXacts(SnapBuild *builder, XLogRecPtr lsn, xl_running_xact
SnapBuildSerialize
(
builder
,
lsn
);
/*
* Update range of interesting xids base
d
on the running xacts
* Update range of interesting xids base
d
on the running xacts
* information. We don't increase ->xmax using it, because once we are in
* a consistent state we can do that ourselves and much more efficiently
* so, because we only need to do it for catalog transactions since we
...
...
@@ -1125,7 +1125,7 @@ SnapBuildProcessRunningXacts(SnapBuild *builder, XLogRecPtr lsn, xl_running_xact
*
* NB: Because of that xmax can be lower than xmin, because we only
* increase xmax when a catalog modifying transaction commits. While odd
* looking, its correct and actually more efficient this way since we hit
* looking, it
'
s correct and actually more efficient this way since we hit
* fast paths in tqual.c.
*/
builder
->
xmin
=
running
->
oldestRunningXid
;
...
...
src/include/access/htup.h
View file @
150a9df5
...
...
@@ -16,7 +16,7 @@
#include "storage/itemptr.h"
/* typedefs and forward declarations for structs defined in htup.h */
/* typedefs and forward declarations for structs defined in htup
_details
.h */
typedef
struct
HeapTupleHeaderData
HeapTupleHeaderData
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment