Commit 1198d633 authored by Tom Lane's avatar Tom Lane

Add some defenses against functions declared to return set that don't

actually follow the protocol; per example from Kris Jurka.
parent 4744c1a0
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.177 2005/05/06 17:24:53 tgl Exp $ * $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.178 2005/05/09 14:28:39 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -948,7 +948,7 @@ ExecMakeFunctionResult(FuncExprState *fcache, ...@@ -948,7 +948,7 @@ ExecMakeFunctionResult(FuncExprState *fcache,
* returns set, save the current argument values to re-use * returns set, save the current argument values to re-use
* on the next call. * on the next call.
*/ */
if (fcache->func.fn_retset) if (fcache->func.fn_retset && *isDone == ExprMultipleResult)
{ {
memcpy(&fcache->setArgs, &fcinfo, sizeof(fcinfo)); memcpy(&fcache->setArgs, &fcinfo, sizeof(fcinfo));
fcache->setHasSetArg = hasSetArg; fcache->setHasSetArg = hasSetArg;
...@@ -967,7 +967,8 @@ ExecMakeFunctionResult(FuncExprState *fcache, ...@@ -967,7 +967,8 @@ ExecMakeFunctionResult(FuncExprState *fcache,
* Make sure we say we are returning a set, even if the * Make sure we say we are returning a set, even if the
* function itself doesn't return sets. * function itself doesn't return sets.
*/ */
*isDone = ExprMultipleResult; if (hasSetArg)
*isDone = ExprMultipleResult;
break; break;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment