Skip to content

P
Postgres FD Implementation
Commit 1129c2b0 authored by Simon Riggs's avatar Simon Riggs
Browse files
Options

Correct comment in GetConflictingVirtualXIDs() 

We use Share lock because it is safe to do so.
parent 00347575
Hide whitespace changes
Inline Side-by-side
Showing with 5 additions and 2 deletions
src/backend/storage/ipc/procarray.c
View file @ 1129c2b0
...@@ -2540,8 +2540,11 @@ GetConflictingVirtualXIDs(TransactionId limitXmin, Oid dbOid) ...@@ -2540,8 +2540,11 @@ GetConflictingVirtualXIDs(TransactionId limitXmin, Oid dbOid)
/* /*
* We ignore an invalid pxmin because this means that backend has * We ignore an invalid pxmin because this means that backend has
* no snapshot and cannot get another one while we hold exclusive * no snapshot currently. We hold a Share lock to avoid contention
* lock. * with users taking snapshots. That is not a problem because
* the current xmin is always at least one higher than the latest
* removed xid, so any new snapshot would never conflict with the
* test here.
*/ */
if (!TransactionIdIsValid(limitXmin) || if (!TransactionIdIsValid(limitXmin) ||
(TransactionIdIsValid(pxmin) && !TransactionIdFollows(pxmin, limitXmin))) (TransactionIdIsValid(pxmin) && !TransactionIdFollows(pxmin, limitXmin)))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment