Commit 0f574a7a authored by Tom Lane's avatar Tom Lane

Allow up to 3 "-P 1" reports per thread in pgbench run of 2 seconds.

There seems to be some considerable imprecision in the timing of -P
progress reports.  Nominally each thread ought to produce 2 reports
in this test, but about 10% of the time we only get one, and 1% of
the time we get three, as per buildfarm results so far.  Pending
further investigation, treat the last case as a "pass".  (I, tgl,
am suspicious that this still might not be lax enough, now that it's
obvious that the behavior is load-dependent; but there's not yet
buildfarm evidence to confirm that suspicion.)

Fabien Coelho

Discussion: https://postgr.es/m/26654.1505232433@sss.pgh.pa.us
parent 5d3cad56
......@@ -462,8 +462,9 @@ pgbench(
[ qr{vacuum}, qr{progress: 1\b} ],
'pgbench progress');
# $nthreads threads, 2 seconds, sometimes only one aggregated line is written
check_pgbench_logs('001_pgbench_log_1', $nthreads, 1, 2,
# $nthreads threads, 2 seconds, but due to timing imprecision we might get
# only 1 or as many as 3 progress reports per thread.
check_pgbench_logs('001_pgbench_log_1', $nthreads, 1, 3,
qr{^\d+ \d{1,2} \d+ \d+ \d+ \d+ \d+ \d+ \d+ \d+ \d+$});
# with sampling rate
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment