• Neil Conway's avatar
    Fix several memory leaks when rescanning SRFs. Arrange for an SRF's · ff428cde
    Neil Conway authored
    "multi_call_ctx" to be a distinct sub-context of the EState's per-query
    context, and delete the multi_call_ctx as soon as the SRF finishes
    execution. This avoids leaking SRF memory until the end of the current
    query, which is particularly egregious when the SRF is scanned
    multiple times. This change also fixes a leak of the fields of the
    AttInMetadata struct in shutdown_MultiFuncCall().
    
    Also fix a leak of the SRF result TupleDesc when rescanning a
    FunctionScan node. The TupleDesc is allocated in the per-query context
    for every call to ExecMakeTableFunctionResult(), so we should free it
    after calling that function. Since the SRF might choose to return
    a non-expendable TupleDesc, we only free the TupleDesc if it is
    not being reference-counted.
    
    Backpatch to 8.3 and 8.2 stable branches.
    ff428cde
nodeFunctionscan.c 10.4 KB