• Tom Lane's avatar
    Remove ruleutils.c's special case for BIT [VARYING] literals. · fedc97cd
    Tom Lane authored
    Up to now, get_const_expr() insisted on prefixing BIT and VARBIT
    literals with 'B'.  That's not really necessary, because we always
    append explicit-cast syntax to identify the constant's type.
    Moreover, it's subtly wrong for VARBIT, because the parser will
    interpret B'...' as '...'::"bit"; see make_const() which explicitly
    assigns type BITOID for a T_BitString literal.  So what had been
    a simple VARBIT literal is reconstructed as ('...'::"bit")::varbit,
    which is not the same thing, at least not before constant folding.
    This results in odd differences after dump/restore, as complained
    of by the patch submitter, and it could result in actual failures in
    partitioning or inheritance DDL operations (see commit 542320c2,
    which repaired similar misbehaviors for some other data types).
    
    Fixing it is pretty easy: just remove the special case and let the
    default code path handle these types.  We could have kept the special
    case for BIT only, but there seems little point in that.
    
    Like the previous patch, I judge that back-patching this into stable
    branches wouldn't be a good idea.  However, it seems not quite too
    late for v11, so let's fix it there.
    
    Paul Guo, reviewed by Davy Machado and John Naylor, minor adjustments
    by me
    
    Discussion: https://postgr.es/m/CABQrizdTra=2JEqA6+Ms1D1k1Kqw+aiBBhC9TreuZRX2JzxLAA@mail.gmail.com
    fedc97cd
varbit.out 1.51 KB