• Heikki Linnakangas's avatar
    In WAL replay, restore GIN metapage unconditionally to avoid torn page. · fecfc2b9
    Heikki Linnakangas authored
    We don't take a full-page image of the GIN metapage; instead, the WAL record
    contains all the information required to reconstruct it from scratch. But
    to avoid torn page hazards, we must re-initialize it from the WAL record
    every time, even if it already has a greater LSN, similar to how normal full
    page images are restored.
    
    This was highly unlikely to cause any problems in practice, because the GIN
    metapage is small. We rely on an update smaller than a 512 byte disk sector
    to be atomic elsewhere, at least in pg_control. But better safe than sorry,
    and this would be easy to overlook if more fields are added to the metapage
    so that it's no longer small.
    
    Reported by Noah Misch. Backpatch to all supported versions.
    fecfc2b9
ginxlog.c 21.5 KB