• Tom Lane's avatar
    Include typmod when complaining about inherited column type mismatches. · fec1ad94
    Tom Lane authored
    MergeAttributes() rejects cases where columns to be merged have the same
    type but different typmod, which is correct; but the error message it
    printed didn't show either typmod, which is unhelpful.  Changing this
    requires using format_type_with_typemod() in place of TypeNameToString(),
    which will have some minor side effects on the way some type names are
    printed, but on balance this is an improvement: the old code sometimes
    printed one type according to one set of rules and the other type according
    to the other set, which could be confusing in its own way.
    
    Oddly, there were no regression test cases covering any of this behavior,
    so add some.
    
    Complaint and fix by Amit Langote
    fec1ad94
alter_table.out 112 KB