• Fujii Masao's avatar
    Avoid using ambiguous word "non-negative" in error messages. · fd90f6ba
    Fujii Masao authored
    The error messages using the word "non-negative" are confusing
    because it's ambiguous about whether it accepts zero or not.
    This commit improves those error messages by replacing it with
    less ambiguous word like "greater than zero" or
    "greater than or equal to zero".
    
    Also this commit added the note about the word "non-negative" to
    the error message style guide, to help writing the new error messages.
    
    When postgres_fdw option fetch_size was set to zero, previously
    the error message "fetch_size requires a non-negative integer value"
    was reported. This error message was outright buggy. Therefore
    back-patch to all supported versions where such buggy error message
    could be thrown.
    
    Reported-by: Hou Zhijie
    Author: Bharath Rupireddy
    Reviewed-by: Kyotaro Horiguchi, Fujii Masao
    Discussion: https://postgr.es/m/OS0PR01MB5716415335A06B489F1B3A8194569@OS0PR01MB5716.jpnprd01.prod.outlook.com
    fd90f6ba
sources.sgml 36.5 KB