• Tom Lane's avatar
    Need to do SPI_push/SPI_pop around expression evaluation in plpgsql. · fc8b81a2
    Tom Lane authored
    We must do this in case the expression evaluation results in calling
    another plpgsql function (or, really, anything using SPI).  I missed
    the need for this when I converted exec_cast_value() from doing a
    simple InputFunctionCall() to doing ExecEvalExpr() in commit 1345cc67.
    There is a SPI_push_conditional in InputFunctionCall(), so that there
    was no bug before that.
    
    Per bug #14414 from Marcos Castedo.  Add a regression test based on his
    example, which was that a plpgsql function in a domain check constraint
    didn't work when assigning to a domain-type variable within plpgsql.
    
    Report: <20161106010947.1387.66380@wrigleys.postgresql.org>
    fc8b81a2
plpgsql.sql 111 KB