• Stephen Frost's avatar
    Clean up range-table building in copy.c · f8519a6a
    Stephen Frost authored
    Commit 804b6b6d added the build of a
    range table in copy.c to initialize the EState es_range_table since it
    can be needed in error paths.  Unfortunately, that commit didn't
    appreciate that some code paths might end up not initializing the rte
    which is used to build the range table.
    
    Fix that and clean up a couple others things along the way- build it
    only once and don't explicitly set it on the !is_from path as it
    doesn't make any sense there (cstate is palloc0'd, so this isn't an
    issue from an initializing standpoint either).
    
    The prior commit went back to 9.0, but this only goes back to 9.1 as
    prior to that the range table build happens immediately after building
    the RTE and therefore doesn't suffer from this issue.
    
    Pointed out by Robert.
    f8519a6a
copy.c 123 KB