• Tom Lane's avatar
    Ensure that expandTableLikeClause() re-examines the same table. · f7f83a55
    Tom Lane authored
    As it stood, expandTableLikeClause() re-did the same relation_openrv
    call that transformTableLikeClause() had done.  However there are
    scenarios where this would not find the same table as expected.
    We hold lock on the LIKE source table, so it can't be renamed or
    dropped, but another table could appear before it in the search path.
    This explains the odd behavior reported in bug #16758 when cloning a
    table as a temp table of the same name.  This case worked as expected
    before commit 50289819 introduced the need to open the source table
    twice, so we should fix it.
    
    To make really sure we get the same table, let's re-open it by OID not
    name.  That requires adding an OID field to struct TableLikeClause,
    which is a little nervous-making from an ABI standpoint, but as long
    as it's at the end I don't think there's any serious risk.
    
    Per bug #16758 from Marc Boeren.  Like the previous patch,
    back-patch to all supported branches.
    
    Discussion: https://postgr.es/m/16758-840e84a6cfab276d@postgresql.org
    f7f83a55
parse_utilcmd.c 127 KB