• Amit Kapila's avatar
    Remove the unnecessary PrepareWrite in pgoutput. · f672df5f
    Amit Kapila authored
    This issue exists from the inception of this code (PG-10) but got exposed
    by the recent commit ce0fdbfe where we are using origins in tablesync
    workers. The problem was that we were sometimes sending the prepare_write
    ('w') message but then the actual message was not being sent and on the
    subscriber side, we always expect a message after prepare_write message
    which led to this bug.
    
    I refrained from backpatching this because there is no way in the core
    code to hit this prior to commit ce0fdbfe and we haven't received any
    complaints so far.
    
    Reported-by: Erik Rijkers
    Author: Amit Kapila and Vignesh C
    Tested-by: Erik Rijkers
    Discussion: https://postgr.es/m/1295168140.139428.1613133237154@webmailclassic.xs4all.nl
    f672df5f
pgoutput.c 33.4 KB