• Tom Lane's avatar
    Fix postgres_fdw failure with whole-row Vars of type RECORD. · f61db909
    Tom Lane authored
    Commit 86dc9005 expects that FDWs can cope with whole-row Vars for
    their tables, even if the Vars are marked with vartype RECORDOID.
    Previously, whole-row Vars generated by the planner had vartype equal
    to the relevant table's rowtype OID.  (The point behind this change is
    to enable sharing of resjunk columns across inheritance child tables.)
    
    It turns out that postgres_fdw fails to cope with this, though through
    bad fortune none of its test cases exposed that.  Things mostly work,
    but when we try to read back a value of such a Var, the expected
    rowtype is not available to record_in().  Fortunately, it's not
    difficult to hack up the tupdesc that controls this process to
    substitute the foreign table's rowtype for RECORDOID.  Thus we can
    solve the runtime problem while still sharing the resjunk column
    with other tables.
    
    Per report from Alexander Pyhalov.
    
    Discussion: https://postgr.es/m/7817fb9ebd6661cdf9b67dec6e129a78@postgrespro.ru
    f61db909
postgres_fdw.out 497 KB