• David Rowley's avatar
    Cache if PathTarget and RestrictInfos contain volatile functions · f58b230e
    David Rowley authored
    Here we aim to reduce duplicate work done by contain_volatile_functions()
    by caching whether PathTargets and RestrictInfos contain any volatile
    functions the first time contain_volatile_functions() is called for them.
    Any future calls for these nodes just use the cached value rather than
    going to the trouble of recursively checking the sub-node all over again.
    Thanks to Tom Lane for the idea.
    
    Any locations in the code which make changes to a PathTarget or
    RestrictInfo which could change the outcome of the volatility check must
    change the cached value back to VOLATILITY_UNKNOWN again.
    contain_volatile_functions() is the only code in charge of setting the
    cache value to either VOLATILITY_VOLATILE or VOLATILITY_NOVOLATILE.
    
    Some existing code does benefit from this additional caching, however,
    this change is mainly aimed at an upcoming patch that must check for
    volatility during the join search.  Repeated volatility checks in that
    case can become very expensive when the join search contains more than a
    few relations.
    
    Author: David Rowley
    Discussion: https://postgr.es/m/3795226.1614059027@sss.pgh.pa.us
    f58b230e
pathnodes.h 109 KB