• Tom Lane's avatar
    Sanitize newlines in object names in "pg_restore -l" output. · f39ddd84
    Tom Lane authored
    Commits 89e0bac8 et al replaced newlines with spaces in object names
    printed in SQL comments, but we neglected to consider that the same
    names are also printed by "pg_restore -l", and a newline would render
    the output unparseable by "pg_restore -L".  Apply the same replacement
    in "-l" output.  Since "pg_restore -L" doesn't actually examine any
    object names, only the dump ID field that starts each line, this is
    enough to fix things for its purposes.
    
    The previous fix was treated as a security issue, and we might have
    done that here as well, except that the issue was reported publicly
    to start with.  Anyway it's hard to see how this could be exploited
    for SQL injection; "pg_restore -L" doesn't do much with the file
    except parse it for leading integers.
    
    Per bug #14587 from Milos Urbanek.  Back-patch to all supported versions.
    
    Discussion: https://postgr.es/m/20170310155318.1425.30483@wrigleys.postgresql.org
    f39ddd84
pg_backup_archiver.c 115 KB