• Tom Lane's avatar
    Extract restriction OR clauses whether or not they are indexable. · f343a880
    Tom Lane authored
    It's possible to extract a restriction OR clause from a join clause that
    has the form of an OR-of-ANDs, if each sub-AND includes a clause that
    mentions only one specific relation.  While PG has been aware of that idea
    for many years, the code previously only did it if it could extract an
    indexable OR clause.  On reflection, though, that seems a silly limitation:
    adding a restriction clause can be a win by reducing the number of rows
    that have to be filtered at the join step, even if we have to test the
    clause as a plain filter clause during the scan.  This should be especially
    useful for foreign tables, where the change can cut the number of rows that
    have to be retrieved from the foreign server; but testing shows it can win
    even on local tables.  Per a suggestion from Robert Haas.
    
    As a heuristic, I made the code accept an extracted restriction clause
    if its estimated selectivity is less than 0.9, which will probably result
    in accepting extracted clauses just about always.  We might need to tweak
    that later based on experience.
    
    Since the code no longer has even a weak connection to Path creation,
    remove orindxpath.c and create a new file optimizer/util/orclauses.c.
    
    There's some additional janitorial cleanup of now-dead code that needs
    to happen, but it seems like that's a fit subject for a separate commit.
    f343a880
Makefile 531 Bytes