• Bruce Momjian's avatar
    Remove unused function SSL_CTX_set_tmp_dh_callback() from libpq: · f1b3d5b0
    Bruce Momjian authored
    In the SSL code in libpq it does some processing with DH parameters:
    
    SSL_CTX_set_tmp_dh_callback()
    
    This function is marked as server use only[1], the client always uses
    the DH parameters in the server, so all the code in the client dealing
    with the DH parameters is useless. This patch removes it.
    
    It's not clear why the code was added in the first place, it's been
    there almost since the beginning[2]. At the time there was a suggestion
    of merging the front-end and backend SSL code, but looking at the
    changes since, that seems unlikely.
    
    As a further example, the s_server program allows you to specify DH
    params, but s_client doesn't. In the GnuTLS documentation under
    gnutls_dh_params_generate2() it says[3]:
    
      Also note that the DH parameters are only useful to servers. Since
      clients use the parameters sent by the server, it's of no use to call
      this in client side.
    f1b3d5b0
fe-secure.c 25.7 KB