• Robert Haas's avatar
    Revert "Allow ON CONFLICT .. DO NOTHING on a partitioned table." · f0523075
    Robert Haas authored
    This reverts commit 8355a011, which
    turns out to have been a misguided effort.  We can't really support
    this in a partitioning hierarchy after all for exactly the reasons
    stated in the documentation removed by that commit.  It's still
    possible to use ON CONFLICT .. DO NOTHING (or for that matter ON
    CONFLICT .. DO UPDATE) on individual partitions if desired, but
    but to allow this on a partitioned table implies that we have some
    way of evaluating uniqueness across the whole partitioning
    hierarchy, which is false.
    
    Shinoda Noriyoshi noticed that the old code was crashing (which we
    could fix, though not in a nice way) and Amit Langote realized
    that this was indicative of a fundamental problem with the commit
    being reverted here.
    
    Discussion: http://postgr.es/m/ff3dc21d-7204-c09c-50ac-cf11a8c45c81@lab.ntt.co.jp
    f0523075
analyze.c 87.7 KB