• Tom Lane's avatar
    Fix Gen_fmgrtab.sh to not rely on hard-wired knowledge of the column numbers · eeee0691
    Tom Lane authored
    in pg_proc.  Also make it not emit duplicate extern declarations, and make it
    a bit more bulletproof in some other small ways.  Likewise fix the equally
    hard-wired, and utterly undocumented, knowledge in the MSVC build scripts.
    For testing purposes and perhaps other uses in future, pull out that portion
    of the MSVC scripts into a standalone perl script equivalent to
    Gen_fmgrtab.sh, and make it generate actually identical output, rather than
    just more-or-less-the-same output.
    
    Motivated by looking at Pavel's variadic function patch.  Whether or not
    that gets accepted, we can be sure that pg_proc's column set will change
    again in the future; it's time to not have to deal with this gotcha.
    eeee0691
Gen_fmgrtab.pl 5.37 KB