• Tom Lane's avatar
    Fix pg_dump's handling of DROP DATABASE commands in --clean mode. · edef20f6
    Tom Lane authored
    In commit 4317e024, I accidentally broke
    this behavior while rearranging code to ensure that --create wouldn't
    affect whether a DATABASE entry gets put into archive-format output.
    Thus, 9.2 would issue a DROP DATABASE command in --clean mode, which is
    either useless or dangerous depending on the usage scenario.
    It should not do that, and no longer does.
    
    A bright spot is that this refactoring makes it easy to allow the
    combination of --clean and --create to work sensibly, ie, emit DROP
    DATABASE then CREATE DATABASE before reconnecting.  Ordinarily we'd
    consider that a feature addition and not back-patch it, but it seems
    silly to not include the extra couple of lines required in the 9.2
    version of the code.
    
    Per report from Guillaume Lelarge, though this is slightly more extensive
    than his proposed patch.
    edef20f6
pg_dump.sgml 41.7 KB