• Tom Lane's avatar
    Guard against empty buffer in gets_fromFile()'s check for a newline. · ed0b228d
    Tom Lane authored
    Per the fgets() specification, it cannot return without reading some data
    unless it reports EOF or error.  So the code here assumed that the data
    buffer would necessarily be nonempty when we go to check for a newline
    having been read.  However, Agostino Sarubbo noticed that this could fail
    to be true if the first byte of the data is a NUL (\0).  The fgets() API
    doesn't really work for embedded NULs, which is something I don't feel
    any great need for us to worry about since we generally don't allow NULs
    in SQL strings anyway.  But we should not access off the end of our own
    buffer if the case occurs.  Normally this would just be a harmless read,
    but if you were unlucky the byte before the buffer would contain '\n'
    and we'd overwrite it with '\0', and if you were really unlucky that
    might be valuable data and psql would crash.
    
    Agostino reported this to pgsql-security, but after discussion we concluded
    that it isn't worth treating as a security bug; if you can control the
    input to psql you can do far more interesting things than just maybe-crash
    it.  Nonetheless, it is a bug, so back-patch to all supported versions.
    ed0b228d
input.c 12.7 KB