• Fujii Masao's avatar
    Forbid invalid combination of options in pg_basebackup. · ecbdc4c5
    Fujii Masao authored
    Commit 56c7d8d4 allowed pg_basebackup
    to stream WAL in tar mode. But there is the restriction that WAL
    streaming in tar mode works only when the value - (dash) is not
    specified as output directory. This means that the combination of
    three options "-D -", "-F t" and "-X stream" is invalid. However,
    previously, even when those options were specified at the same time,
    pg_basebackup background process unexpectedly started streaming WAL.
    And then it exited with an error.
    
    This commit changes pg_basebackup so that it errors out on such
    invalid combination of options at the beginning.
    
    Reviewed by Magnus Hagander, and patch by me.
    ecbdc4c5
pg_basebackup.c 58.3 KB