• Etsuro Fujita's avatar
    Disable asynchronous execution if using gating Result nodes. · ebb79024
    Etsuro Fujita authored
    mark_async_capable_plan(), which is called from create_append_plan() to
    determine whether subplans are async-capable, failed to take into
    account that the given subplan created from a given subpath might
    include a gating Result node if the subpath is a SubqueryScanPath or
    ForeignPath, causing a segmentation fault there when the subplan created
    from a SubqueryScanPath includes the Result node, or causing
    ExecAsyncRequest() to throw an error about an unrecognized node type
    when the subplan created from a ForeignPath includes the Result node,
    because in the latter case the Result node was unintentionally
    considered as async-capable, but we don't currently support executing
    Result nodes asynchronously.  Fix by modifying mark_async_capable_plan()
    to disable asynchronous execution in such cases.  Also, adjust code in
    the ProjectionPath case in mark_async_capable_plan(), for consistency
    with other cases, and adjust/improve comments there.
    
    is_async_capable_path() added in commit 27e1f145, which was rewritten
    to mark_async_capable_plan() in a later commit, has the same issue,
    causing the error at execution mentioned above, so back-patch to v14
    where the aforesaid commit went in.
    
    Per report from Justin Pryzby.
    
    Etsuro Fujita, reviewed by Zhihong Yu and Justin Pryzby.
    
    Discussion: https://postgr.es/m/20220408124338.GK24419%40telsasoft.com
    ebb79024
postgres_fdw.out 514 KB