• Andres Freund's avatar
    Zero padding in replication origin's checkpointed on disk-state. · eb97aa7e
    Andres Freund authored
    This seems to be largely cosmetic, avoiding valgrind bleats and the
    like. The uninitialized padding influences the CRC of the on-disk
    entry, but because it's also used when verifying the CRC, that doesn't
    cause spurious failures.  Backpatch nonetheless.
    
    It's a bit unfortunate that contrib/test_decoding/sql/replorigin.sql
    doesn't exercise the checkpoint path, but checkpoints are fairly
    expensive on weaker machines, and we'd have to stop/start for that to
    be meaningful.
    
    Author: Andres Freund
    Discussion: https://postgr.es/m/20170422183123.w2jgiuxtts7qrqaq@alap3.anarazel.de
    Backpatch: 9.5, where replication origins were introduced
    eb97aa7e
origin.c 38.6 KB