• Heikki Linnakangas's avatar
    Remove support for password_encryption='off' / 'plain'. · eb61136d
    Heikki Linnakangas authored
    Storing passwords in plaintext hasn't been a good idea for a very long
    time, if ever. Now seems like a good time to finally forbid it, since we're
    messing with this in PostgreSQL 10 anyway.
    
    Remove the CREATE/ALTER USER UNENCRYPTED PASSSWORD 'foo' syntax, since
    storing passwords unencrypted is no longer supported. ENCRYPTED PASSWORD
    'foo' is still accepted, but ENCRYPTED is now just a noise-word, it does
    the same as just PASSWORD 'foo'.
    
    Likewise, remove the --unencrypted option from createuser, but accept
    --encrypted as a no-op for backward compatibility. AFAICS, --encrypted was
    a no-op even before this patch, because createuser encrypted the password
    before sending it to the server even if --encrypted was not specified. It
    added the ENCRYPTED keyword to the SQL command, but since the password was
    already in encrypted form, it didn't make any difference. The documentation
    was not clear on whether that was intended or not, but it's moot now.
    
    Also, while password_encryption='on' is still accepted as an alias for
    'md5', it is now marked as hidden, so that it is not listed as an accepted
    value in error hints, for example. That's not directly related to removing
    'plain', but it seems better this way.
    
    Reviewed by Michael Paquier
    
    Discussion: https://www.postgresql.org/message-id/16e9b768-fd78-0b12-cfc1-7b6b7f238fde@iki.fi
    eb61136d
001_password.pl 2.43 KB