• Tom Lane's avatar
    Fix failure to check whether a rowtype's component types are sortable. · ea8e42f3
    Tom Lane authored
    The existence of a btree opclass accepting composite types caused us to
    assume that every composite type is sortable.  This isn't true of course;
    we need to check if the column types are all sortable.  There was logic
    for this for the case of array comparison (ie, check that the element
    type is sortable), but we missed the point for rowtypes.  Per Teodor's
    report of an ANALYZE failure for an unsortable composite type.
    
    Rather than just add some more ad-hoc logic for this, I moved knowledge of
    the issue into typcache.c.  The typcache will now only report out array_eq,
    record_cmp, and friends as usable operators if the array or composite type
    will work with those functions.
    
    Unfortunately we don't have enough info to do this for anonymous RECORD
    types; in that case, just assume it will work, and take the runtime failure
    as before if it doesn't.
    
    This patch might be a candidate for back-patching at some point, but
    given the lack of complaints from the field, I'd rather just test it in
    HEAD for now.
    
    Note: most of the places touched in this patch will need further work
    when we get around to supporting hashing of record types.
    ea8e42f3
parse_oper.c 30.6 KB