• Tomas Vondra's avatar
    Build inherited extended stats on partitioned tables · ea212bd9
    Tomas Vondra authored
    Commit 859b3003de disabled building of extended stats for inheritance
    trees, to prevent updating the same catalog row twice. While that
    resolved the issue, it also means there are no extended stats for
    declaratively partitioned tables, because there are no data in the
    non-leaf relations.
    
    That also means declaratively partitioned tables were not affected by
    the issue 859b3003de addressed, which means this is a regression
    affecting queries that calculate estimates for the whole inheritance
    tree as a whole (which includes e.g. GROUP BY queries).
    
    But because partitioned tables are empty, we can invert the condition
    and build statistics only for the case with inheritance, without losing
    anything. And we can consider them when calculating estimates.
    
    It may be necessary to run ANALYZE on partitioned tables, to collect
    proper statistics. For declarative partitioning there should no prior
    statistics, and it might take time before autoanalyze is triggered. For
    tables partitioned by inheritance the statistics may include data from
    child relations (if built 859b3003de), contradicting the current code.
    
    Report and patch by Justin Pryzby, minor fixes and cleanup by me.
    Backpatch all the way back to PostgreSQL 10, where extended statistics
    were introduced (same as 859b3003de).
    
    Author: Justin Pryzby
    Reported-by: Justin Pryzby
    Backpatch-through: 10
    Discussion: https://postgr.es/m/20210923212624.GI831%40telsasoft.com
    ea212bd9
stats_ext.out 112 KB