• Tom Lane's avatar
    Clean up/tighten up coercibility checks in opr_sanity regression test. · e9f42d52
    Tom Lane authored
    With the removal of the old abstime type, there are no longer any cases
    in this test where we need to use the weaker castcontext-ignoring form
    of binary coercibility check.  (The other major source of such headaches,
    apparently-incompatible hash functions, is now hashvalidate()'s problem
    not this test script's problem.)  Hence, just use binary_coercible()
    everywhere, and remove the comments explaining why we don't do so ---
    which were broken anyway by cda6a8d0.
    
    I left physically_coercible() in place but renamed it to better
    match what it's actually testing, and added some comments.
    
    Also, in test queries that have an assumption about the maximum number
    of function arguments they need to handle, add a clause to make them fail
    if someday there's a relevant function with more arguments.  Otherwise
    we're likely not to notice that we need to extend the queries.
    
    Discussion: https://postgr.es/m/27637.1539388060@sss.pgh.pa.us
    e9f42d52
opr_sanity.sql 50 KB