• Tom Lane's avatar
    Fix postgres_fdw to cope with duplicate GROUP BY entries. · e9f2703a
    Tom Lane authored
    Commit 7012b132, which added the ability to push down aggregates and
    grouping to the remote server, wasn't careful to ensure that the remote
    server would have the same idea we do about which columns are the grouping
    columns, in cases where there are textually identical GROUP BY expressions.
    Such cases typically led to "targetlist item has multiple sortgroupref
    labels" errors.
    
    To fix this reliably, switch over to using "GROUP BY column-number" syntax
    rather than "GROUP BY expression" in transmitted queries, and adjust
    foreign_grouping_ok() to be more careful about duplicating the sortgroupref
    labeling of the local pathtarget.
    
    Per bug #14890 from Sean Johnston.  Back-patch to v10 where the buggy code
    was introduced.
    
    Jeevan Chalke, reviewed by Ashutosh Bapat
    
    Discussion: https://postgr.es/m/20171107134948.1508.94783@wrigleys.postgresql.org
    e9f2703a
postgres_fdw.sql 82.5 KB