• Tom Lane's avatar
    Fix dumping of views that are just VALUES(...) but have column aliases. · e9f1c01b
    Tom Lane authored
    The "simple" path for printing VALUES clauses doesn't work if we need
    to attach nondefault column aliases, because there's noplace to do that
    in the minimal VALUES() syntax.  So modify get_simple_values_rte() to
    detect nondefault aliases and treat that as a non-simple case.  This
    further exposes that the "non-simple" path never actually worked;
    it didn't produce valid syntax.  Fix that too.  Per bug #12789 from
    Curtis McEnroe, and analysis by Andrew Gierth.
    
    Back-patch to all supported branches.  Before 9.3, this also requires
    back-patching the part of commit 092d7ded
    that created get_simple_values_rte() to begin with; inserting the extra
    test into the old factorization of that logic would've been too messy.
    e9f1c01b
rules.out 95.5 KB