• Tom Lane's avatar
    Do unlocked prechecks in bufmgr.c loops that scan the whole buffer pool. · e8d029a3
    Tom Lane authored
    DropRelFileNodeBuffers, DropDatabaseBuffers, FlushRelationBuffers, and
    FlushDatabaseBuffers have to scan the whole shared_buffers pool because
    we have no index structure that would find the target buffers any more
    efficiently than that.  This gets expensive with large NBuffers.  We can
    shave some cycles from these loops by prechecking to see if the current
    buffer is interesting before we acquire the buffer header lock.
    Ordinarily such a test would be unsafe, but in these cases it should be
    safe because we are already assuming that the caller holds a lock that
    prevents any new target pages from being loaded into the buffer pool
    concurrently.  Therefore, no buffer tag should be changing to a value of
    interest, only away from a value of interest.  So a false negative match
    is impossible, while a false positive is safe because we'll recheck after
    acquiring the buffer lock.  Initial testing says that this speeds these
    loops by a factor of 2X to 3X on common Intel hardware.
    
    Patch for DropRelFileNodeBuffers by Jeff Janes (based on an idea of
    Heikki's); extended to the remaining sequential scans by Tom Lane
    e8d029a3
bufmgr.c 84.9 KB