• Tomas Vondra's avatar
    Fix handling of opclauses in extended statistics · e8b6ae21
    Tomas Vondra authored
    We expect opclauses to have exactly one Var and one Const, but the code
    was checking the Const by calling is_pseudo_constant_clause() which is
    incorrect - we need a proper constant.
    
    Fixed by using plain IsA(x,Const) to check type of the node. We need to
    do these checks in two places, so move it into a separate function that
    can be called in both places.
    
    Reported by Andreas Seltenreich, based on crash reported by sqlsmith.
    
    Backpatch to v12, where this code was introduced.
    
    Discussion: https://postgr.es/m/8736jdhbhc.fsf%40ansel.ydns.eu
    Backpatch-to: 12
    e8b6ae21
extended_stats.c 34.8 KB