• Michael Paquier's avatar
    Include ALTER INDEX SET STATISTICS in pg_dump · e4fca461
    Michael Paquier authored
    The new grammar pattern of ALTER INDEX SET STATISTICS able to use column
    numbers on top of the existing column names introduced by commit 5b6d13ee
    forgot to add support for the feature in pg_dump, so defining statistics
    on index columns was missing from the dumps, potentially causing silent
    planning problems with a subsequent restore.
    
    pg_dump ought to not use column names in what it generates as these are
    automatically generated by the server and could conflict with real
    relation attributes with matching patterns.  "expr" and "exprN", N
    incremented automatically after the creation of the first one, are used
    as default attribute names for index expressions, and that could easily
    match what is defined in other relations, causing the dumps to fail if
    some of those attributes are renamed at some point.  So to avoid any
    problems, the new grammar with column numbers gets used.
    
    Reported-by: Ronan Dunklau
    Author: Michael Paquier
    Reviewed-by: Tom Lane, Adrien Nayrat, Amul Sul
    Discussion: https://postgr.es/m/CAARsnT3UQ4V=yDNW468w8RqHfYiY9mpn2r_c5UkBJ97NAApUEw@mail.gmail.com
    Backpatch-through: 11, where the new syntax has been introduced.
    e4fca461
pg_dump.h 21.9 KB