• Michael Paquier's avatar
    Add proper errcodes to new error messages for read() failures · e41d0a10
    Michael Paquier authored
    Those would use the default ERRCODE_INTERNAL_ERROR, but for foreseeable
    failures an errcode ought to be set, ERRCODE_DATA_CORRUPTED making the
    most sense here.
    
    While on the way, fix one errcode_for_file_access missing in origin.c
    since the code has been created, and remove one assignment of errno to 0
    before calling read(), as this was around to fit with what was present
    before 811b6e36 where errno would not be set when not enough bytes are
    read.  I have noticed the first one, and Tom has pinged me about the
    second one.
    
    Author: Michael Paquier
    Reported-by: Tom Lane
    Discussion: https://postgr.es/m/27265.1531925836@sss.pgh.pa.us
    e41d0a10
snapbuild.c 61.4 KB