• Tom Lane's avatar
    Rethink function argument sorting in pg_dump. · e3bfe6d8
    Tom Lane authored
    Commit 7b583b20 created an unnecessary
    dump failure hazard by applying pg_get_function_identity_arguments()
    to every function in the database, even those that won't get dumped.
    This could result in snapshot-related problems if concurrent sessions are,
    for example, creating and dropping temporary functions, as noted by Marko
    Tiikkaja in bug #12832.  While this is by no means pg_dump's only such
    issue with concurrent DDL, it's unfortunate that we added a new failure
    mode for cases that used to work, and even more so that the failure was
    created for basically cosmetic reasons (ie, to sort overloaded functions
    more deterministically).
    
    To fix, revert that patch and instead sort function arguments using
    information that pg_dump has available anyway, namely the names of the
    argument types.  This will produce a slightly different sort ordering for
    overloaded functions than the previous coding; but applying strcmp
    directly to the output of pg_get_function_identity_arguments really was
    a bit odd anyway.  The sorting will still be name-based and hence
    independent of possibly-installation-specific OID assignments.  A small
    additional benefit is that sorting now works regardless of server version.
    
    Back-patch to 9.3, where the previous commit appeared.
    e3bfe6d8
pg_dump.c 477 KB