• Heikki Linnakangas's avatar
    Replace isMD5() with a more future-proof way to check if pw is encrypted. · dbd69118
    Heikki Linnakangas authored
    The rule is that if pg_authid.rolpassword begins with "md5" and has the
    right length, it's an MD5 hash, otherwise it's a plaintext password. The
    idiom has been to use isMD5() to check for that, but that gets awkward,
    when we add new kinds of verifiers, like the verifiers for SCRAM
    authentication in the pending SCRAM patch set. Replace isMD5() with a new
    get_password_type() function, so that when new verifier types are added, we
    don't need to remember to modify every place that currently calls isMD5(),
    to also recognize the new kinds of verifiers.
    
    Also, use the new plain_crypt_verify function in passwordcheck, so that it
    doesn't need to know about MD5, or in the future, about other kinds of
    hashes or password verifiers.
    
    Reviewed by Michael Paquier and Peter Eisentraut.
    
    Discussion: https://www.postgresql.org/message-id/2d07165c-1793-e243-a2a9-e45b624c7580@iki.fi
    dbd69118
user.c 45.5 KB