• Tom Lane's avatar
    Avoid using INFO elevel for what are fundamentally debug messages. · db438318
    Tom Lane authored
    Commit 6f6b99d1 stuck an INFO message into the fast path for
    checking partition constraints, for no very good reason except
    that it made it easy for the regression tests to verify that
    that path was taken.  Assorted later patches did likewise,
    increasing the unsuppressable-chatter level from ALTER TABLE
    even more.  This isn't good for the user experience, so let's
    drop these messages down to DEBUG1 where they belong.  So as
    not to have a loss of test coverage, create a TAP test that
    runs the relevant queries with client_min_messages = DEBUG1
    and greps for the expected messages.
    
    This testing method is a bit brute-force --- in particular,
    it duplicates the execution of a fair amount of the core
    create_table and alter_table tests.  We experimented with
    other solutions, but running any significant amount of
    standard testing with client_min_messages = DEBUG1 seems
    to have a lot of output-stability pitfalls, cf commits
    bbb96c37 and 5655565c.  Possibly at some point we'll look
    into whether we can reduce the amount of test duplication.
    
    Backpatch into v12, because some of these messages are new
    in v12 and we don't really want to ship it that way.
    
    Sergei Kornilov
    
    Discussion: https://postgr.es/m/81911511895540@web58j.yandex.ru
    Discussion: https://postgr.es/m/4859321552643736@myt5-02b80404fd9e.qloud-c.yandex.net
    db438318
Mkvcbuild.pm 33.7 KB