• Tom Lane's avatar
    Revert exporting of internal GUC variable "data_directory". · da33a389
    Tom Lane authored
    This undoes a poorly-thought-out choice in commit 970a1868, namely
    to export guc.c's internal variable data_directory.  The authoritative
    variable so far as C code is concerned is DataDir; there is no reason for
    anything except specific bits of GUC code to look at the GUC variable.
    
    After yesterday's commits fixing the fsync-on-restart patch, the only
    remaining misuse of data_directory was in AlterSystemSetConfigFile(),
    which would be much better off just using a relative path anyhow: it's
    less code and it doesn't break if the DBA moves the data directory of a
    running system, which is a case we've taken some pains over in the past.
    
    This is mostly cosmetic, so no need for a back-patch (and I'd be hesitant
    to remove a global variable in stable branches anyway).
    da33a389
guc.h 14.9 KB