• Andres Freund's avatar
    logical decoding: Tell reorderbuffer about all xids. · d9e903f3
    Andres Freund authored
    Logical decoding's reorderbuffer keeps transactions in an LSN ordered
    list for efficiency. To make that's efficiently possible upper-level
    xids are forced to be logged before nested subtransaction xids.  That
    only works though if these records are all looked at: Unfortunately we
    didn't do so for e.g. row level locks, which are otherwise uninteresting
    for logical decoding.
    
    This could lead to errors like:
    "ERROR: subxact logged without previous toplevel record".
    
    It's not sufficient to just look at row locking records, the xid could
    appear first due to a lot of other types of records (which will trigger
    the transaction to be marked logged with MarkCurrentTransactionIdLoggedIfAny).
    So invent infrastructure to tell reorderbuffer about xids seen, when
    they'd otherwise not pass through reorderbuffer.c.
    
    Reported-By: Jarred Ward
    Bug: #13844
    Discussion: 20160105033249.1087.66040@wrigleys.postgresql.org
    Backpatch: 9.4, where logical decoding was added
    d9e903f3
reorderbuffer.h 10.3 KB